From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Lepiller Subject: Re: Renewing certificates with certbot Date: Wed, 06 Mar 2019 14:51:39 +0100 Message-ID: <2af1bc4240159d48ec7883b8c2fac590@lepiller.eu> References: <87fts0i0ga.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([209.51.188.92]:40128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1Wxt-0008P5-6C for guix-devel@gnu.org; Wed, 06 Mar 2019 08:52:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1Wxm-0002di-EO for guix-devel@gnu.org; Wed, 06 Mar 2019 08:52:05 -0500 In-Reply-To: <87fts0i0ga.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Cc: guix-devel@gnu.org Le 2019-03-06 14:42, Ludovic Courtès a écrit : > Hi, > > Julien Lepiller skribis: > >> I use certificates from let's encrypt for my website and mail servers, >> and found that there was an issue with certificates generated by the >> certbot service in Guix: the generated private keys are world-readable >> (in a directory that cannot be accessed by anyone but root, so it's OK >> I guess). OpenSMTPD is not happy with that though, so I have to chmod >> the files every time. I came up with a variant of the deploy-hook >> that's presented in the manual, and I'd like to update the example >> with it. Here it is: >> >> ;; Find running nginx and reload its configuration (for certificates) >> (define %my-deploy-hook >> (program-file >> "my-deploy-hook" >> #~(let* ((pid (call-with-input-file "/var/run/nginx/pid" read)) >> (cert-dir (getenv "RENEWED_LINEAGE")) >> (privkey (string-append cert-dir "/privkey.pem"))) >> ;; certbot private keys are world-readable by default, and >> smtpd complains >> ;; about that, refusing to start otherwise >> (chmod privkey #o600) >> (kill pid SIGHUP)))) >> >> What do you think? > > It sounds like a serious issue that private keys are world-readable. > Is > it a bug on our side or in Certbot? I think we should fix it so that > they are never world-readable, rather than document how to work around > the bug. > > WDYT? > > Thanks, > Ludo’. I don't think this is an issue: the file is world-readable, but the directory it's in is not accessible to anyone but root. OpenSMTPD still complains, but I think there's no security issue.