From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id mEwIEz48y2WuegEAqHPOHw:P1 (envelope-from ) for ; Tue, 13 Feb 2024 10:54:06 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id mEwIEz48y2WuegEAqHPOHw (envelope-from ) for ; Tue, 13 Feb 2024 10:54:06 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=soeren-tempel.net header.s=opensmtpd header.b=NUK4oRCf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=soeren-tempel.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707818046; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sXhitr4oDGKk5mv6TSYPlOzC7kGnoUHP+mE+MxtxIes=; b=lWwcMH5nxV2bR6qs3vHFqJebd9TmNI7DUJxSXph8c0wn0YOxorspxw+1JrKZGhCpb8W7bA NjC0eU9A3fw/K5y2dH6kENBN/KHWXmfd7HYuqevvoLCuboMjKnwByUFrUfoYr3uVQEj2bJ tK+i+RFa7O3QDq6bg+uW11sIWQiWxf9gd1kDrN7GTMwyBbOi7m5YHfxZw4c295BzrZsLbc T5GGuCsugdD7HYI32nvOzk/32QYfsKuI3UW8C1ICz/UOf7wM8cgdOtY2gErVxAxEO1KrlP G9eKwjlXnQddQh7vWZH3inPAp/aXU1tFcTaFGkEKYnF6xb7/fAKk3uPrux77eQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=soeren-tempel.net header.s=opensmtpd header.b=NUK4oRCf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=soeren-tempel.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707818046; a=rsa-sha256; cv=none; b=iQjrSkrORNb8G/S+Noc0oP6JTH1RC40YT18iLRh62neqEbOUovOLv7+gKAzghFTZFkfRC2 lZs3D3ScOCMLov5TVwAa7hlsPKc0cpiQMDRB6iZELEwFeJnbHm/FTE8XzgZdffMWWICPzY HIRyAxLSEpxbdbsfbtHmdK5W4Gnjxi+kR8dgi329Jo5ebpuYhKWR//Ezit+xXl+abwobwU X7WVREzP7+rAV2W58jHx0D+EtwbobiPaRIKGFVhE5ko+qz1zQr213ePO/XdJW7enYnYZDR x1RkkWsb4IoVBwS3ZMnXKSNo/hwzwmB4YXhx+Qqx7hTjsy1c7lt0ZdHyAyrVtg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3C30C61DC8 for ; Tue, 13 Feb 2024 10:54:06 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZpU5-0000DX-UX; Tue, 13 Feb 2024 04:53:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZpU1-00005j-C4 for guix-patches@gnu.org; Tue, 13 Feb 2024 04:53:46 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rZpU1-0002S9-2y for guix-patches@gnu.org; Tue, 13 Feb 2024 04:53:45 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rZpUI-0004Ad-4M for guix-patches@gnu.org; Tue, 13 Feb 2024 04:54:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69074] Re: [bug#69074] [PATCH] Add python-angr. References: Resent-From: =?UTF-8?Q?S=C3=B6ren?= Tempel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Feb 2024 09:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69074 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69074@debbugs.gnu.org Cc: troy@troyfigiel.com Received: via spool by 69074-submit@debbugs.gnu.org id=B69074.170781798815952 (code B ref 69074); Tue, 13 Feb 2024 09:54:02 +0000 Received: (at 69074) by debbugs.gnu.org; 13 Feb 2024 09:53:08 +0000 Received: from localhost ([127.0.0.1]:41620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZpTO-00049C-8i for submit@debbugs.gnu.org; Tue, 13 Feb 2024 04:53:07 -0500 Received: from magnesium.8pit.net ([45.76.88.171]:4056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZpTK-00048o-O8 for 69074@debbugs.gnu.org; Tue, 13 Feb 2024 04:53:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=opensmtpd; bh=kf2KRET5Y6 m/X5KEnQbgLMy3/TCm5Vqp+jw0mjoE0ps=; h=from:subject:in-reply-to:cc:to: date; d=soeren-tempel.net; b=NUK4oRCf/+AdpQmX9ctT5StbkfKh8o0mLD/yvgVCn +i7HpDK5dN1HnLWJG5nOBjiWR/GBHHEVH3rzi/tE4oUR0LBdMk1rIM14IoraVRylI5qz+d uI8H+JQn4inPMxhwKWZEjMJz9NRuDgVW2d56DzIg9TC9tdwTArCZsc+hVtWM= Received: from localhost (dynamic-2a02-3102-49da-001b-70e4-2f12-f512-474f.310.pool.telefonica.de [2a02:3102:49da:1b:70e4:2f12:f512:474f]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id b2b2f9cc (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Tue, 13 Feb 2024 10:52:39 +0100 (CET) Date: Tue, 13 Feb 2024 10:53:03 +0100 In-Reply-To: <87v86tb8fw.fsf@troyfigiel.com> From: =?UTF-8?Q?S=C3=B6ren?= Tempel Message-Id: <2T2LBWR63TVNP.3NFUJ8AHKFC01@8pit.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 2.52 X-Spam-Score: 2.52 X-Migadu-Queue-Id: 3C30C61DC8 X-Migadu-Scanner: mx12.migadu.com X-TUID: dU5vgv/bNGHz Hi Troy, First of all, thanks for the quick feedback. Much appreciated! > Just a small note, I had to switch the order of python-pysmt and > python-claripy to be able to apply this patch series. Somehow these are > sent out of order. Sorry about that! I guess because I send 15 emails at once, the MTA queued some of them and then just didn't send them in the original order (which it isn't required to). I don't think there is much I can do about it on my end. I suppose `git-format-patch --numbered` would help? > - python-mulpyplexer actually does have tests. The file mulpyplexer.py > itself is the test. Good catch! I will just enable those [0]. > - python-rpyc seems to have an extensive test suite. Do all of them need > a network connection? It would be nicer to surgically remove the tests > that cannot be run. Sure, we can enable parts of the test suite [1]. > - python-ailment skips both tests it runs. This might need to be looked > into or commented why this happens. The first test is skipped because it needs python-pyvex, the second is skipped because it needs python-angr. The first also indirectly depends on angr because the VEX converter within ailment needs it. Therefore, we cannot enable these tests as they would would result in a cyclic dependency (python-angr <-> python-ailment). I can add a comment. > - python-angr does not build for me, because a test is failing. I think > you might have some nondeterministic behaviour in your build: The test performs benchmark using time.time() and expects a minimum timespan to be satisfied [2]. Therefore, it depends on the current load and the host CPU. Never failed for me, but probably good to disable it? > - Would it make more sense to place python-archinfo and > python-keystone-engine under engineering.scm? The current placement > creates a direct import cycle engineering->python-xyz->engineering Sure, I can move them accordingly. > - The changes to local.mk and the patches are not mentioned in the > commit messages. Good find, I will fix this in the next revision of this patchset. P.S: Should I resend the whole patch series with the updates or should I only resend the patches that changed due to the outlined updates? Also let me know if I should send a revision immediately or if you want me to wait for further feedback. Greetings S=C3=B6ren [0]: https://github.com/nmeum/guix-symex/commit/c16f563502595bd9c17f7eb05a5= c30bc7712006b [1]: https://github.com/nmeum/guix-symex/commit/9e36fbccb633392c34216b2deab= 73667f7769cc1 [2]: https://github.com/angr/angr/blob/76da4fcb17efbf2373b2e7dd600b0ee578df= 3dd7/tests/storage/test_memory.py#L566