From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:54750) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jTDzi-00045D-Tr for guix-patches@gnu.org; Mon, 27 Apr 2020 20:21:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jTDzi-0007ua-EE for guix-patches@gnu.org; Mon, 27 Apr 2020 20:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55109) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jTDzi-0007uV-1c for guix-patches@gnu.org; Mon, 27 Apr 2020 20:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jTDzh-0001Qx-TU for guix-patches@gnu.org; Mon, 27 Apr 2020 20:21:01 -0400 Subject: [bug#38650] [PATCH] gnu: adds hackrf Resent-Message-ID: Message-ID: <29924c336e19292151b1f9fbf991f89531446477.camel@librehacker.com> From: Christopher Howard Date: Mon, 27 Apr 2020 16:20:15 -0800 In-Reply-To: <871ro97xjz.fsf@yamatai> References: <33d8820578a5011bfd66f694b32f2e60d273469d.camel@librehacker.com> <542784b9e65b06a69bf1cd17f10cf4343b411b8e.camel@qlfiles.net> <871ro97xjz.fsf@yamatai> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Guillaume Le Vaillant , 38650@debbugs.gnu.org Can those minor tweaks be added by whomever is applying the patch, or do I need to submit a new patch? -- Christopher Howard p: +1 (907) 374-0257 w: https://librehacker.com social: https://gnusocial.club/librehacker gpg: ADDEAADE5D607C8D (keys.gnupg.net) On Mon, 2020-04-27 at 17:33 +0200, Guillaume Le Vaillant wrote: > Hi, > > Christopher Howard skribis: > > > I have asked many times about the new release over the last few > > months, > > and each time hackrf team says it is a week or so away. But their > > last > > git commit was in February. Requesting to please proceed with the > > latest commit as represented in this patch. I have added > > information to > > the description as requested. > > > > Using the old 2018 release would be unsatisfactory due to an > > annoying > > bug related to maintaining connections to hackrf devices. > > I noticed that the package definition builds 'lib/libhackrf.a'; > installing static libraries is usually disabled for Guix packages. > Also, some of the lines of the package definition are indented with > tabs > instead of spaces, and the commit message is missing the > " * gnu/packages/radio.scm (hackrf): New variable." line. > > > As an additional motivation for adding this, I believe you need > > libhackrf installed to use hackrf with gnuradio, through the > > osmocom > > interface. (I'm not at the moment quite clear on what exactly you > > have > > to enable in the gnuradio package definitions to link those > > together.) > > E.g., https://packages.debian.org/stretch/gr-osmosdr > > In theory, adding the hackrf package as input of the gnuradio-osmosdr > package should be enough (the library should be auto-detected when > compiling and the support activated). > However, I don't have the hardware to test if it really works.