From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id EGiBAZqvQGS+IgEASxT56A (envelope-from ) for ; Thu, 20 Apr 2023 05:20:58 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IFOLAZqvQGTTjAAAauVa8A (envelope-from ) for ; Thu, 20 Apr 2023 05:20:58 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 927E82CA07 for ; Thu, 20 Apr 2023 05:20:57 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppKqW-0002uN-Lf; Wed, 19 Apr 2023 23:20:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppKqV-0002uF-4l for guix-devel@gnu.org; Wed, 19 Apr 2023 23:20:31 -0400 Received: from coleridge.kublai.com ([166.84.7.167] helo=mail.spork.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppKqT-0005up-IA for guix-devel@gnu.org; Wed, 19 Apr 2023 23:20:30 -0400 Received: from smtpclient.apple (ool-18b8e9e7.dyn.optonline.net [24.184.233.231]) by mail.spork.org (Postfix) with ESMTPSA id 35FA88087; Wed, 19 Apr 2023 23:20:13 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=spork.org; s=dkim; t=1681960826; bh=HnbpTHMaOc8w9dEnyEKjoC1xNVpW70jtcadWZ4gsiQI=; h=From:Subject:Date:Cc:To; b=xAVBHp0TGla7yNVcEk2KCVXkN/+zjGfWOLEellhCmeipxaxD8DA0IO0if9eugwwh1 AukF9sXRY0k3V0Jm3UT3FKM8tu39Y7onf6tqjfn0OvkWDS7Cf4/eH3hXhpGtMNgy4B d1pasztFib6No5C1R5PLKqEVdeDTVjilF6ezbAMw= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (1.0) Subject: Re: [core-updates] issues with python's zip Message-Id: <298EE52B-FDD7-4C75-A6EB-801D1CBF280C@spork.org> Date: Wed, 19 Apr 2023 23:20:02 -0400 Cc: guix-devel To: Andreas Enge X-Mailer: iPhone Mail (20D67) Received-SPF: pass client-ip=166.84.7.167; envelope-from=bjc@spork.org; helo=mail.spork.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Brian Cully From: Brian Cully via "Development of GNU Guix and the GNU System distribution." Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spork.org header.s=dkim header.b=xAVBHp0T; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681960857; a=rsa-sha256; cv=none; b=njRY0c66tP8Xx3zoO5jVL1EaWaM8k1B8tm1+e2SzR7QLpqF/wel1kZFrmsqUxedgII31bb G/wRxLtRU+OVGE5aWLIJtr3tjfWisQ2cSbcVgzisO36+sjT92RGt21oFx5zzGMVthrpOJP 1SjUfLiY+NdzCahvBW8unUE2LYeUpfCUfYE9+Ln6t6yJ6+4jljFN3ESq17IVOx1w9t0eVi cYNFXTQyST32ULyN8eO6HMkdcWC3ssgvftcpllM1vpR4Avqni3uIo2cUQWdp9gLGKn/2Be ek09LNoL/8jbBzDjBWsudG22Eb2vuENRMS8tx4uOJcM2qErSNVEg4RxPo8NEpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681960857; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=gokn9LB7DDXtuJZtIsDUD/wbfgyrUj3nBB0xF8gVCN8=; b=mED3Illp8KVpz97GrLdHtoo995mmVa3w+pxE52ZhOkvpHPtaR2U1hTv94Jf96QMxLucwX/ CJLjZw8utvux/ipPhsqlXvY9pKHer2foCw/nuugxe++T8zpbQkl07oKKU01uor8wSVPUTC zzyF98zBSNgy5lJ87OBegn+5abHwiY+RcEGiYEDjLA+nfbrFM4DcrVRNR5DRYE3veF/Qwo AGv8LsOT5t2DYlRr/LJhdlW10rexHxWU5+LRtBpAUMQyjkoh8luSGSvZovu4fm/9kj7HPh 9RmTCCEg8fAXn1oXwtpoTPGzz/ADrpeJkHQlvzOCTvaERCR7EAbpHhS2PY80BA== X-Migadu-Spam-Score: -2.51 X-Spam-Score: -2.51 X-Migadu-Queue-Id: 927E82CA07 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=spork.org header.s=dkim header.b=xAVBHp0T; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: XpHFMjjwQppd =EF=BB=BF Andreas Enge writes: > I came across this: > https://docs.python.org/3/library/zipfile.html#zipfile-objects > So apparently when creating a zipfile object (this is the constructor > we are looking at, right?), one can pass a parameter that tells it to > not bother about time stamps of old files. >=20 > Then it is a matter of finding out where it happens. I think it is > line 450 of (in my case) > /gnu/store/dy3xh053ahkhrp2jamggq8cpsyvp8mg0-python-3.10.7/lib/python3.10/s= ite-packages/setuptools/command/bdist_egg.py > which reads > z =3D zipfile.ZipFile(zip_filename, mode, compression=3Dcompression= ) > Maybe we should patch our Python so that it becomes > z =3D zipfile.ZipFile(zip_filename, mode, compression=3Dcompression= , strict_timestamps=3DFalse) > ? > (not before the core-updates merge, however) Thanks for digging into this. Maybe it makes sense to patch bdist_egg.py in s= etuptools, then, rather than chase down every failed build? > But is a bit surprising that it does not happen all the time; > or are only a few packages calling bdist_egg.py? I don't know. According to https://www.python101.pythonlibrary.org/chapter38= _eggs.html it's an older format, which has been superseded by =E2=80=98wheel= =E2=80=99. I know I see wheel a fair amount, but I'm not much of a Python ha= cker. -bjc