From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id ADSWK0GJPGbwOQEAe85BDQ:P1 (envelope-from ) for ; Thu, 09 May 2024 10:28:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id ADSWK0GJPGbwOQEAe85BDQ (envelope-from ) for ; Thu, 09 May 2024 10:28:49 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=i6WTvXoJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715243328; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=VDGjnYdTYGxmr31Mmss7Jsmmq3eQcSJl9/Zl+bXKBRM=; b=WLjRaDndAWE9JQfuKrr6gn+OAXysso/Fxyq8jHmCazmWknbIV6D9CgcHjHNxoiNMiKzIwD GsadvWUXY2w7IUtGhlXK7nYZwqTVeRvR7pYiD9Hu7ey7qMStDPz216xN6F6NRk7EhiDG1V LqMCZKiQ865wStJmXZbu/BE0GvUcQ9mVlD5+maVLZ8Lo50M67jalqCbjPGw6YNfMcs5UUj cIurKiZ3Ay6fkPKbbfATFBr/APJs3czTx56648YpwDiLIxorZGD+WNbC7oZcnwTJC6FgVO H6Ui3YiqSeOktjjR4o64Wjm4HE+XsIgEyPjXcQ4B/uCw3gAzypj2Gt65l2YGNw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=i6WTvXoJ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715243328; a=rsa-sha256; cv=none; b=ARLgJL4dFjoONWy99uxWhF7K+HSaU3MvTSmvL7fH5nb9w2ha+jjgO1g8YV8ZYGfzVa+ydn DoeENop96+3uXKpUgHp2x0iWYBAIyOPK2EnReYByUh5QCCjDEteroOKEggAulqXmuEBHWo axmbpHrHFmyQk5hWHbtztdeZ/9Yb6xvFOh+VEmQpHyZUR1KLmT9s/udSqqUwRgd0tlg0Xs 1j2UlJHjpMdYbxw8RQybIsHSDT4qLEtzmhc0afXF9v5CiYCqkZjYo1P/V+j4uxipzYX06Z mB5JFe6C9CZ3G/tyIIrhCgJVUjuB9rn9iAaSKB7WXqiqQYZPL37eKCcMD+POEw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C3F773BA78 for ; Thu, 9 May 2024 10:28:48 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4z8p-0005JD-PE; Thu, 09 May 2024 04:28:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4z8n-0005Ic-7W for guix-patches@gnu.org; Thu, 09 May 2024 04:28:37 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s4z8m-0005Tw-Qi for guix-patches@gnu.org; Thu, 09 May 2024 04:28:36 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s4z9C-0004v2-EQ for guix-patches@gnu.org; Thu, 09 May 2024 04:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. Resent-From: Dariqq Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 May 2024 08:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70282 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , Maxim Cournoyer Cc: 70282@debbugs.gnu.org, Vivien Kraus Received: via spool by 70282-submit@debbugs.gnu.org id=B70282.171524329618900 (code B ref 70282); Thu, 09 May 2024 08:29:02 +0000 Received: (at 70282) by debbugs.gnu.org; 9 May 2024 08:28:16 +0000 Received: from localhost ([127.0.0.1]:53970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4z8S-0004um-02 for submit@debbugs.gnu.org; Thu, 09 May 2024 04:28:16 -0400 Received: from mout02.posteo.de ([185.67.36.66]:41219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4z8O-0004ug-CF for 70282@debbugs.gnu.org; Thu, 09 May 2024 04:28:14 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 32AC5240103 for <70282@debbugs.gnu.org>; Thu, 9 May 2024 10:27:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1715243260; bh=5xIkxU1R9tVUXKtlRnbQsAOK2nI5dMFY1u7k06zdITI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=i6WTvXoJ12UQgcoU3O4aqnF8J6vPRXZIvRcaf31LGvhsF1X8T+L91f/ef3Ld5cxKF RerLG3ZwrhN11thRGDR7wPAXK0QkmcdZZnaK/n4974SwYIsllG7FWvvUQd/XQ9U+uS 7IFFZFWb6VJs83kwdlzmslCABWkpnhcy/VhJW/j9JtLw3422ucgXFl8U84F04ahqvq inPP/ioT8oebVdZ43k9/AhaChu3ook4fXbPdU/uYcn6XIExG12AVjNDbWZgpbxLgcX dwcCcjO6hMlZIitgs2mDjSGYDctQ/LSO3n20MDQPv+Ihzaje7w6arNn90jjAb5q3qe zLNjf5bgn8Ppw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VZlWH4rZdz6tvd; Thu, 9 May 2024 10:27:39 +0200 (CEST) Message-ID: <2957c0c2-29b1-43c4-886f-83623d07c9d0@posteo.net> Date: Thu, 9 May 2024 08:27:37 +0000 MIME-Version: 1.0 References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> <87cypw6q0x.fsf@gmail.com> <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> <4593fcd10c303e41eee6afc187e9b5a1baad733f.camel@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <4593fcd10c303e41eee6afc187e9b5a1baad733f.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 3.98 X-Spam-Score: 3.98 X-Migadu-Queue-Id: C3F773BA78 X-Migadu-Scanner: mx13.migadu.com X-TUID: FpjPdQoJ5gUs Hi Liliana, On 09.05.24 00:11, Liliana Marie Prikler wrote: > Hi Dariqq, > > Am Mittwoch, dem 08.05.2024 um 21:18 +0000 schrieb Dariqq: >> [...] >> >> On 08.05.24 21:51, Maxim Cournoyer wrote: >> >>> [...] >>> Perhaps a simple patch would convey the change better and be easier >>> to >>> maintain in the future / be readily available for other >>> distributions to >>> use. >> >> The simple patch that would do this is basically the patch from nixos >> in v1 of this which adds a shebang line for gjs to the service >> invocation files (rather than the dbus service invoking $gjs >> $service). The problem then is that wrap-program changes the filename >> to * .real which makes gjs unhappy. >> >> [...] >> Maybe another comment, similiar to the one Liliana suggested earlier >> in this thread, could be added at the beginning to inform about >> changing to wrap script + patch instead once that is a viable option? > The pattern we typically use is to add an autotools-style "variable", > e.g. @GNOME_SHELL_GST_PLUGIN_SYSTEM_PATH@ through a patch, then use > substitute* to fill it in. I don't think it's a requirement, but since > Maxim suggested, it'd definitely be nice to have. How would this work in this case for gnomeshell? Put the js that gets concatenated here into the actual file with a patch adding placeholder variables for GST Plugin path and gi typelib path and replace later? As these js files get generated from a common template for each service this would require substituting all of them and not only the screencast service. > > Cheers >