From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EGU2GP8EmWKtJAAAbAwnHQ (envelope-from ) for ; Thu, 02 Jun 2022 20:44:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id +Fw4GP8EmWLMoAAAauVa8A (envelope-from ) for ; Thu, 02 Jun 2022 20:44:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 08D113EBA9 for ; Thu, 2 Jun 2022 20:44:15 +0200 (CEST) Received: from localhost ([::1]:60210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwpnq-0003sD-9m for larch@yhetil.org; Thu, 02 Jun 2022 14:44:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwpnd-0003pt-W6 for guix-patches@gnu.org; Thu, 02 Jun 2022 14:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwpnd-0003UZ-Ln for guix-patches@gnu.org; Thu, 02 Jun 2022 14:44:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nwpnd-0001fk-IS for guix-patches@gnu.org; Thu, 02 Jun 2022 14:44:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55769] [PATCH] gnu: Add xwhite. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 Jun 2022 18:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55769 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: derekchuank@outlook.com, 55769@debbugs.gnu.org Received: via spool by 55769-submit@debbugs.gnu.org id=B55769.16541954216394 (code B ref 55769); Thu, 02 Jun 2022 18:44:01 +0000 Received: (at 55769) by debbugs.gnu.org; 2 Jun 2022 18:43:41 +0000 Received: from localhost ([127.0.0.1]:54601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwpnJ-0001f1-G6 for submit@debbugs.gnu.org; Thu, 02 Jun 2022 14:43:41 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:37284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwpnG-0001es-Py for 55769@debbugs.gnu.org; Thu, 02 Jun 2022 14:43:40 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id eJjd2700B4UW6Th01JjdwE; Thu, 02 Jun 2022 20:43:37 +0200 Message-ID: <2944e4aeb64f24e053e972440b2649333679cc9a.camel@telenet.be> From: Maxime Devos Date: Thu, 02 Jun 2022 20:43:33 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-gEDx3728CpRqBAwW+s4A" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1654195417; bh=SK51mJHGMNO0VehU5Lnb7pyXbrvH4EuIUt2w6TfRJP4=; h=Subject:From:To:Date:In-Reply-To:References; b=f4O8bK5yYfHS3VFbJoFy+bYkBYKEH02tPoPKYz4oUyQPabGlDai/Wxs8YBi4O0ZR0 ufS23IiR0JK6DOztOiKg1HvK2Oh4f8VQO1e720JR9ufNufJGKL1C1DyAibCV8C9C1P MUtgajYNcGmjN5IcRtrWvrcslpbi5tpzgHliXGeHDBFgFGx/TFmmt90y5ux3HNEw/A NkQCBuqnEadD1lhNMJKZoMiB18j2WONxLWCinsNygRb2yE6zYvWRtmKvFabvLSrDjG IwBJbnun1PJY3K89EDU57BUXb0MtjlXDnQSCgyVCEWUEkOBL2WV6UsucxmpYGgSCHR Q4thSgWLynDow== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654195455; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=SK51mJHGMNO0VehU5Lnb7pyXbrvH4EuIUt2w6TfRJP4=; b=bSr4dr6Tfmg/Iy/MGnI8bAkAUJBbe8Ofl4f861wiGcwKjLSOOOON6ubMgHbPStAwf2m2QI v9PWiUl/oWbF6d8z3aMuY1HXfCoASpFeI1B4iJ00bOQNucBR8I9AsSdR8FYSKusZSgcYdz qZUhW8b/6unk/I+80cnupiIvsDSbZRCdgE2BcvS5iwiCTcG5DqZ1zm+2fbJkzwHktJmkR8 3BU5WMnjLLKVPziSIIeqoNswS8RZ4yS4WKo4v3RzRyPI1bA1kTWtbeMIjuXkmyBjBA3Hw4 Yoi6OBqjLjxhQ/urdEBh38VsvYkUgxXMzHUzQMtSvq+xH1Pp4IlX1QlO2OdXng== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654195455; a=rsa-sha256; cv=none; b=Kb2zh6A1LGDRYQXwStnRWwuAUcYzpCxyZTI209cwmVKTIaU4kxhko+vApsB3GhQttrgYpg xR7UPsLuKSq3EBxj3IlacDzRuPbp96l/vhwQrvP2MjofbXUp/1wnW2YP1AOJCQJRmX69TQ BK9Du906dE8vCPp7opsFW5t8aKR07VvdeZ+mBZbuXTWZNrnYNLIPDTlix19i4SI1NcI5lW LaNiBhVUy5SpjoJoptOnx627a7Q+RXMw1cdzrZ5f23sqRhOXvEQ0uhS7iWHiYlZpX3OZQE ZiyriH7syoyA+/alv6r1kZmWbnnkmMgoefxfL9HfIuljPB9/dVr7qk/77CKILA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=f4O8bK5y; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.78 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=f4O8bK5y; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 08D113EBA9 X-Spam-Score: 2.78 X-Migadu-Scanner: scn0.migadu.com X-TUID: WcwMQSOqFds5 --=-gEDx3728CpRqBAwW+s4A Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable derekchuank@outlook.com schreef op do 02-06-2022 om 15:39 [+0000]: > + =C2=A0 =C2=A0(arguments > + =C2=A0 =C2=A0 `(#:tests? #f Always add a comment on why tests are disabled. In this case, probably because there are no tests? > + =C2=A0 =C2=A0 =C2=A0 #:phases > + =C2=A0 =C2=A0 =C2=A0 (modify-phases %standard-phases > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 (delete 'configure) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 (replace 'install > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (lambda* (#:key outputs #:allow-othe= r-keys) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ((out (assoc-ref outputs= "out"))) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (install-file "xwhite"= (string-append out "/bin")) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #t)))))) Trailing #t haven't been necessary anymore since a long time Also, a comment on the makefile. In the makefile you do CC=3Dgcc, but that won't work when cross-compiling, because then TARGET-gcc (e.g.=20 aarch64-linux-gnu-gcc) is required. There are multiple ways to resolve this, but given that you are upstream, I recommend switching to a build system such as, say, meson[0]. meson (and autotools) take care of such details for you (cross-compilation, also choosing the right installation directory). If you use meson or autotools, then you won't have to add any Guix phases or do cross-compilation detection in the makefile, you then only have to replace gnu-build-system by meson-build-system. A comment on the license: strictly speaking, you have licensed it as =E2=80=98any version of the GPL whatsoever=E2=80=99. From the GPL itself: > If the Program does not specify a version number of this License, you > may choose any version ever published by the Free Software > Foundation. I doubt that's what you mean, so maybe document it in the README to be GPL-2-or-later or GPL-2-only or GPL-2-OR-3-only? A comment on the code itself: I recommend returning a non-zero value on failure. Also, all this is already implemented by another tool: $ redshift -P -g 2:2:0.1 -O 10000 so to me there appears to be no need to write, maintain and package a new tool. [0] https://mesonbuild.com/ Greetings, Maxime --=-gEDx3728CpRqBAwW+s4A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYpkE1RccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7jc5AQCKk6E9g2ghOr4SKCfuir+VUZ+W eZIb6WZDLMk8Un2AcwEA4cwuSi6ftRCkQ8py9SVN/zwH1L+Y3ZmcZnmb7c9AGAc= =+XQL -----END PGP SIGNATURE----- --=-gEDx3728CpRqBAwW+s4A--