From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ew6GE-0000WX-0d for guix-patches@gnu.org; Wed, 14 Mar 2018 09:16:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ew6GA-0002bj-ST for guix-patches@gnu.org; Wed, 14 Mar 2018 09:16:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:52626) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ew6GA-0002bX-Nn for guix-patches@gnu.org; Wed, 14 Mar 2018 09:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ew6GA-00032F-Go for guix-patches@gnu.org; Wed, 14 Mar 2018 09:16:02 -0400 Subject: [bug#30606] maven resolver packages Resent-Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 14 Mar 2018 14:15:16 +0100 From: julien lepiller In-Reply-To: <20180314073638.385d73c8@alma-ubu> References: <20180225164822.60ae5c2a@lepiller.eu> <20180314073638.385d73c8@alma-ubu> Message-ID: <27d51c4e39631597e0433f7f173fc07a@lepiller.eu> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 30606@debbugs.gnu.org Le 2018-03-14 07:36, Björn Höfling a écrit : > Hi Julien, > > sorry I was slower reviewing than you commiting this one. > > On Sun, 25 Feb 2018 16:48:22 +0100 > Julien Lepiller wrote: > >> Hi, >> >> here are the first few packages needed by maven. I created a new >> maven.scm file for them. > > > All 5 look good, besides maybe this remark: > > These packages are used to bootstrap Maven. Once we have Maven and a > maven-build-system, we eventually want to rebuild them with Maven and > have them in some (to be defined) Guix-Maven-Layout, for example with > pom.xml included and in the usual .m2/repository directory-structure. > > Should we thus rename them to maven-*-bootstrap and just (define them > instead of (define-public? > > Björn Hi Björn, I think it's OK to leave them as is for now but I don't really have any objection to your suggestion, so I'll add it to my TODO list and push a patch before the next series. I'm trying to improve the rest of my packages so it may take some time. Thank you!