all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Ryan Sundberg <ryan@arctype.co>,
	Pierre Langlois <pierre.langlois@gmx.com>
Cc: 53414@debbugs.gnu.org
Subject: [bug#53414] [PATCH] update Node LTS to 16.13.2
Date: Thu, 09 Jun 2022 22:53:43 +0200	[thread overview]
Message-ID: <26811c03516bbbd923b666e69380cf2cf86f6cc6.camel@telenet.be> (raw)
In-Reply-To: <65d2c6fb-9882-5815-b6b3-5eb6f7011464@arctype.co>

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

Ryan Sundberg via Guix-patches via schreef op wo 08-06-2022 om 23:39 [-
0700]:
> +              (modules '((guix build utils)))
> +              (snippet
> +               `(begin
> +                  ;; Remove bundled software, where possible
> +                  (for-each delete-file-recursively
> +                            '("deps/cares"
> +                              "deps/icu-small"
> +                              "deps/nghttp2"
> +                              "deps/openssl"
> +                              "deps/zlib"))
> +                  (substitute* "Makefile"
> +                    ;; Remove references to bundled software.
> +                    (("deps/uv/uv.gyp") "")
> +                    (("deps/zlib/zlib.gyp") ""))
> +                  #t))))

This is identical to what node-14 has, so you can use inheritance to
simplify things:

  (origin
    (inherit (package-source node-14))
    (uri ...)
    (sha256 ...))

Also, could you verify that no new things have been bundled?

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2022-06-09 20:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-21 15:11 [bug#53414] [PATCH] update Node LTS to 16.13.2 zamfofex
2022-02-23 13:13 ` code
2022-02-25 11:07   ` Maxime Devos
2022-02-25 11:24     ` code
2022-02-25 12:38       ` Maxime Devos
2022-02-25 13:09 ` Attila Lendvai
2022-02-25 15:59   ` Maxime Devos
2022-02-25 16:31     ` Pierre Langlois
2022-02-25 17:22       ` Maxime Devos
2022-05-02  6:10         ` Ryan Sundberg via Guix-patches via
2022-05-15 13:45           ` Pierre Langlois
2022-06-09  6:39             ` Ryan Sundberg via Guix-patches via
2022-06-09 20:49               ` Maxime Devos
2022-06-09 20:50               ` Maxime Devos
2022-06-09 20:53               ` Maxime Devos [this message]
2022-06-09 20:55               ` Maxime Devos
2022-06-09 21:03               ` Maxime Devos
2022-11-16 23:23                 ` Mekeor Melire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26811c03516bbbd923b666e69380cf2cf86f6cc6.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=53414@debbugs.gnu.org \
    --cc=pierre.langlois@gmx.com \
    --cc=ryan@arctype.co \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.