From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:39444) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jL2WV-00078H-Jn for guix-patches@gnu.org; Sun, 05 Apr 2020 06:29:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jL2WU-0006OA-K6 for guix-patches@gnu.org; Sun, 05 Apr 2020 06:29:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33694) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jL2WU-0006O4-HM for guix-patches@gnu.org; Sun, 05 Apr 2020 06:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jL2WU-0000js-E7 for guix-patches@gnu.org; Sun, 05 Apr 2020 06:29:02 -0400 Subject: [bug#40445] gnu: gsm: Update to 1.0.19. Resent-Message-ID: Mime-Version: 1.0 Date: Sun, 05 Apr 2020 10:28:20 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: "Raghav Gururajan" Message-ID: <265df2102f5ed69aa35fc059dbb4d8e5@disroot.org> In-Reply-To: References: <87pncmcjuo.fsf@gmail.com> <87d08ms22w.fsf@gmail.com> <9fde0f2d6cf97a9368ae132a717cf18a@disroot.org> <06e6a1cfe8a54f80493a4e9f2820399b@disroot.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Othacehe Cc: 40445@debbugs.gnu.org Hi Mathieu!=0A=0A>> Ok, I see. Maybe it would be preferable to find a way= to add "-fPIC" to=0A>> CCFLAGS without having to repeat all the other op= tions that are already=0A>> present in the Makefile:=0A>> =0A>> --8<-----= ----------cut here---------------start------------->8---=0A>> CCFLAGS =3D= -c -O2 -DNeedFunctionPrototypes=3D1 -Wall -Wno-comment=0A>> --8<--------= -------cut here---------------end--------------->8---=0A>> =0A>> Adding a= new 'add-fpic-ccflag' phase could be an option?=0A> =0A> We can do that = too. But this seems simple and less messy :-)=0A=0AAlso, I believe, the m= ake-flag just overwrites that line in the source.=0A=0ARegards,=0ARG.