From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aMIlGfipll/FDwAA0tVLHw (envelope-from ) for ; Mon, 26 Oct 2020 10:50:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id YcIMFfipll8PWAAAB5/wlQ (envelope-from ) for ; Mon, 26 Oct 2020 10:50:32 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DC390940366 for ; Mon, 26 Oct 2020 10:50:31 +0000 (UTC) Received: from localhost ([::1]:52354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kX058-0001B7-SD for larch@yhetil.org; Mon, 26 Oct 2020 06:50:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWzvy-0005Bt-CY for guix-patches@gnu.org; Mon, 26 Oct 2020 06:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55258) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWzvy-0002DJ-00 for guix-patches@gnu.org; Mon, 26 Oct 2020 06:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWzvx-0004JM-T0 for guix-patches@gnu.org; Mon, 26 Oct 2020 06:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43781] [PATCH 2/2] gnu: Add cgoban Resent-From: =?UTF-8?Q?Tom=C3=A1s_?= =?UTF-8?Q?Ort=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 26 Oct 2020 10:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43781 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 43781-submit@debbugs.gnu.org id=B43781.160370884816540 (code B ref 43781); Mon, 26 Oct 2020 10:41:01 +0000 Received: (at 43781) by debbugs.gnu.org; 26 Oct 2020 10:40:48 +0000 Received: from localhost ([127.0.0.1]:38571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWzvj-0004Ii-VL for submit@debbugs.gnu.org; Mon, 26 Oct 2020 06:40:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWzvi-0004IV-0O for 43781@debbugs.gnu.org; Mon, 26 Oct 2020 06:40:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51872) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWzvc-00024g-Oa for 43781@debbugs.gnu.org; Mon, 26 Oct 2020 06:40:40 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=60784 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kWzvb-0005Xp-Cr for 43781@debbugs.gnu.org; Mon, 26 Oct 2020 06:40:40 -0400 Resent-To: 43781@debbugs.gnu.org Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Resent-Date: Mon, 26 Oct 2020 11:40:38 +0100 Resent-Message-ID: <874kmhclsp.fsf@gnu.org> Received: from solo.fdn.fr ([unix socket]) by solo (Cyrus 2.5.10-Debian-2.5.10-3.2) with LMTPA; Thu, 22 Oct 2020 17:08:08 +0200 X-Sieve: CMU Sieve 2.4 Received: by solo.fdn.fr (Postfix) id 6983AD0EC1; Thu, 22 Oct 2020 17:08:08 +0200 (CEST) Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by solo.fdn.fr (Postfix) with ESMTPS id 51250D0EBF for ; Thu, 22 Oct 2020 17:08:08 +0200 (CEST) Received: from fencepost.gnu.org ([2001:470:142:3::e]:44896) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVcCD-0000w9-H2 for ludovic.courtes@fdn.fr; Thu, 22 Oct 2020 11:08:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36888) by fencepost.gnu.org with esmtps (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kVcCC-0006wW-WC for ludo@gnu.org; Thu, 22 Oct 2020 11:08:05 -0400 Received: from mout-p-103.mailbox.org ([80.241.56.161]:40714) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1kVcCA-0000uK-AC for ludo@gnu.org; Thu, 22 Oct 2020 11:08:04 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4CH9hp4xRLzQjgR for ; Thu, 22 Oct 2020 17:07:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h= message-id:from:from:reply-to:subject:subject :content-transfer-encoding:content-type:content-type :mime-version:references:in-reply-to:date:date:received; s= mail20150812; t=1603379271; bh=Jbw0WbcRiNgn1eAHT+LMD3lfMyabYte09 wSGCNigeiM=; b=GpxCcAikLny5Q0taIev2nJLLAYxIs/tXzXz5J4FGvpnpDd8f5 i/asb7GdK+ixUOdUab5YxEUt2eXXzaYAo8jCS1dzdV7SOGZvxgZ1p/HfEw1kxWWc Qv0t3ywFW1lfgaKvfU8M/JxMqE74rlVNptQYX23EVQBui24kS097enW/1FAO+gpB e/gkylq3jU+zDpsASq25m3ebZZUVq51JsKsZXU9N83jLzWzAbWaFH1n8I7Zm/edJ kyabYZBsiHnyh8lA2dbX/Ixi4uzUyoK330sSO5+da8uxAO1WWw0AYdS/NqFjr5ld SDh7TZpIElEDeWPpnTHx4Mm5GjmZaWsISB7fA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1603379272; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oyPulrdGjPE9a4Euu16LWI8cZkaOtcGKlfOEr2aiGJQ=; b=cRuZ1JhCx7usaqao3yYCGHLxjxHtdYPJbP0gpBHAmUpuvxpbLHCqN8ms+1FazQqKRkr6Zj 29lmI2rDd8lCpRYVW2rgS0yRh4y4OC+i8EVJAdebx720611/KjiZVTk9esU+Vwz07RuTAc AOygy06ancTKuW4K8rQq5qj0gaAP7ryrX68rQQ6pY/YDHr+/1r1fQRlFFkqLEp0uFrUZGU ydQgBf+oz7/4zpHq/zCaGSNjX0avYKI56ErQ7RTO1EUiDBefOGWCgKQ2jvsSRzRB+4JNYm tP43s6MnMBiww11B9N59K+zDbdF5i4sglhjxZtL31f2b/pe2Ha/4C7ADNrY3Pg== X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id OYWEbmDAzvvl for ; Thu, 22 Oct 2020 17:07:51 +0200 (CEST) Date: Thu, 22 Oct 2020 15:07:43 +0000 In-Reply-To: <871rhqtimt.fsf@gnu.org> References: <9f324abb-f935-b748-526b-467113e87670@mailbox.org> <871rhqtimt.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----VBO8B94DN398MZ1CXDYBF8CT6FDEI4" Content-Transfer-Encoding: 7bit Autocrypt: addr=tomasortin@mailbox.org; keydata= mDMEXzVXOhYJKwYBBAHaRw8BAQdAeV1PZETqdYSWKXvjaQvW/ZxH1qzGPj6VOUSfb8NrwZe0Fjxx dWFucm9uZ0BtYWlsYm94Lm9yZz6IiwQQFggAMwIZAQUCXzVXOgIbAwQLCQgHBhUICQoLAgMWAgEW IQSzlJJOBRtHeAIgnZD2jh7SIrkW/AAKCRD2jh7SIrkW/BJqAQDElzT+1zLmB6ea1W4rCdXb24ix tS3eMJMc3SOs+B67ygD/VfM1sLuDr68Bruvxz5JLSfRnbfHPzMOTOD0AXKRj3g+4OARfNVc6Egor BgEEAZdVAQUBAQdAcPfPBXKr57IFDIfZtWPGRWiYIGcSASTJ2BlrkVzvRE4DAQgHiHgEGBYIACAF Al81VzoCGwwWIQSzlJJOBRtHeAIgnZD2jh7SIrkW/AAKCRD2jh7SIrkW/Aq0AQDIQcD+w8jgbGrx sq8A1AeGhWc26fGkh6Bs7Vp/deUxfgD/REXV5Xq9QJfdhi/Rd1vF/xjFvKSOHUQ+fUGipDg3pgs= Message-ID: <264BCB13-4FA2-4713-810E-2704D3E45A15@mailbox.org> X-MBO-SPAM-Probability: X-Rspamd-Score: -6.23 / 15.00 / 15.00 X-Rspamd-Queue-Id: 952781710 X-Rspamd-UID: a7a253 Received-SPF: pass client-ip=80.241.56.161; envelope-from=tomasortin@mailbox.org; helo=mout-p-103.mailbox.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/22 11:07:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.3 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: =?UTF-8?Q?Tom=C3=A1s_?= =?UTF-8?Q?Ort=C3=ADn?= via Guix-patches Reply-To: tomasortin@mailbox.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=mailbox.org header.s=mail20150812 header.b=GpxCcAik; dkim=fail (rsa verify failed) header.d=mailbox.org header.s=mail20150812 header.b=cRuZ1JhC; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.51 X-TUID: NHh1DBi4yejK ------VBO8B94DN398MZ1CXDYBF8CT6FDEI4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Thank you for your feedback=2E I will add a comment about the tests=2E About the patch: it's taken from the Gentoo package=2E I first tried packa= ging cgoban without any package and it consistently failed at configure pha= se, no matter the flags I passed=2E I decided to check the Gentoo package t= o see how they built it, as I have used cgoban in that distribution before = and works well, and saw they just added this patch=2E Tried adding it, and = it works=2E But I won't pretend to understand why=2E If adding the patch is not a good solution, could someone help me figure o= ut how to properly pack cgoban? Sorry about the inconvenience=2E Tom=C3=A1s Ort=C3=ADn On October 22, 2020 2:55:38 PM UTC, "Ludovic Court=C3=A8s" wrote: >Hi, > >Tom=C3=A1s Ort=C3=ADn Fern=C3=A1ndez skribis: > >> Sorry, I see I should have sent it all in one email=2E >> >> * gnu/packages/games=2Escm (cgoban): New variable=2E > >Sorry for the delay! Some comments: > >> + (arguments >> + `(#:tests? #t)) > >Please add a short comment explaining why tests are disabled=2E > >> --- /dev/null >> +++ b/gnu/packages/patches/cgoban-1=2E9=2E14-cflags=2Epatch >> @@ -0,0 +1,40 @@ >> +--- a/configure=2Ein >> ++++ b/configure=2Ein > >Patches should start with a couple lines stating the origin, their >upstream status, and what they do=2E > >Patches also need to be listed in =E2=80=98gnu/local=2Emk=E2=80=99 and me= ntioned in the >commit log=2E > >However, I suspect this patch has no effect: since =E2=80=98autoconf=E2= =80=99 is not an >input of the package, its =E2=80=98configure=E2=80=99 script cannot be re= built to take >those changes into account=2E > >Perhaps you can just remove it? > >Could you send a second version? > >Thanks! > >Ludo=E2=80=99=2E ------VBO8B94DN398MZ1CXDYBF8CT6FDEI4 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello,

Thank you for your feedback=2E I wil= l add a comment about the tests=2E

About the patch: it's taken from = the Gentoo package=2E I first tried packaging cgoban without any package an= d it consistently failed at configure phase, no matter the flags I passed= =2E I decided to check the Gentoo package to see how they built it, as I ha= ve used cgoban in that distribution before and works well, and saw they jus= t added this patch=2E Tried adding it, and it works=2E But I won't pretend = to understand why=2E

If adding the patch is not a good solution, cou= ld someone help me figure out how to properly pack cgoban? Sorry about the = inconvenience=2E

Tom=C3=A1s Ort=C3=ADn

On October 22, 2020 2:55:38 PM UTC, "Ludovic Court=C3=A8s" <ludo@gn= u=2Eorg> wrote:
Hi,

Tom=C3=A1s Ort=C3=ADn Fern=C3=A1ndez <=
tomasortin@mailbox=2Eorg> skribis:

 Sorry, I see I should have sent it all in one email=2E<=
br>
 * gnu/packages/games=2Escm (cgoban): New variable=2E

Sorry for the delay!  Some comments:

+    (arguments
+     `(#:tests? #t))

Please add a short comment explaining why tests are disabled=2E
--- /dev/null
+++=
 b/gnu/packages/patches/cgoban-1=2E9=2E14-cflags=2Epatch
@@ -0,0 +1,40 @=
@
+--- a/configure=2Ein
++++ b/configure=2Ein

Pat=
ches should start with a couple lines stating the origin, their
upstream=
 status, and what they do=2E

Patches also need to be listed in =E2=
=80=98gnu/local=2Emk=E2=80=99 and mentioned in the
commit log=2E

=
However, I suspect this patch has no effect: since =E2=80=98autoconf=E2=80=
=99 is not an
input of the package, its =E2=80=98configure=E2=80=99 scri=
pt cannot be rebuilt to take
those changes into account=2E

Perhap=
s you can just remove it?

Could you send a second version?

Th=
anks!

Ludo=E2=80=99=2E
------VBO8B94DN398MZ1CXDYBF8CT6FDEI4--