From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EGGiFNnjdmBcvwAAgWs5BA (envelope-from ) for ; Wed, 14 Apr 2021 14:45:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id QJJ+DtnjdmBOcQAAbx9fmQ (envelope-from ) for ; Wed, 14 Apr 2021 12:45:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id AB128273B7 for ; Wed, 14 Apr 2021 14:45:12 +0200 (CEST) Received: from localhost ([::1]:49850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lWetK-0002UE-BE for larch@yhetil.org; Wed, 14 Apr 2021 08:45:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lWeWx-00018t-6C for bug-guix@gnu.org; Wed, 14 Apr 2021 08:22:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50549) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lWeWw-000828-Ds for bug-guix@gnu.org; Wed, 14 Apr 2021 08:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lWeWw-0005yJ-Af for bug-guix@gnu.org; Wed, 14 Apr 2021 08:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#36508: GDM files have incorrect owner after temporarily removing service Resent-From: Brendan Tildesley Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 14 Apr 2021 12:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36508 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 36508@debbugs.gnu.org Cc: Mark H Weaver , Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 36508-submit@debbugs.gnu.org id=B36508.161840287922894 (code B ref 36508); Wed, 14 Apr 2021 12:22:02 +0000 Received: (at 36508) by debbugs.gnu.org; 14 Apr 2021 12:21:19 +0000 Received: from localhost ([127.0.0.1]:33860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWeWE-0005xC-SE for submit@debbugs.gnu.org; Wed, 14 Apr 2021 08:21:19 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:24040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lWeWC-0005wu-MG for 36508@debbugs.gnu.org; Wed, 14 Apr 2021 08:21:18 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4FL1m6653DzQjwf; Wed, 14 Apr 2021 14:21:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h= content-transfer-encoding:content-type:content-type:mime-version :subject:subject:references:in-reply-to:message-id:from:from :date:date:received; s=mail20150812; t=1618402864; bh=us9OXY5O5p GpfHLemJ5PLTjoywNrQkvn+AAnhigvAzs=; b=VAECrUpRBWVeYUy/WTvdZ/sEZm R4kkZqXlUhHtVc+0HgfFpcA4pwn0+7qVMMKqUFdZhz7L5DOAAAe+TiojnoXuFJTv Xzy6v1Sz7Sm4LVvQG78qke11RQSSacWSAzsWQRYCt9IjCsyJ3Ngk079wRmRKqAmP q1g7X/lJVdLwoG+BXlxfmGpsHiCUc2tL1YJl1wc6ASMbJMNMZu/emrcf/7tNcJZ4 MuU5a27wPP9Kuuabw/4GqwXb3T7wYhZ8D4tzpRQPAF88btP7bROrzqC33pz8mQ4W 5myz7WjjIeuCIBSco5zb2vWPiyjp16xqXqyUcYvakhwkHSzidjz9/EBktcpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1618402869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q69mD9LGTrkxrzfmEZzwft414MS47zJTwr+PDEiit4Q=; b=fEZkH2tKz68kdsWqzjpg/f2305CvzkAlyGvpH5E9Gq8+qXO/ZhhARB8CKWtXPJHyBBJ9x4 Ii9BD6Yy8acxvonXm9jbP8+CxLUrwxws7GufuqxE5Eyw6XsqdpvnfvWv2h6XPpuF/hLQuP XvB8KlXy7zUIpKevQQm0FJDNtzpkDz8tD2kNS7EIjzTWx0jqTQOp76kob+cwItv75bpe55 icfoWhXdGWL+IIK/cfoVoBHdknOiqTLNlj+esxuklGwyUlXRIsaWLcPFLi91UgymAxg6lu KrwCLZs39ZrpB7Z7wezMy68/AQ0nH7FJh8ZbEDoBMzmPc1gFTv8cASihCmINSg== X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id F7lSshsIBeZ3; Wed, 14 Apr 2021 14:21:04 +0200 (CEST) Date: Wed, 14 Apr 2021 14:21:03 +0200 (CEST) Message-ID: <262720830.30369.1618402863721@office.mailbox.org> In-Reply-To: <875z0pgnqn.fsf@gnu.org> References: <20190705083620.lbzu7a33awbymh3d@cf0> <1576552162.14721.1618320275616@office.mailbox.org> <87czuxsya5.fsf@netris.org> <875z0pgnqn.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-MBO-SPAM-Probability: X-Rspamd-Score: -6.13 / 15.00 / 15.00 X-Rspamd-Queue-Id: BE85217CF X-Rspamd-UID: 8bef7e X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" Reply-to: Brendan Tildesley From: Brendan Tildesley via Bug reports for GNU Guix X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618404312; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=q69mD9LGTrkxrzfmEZzwft414MS47zJTwr+PDEiit4Q=; b=AHPM48lNfUz+emZlEQ/7qGBPKMaPhK6Atn6H2FkPCpnGVH+yZbm98xMS0Fir2+i01FjfA7 Ju60J7ssCqxGiodOnIn4eImoDNNXyPbBePsCAWvNAV75C3005NktzVGgl5DfxysZYOOhLl jV/noceWZUUGUilujySCV9naNft90onlYv5Dpk/kXVu9EuvnajjMX4IMqLlJTZfjsnpNe7 HABjlSuBINhWSN5bMueNKyooSvQKc7meHfqsvch+CW+ZCo4pSLSji+nEWR+vKhOWLWn+8w BAootlMHyV95suL1L9caWsdnKd5o1m262Q/YLvPODYNEv+MHzbHiN9bUfyTz2Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618404312; a=rsa-sha256; cv=none; b=R/Z+az37ltoUvhRz8NFzIZgy2oY5aKHHQBVasB7YPI7S2B5BH6khjJeVKWiLxG5pRyhj3w Bg7Q+iec5WoD1mGuU1nrlhLMlMda4B1Xk288O2v0kMhP1LVYMFfSQN5BblGDxQo+h6zjWK VdqA8OidlxeAL8DCnX8yGdUm6XyLS0nQ3vGgue6ysHYXhICoOngQsaTf4kZIpavZIk3Jwb qwcF6ZC9FLWIm0n9MJAez6qI6DjpuD/qbzMltdLWszpnTlaa+e2ZEzo0gF0el7GFJMXJPZ 884doTfe/dpnj1/HYLKiABcUgqtZiVKr7ffYW9BJHknCgzYjl+x7QvE/wkI+uA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mailbox.org header.s=mail20150812 header.b=VAECrUpR; dkim=fail ("headers rsa verify failed") header.d=mailbox.org header.s=mail20150812 header.b=fEZkH2tK; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.13 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=mailbox.org header.s=mail20150812 header.b=VAECrUpR; dkim=fail ("headers rsa verify failed") header.d=mailbox.org header.s=mail20150812 header.b=fEZkH2tK; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: AB128273B7 X-Spam-Score: -2.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: nkRou2vaCvPa > On 04/14/2021 12:32 PM Ludovic Court=C3=A8s wrote: >=20 > =20 > Hi Mark, >=20 > Mark H Weaver skribis: >=20 > > Brendan Tildesley via Bug reports for GNU Guix > > writes: > > > >> I recently encountered what is likely the same bug. The directory /var= /lib/gdm > >> had the correct permissions gdm:gdm, but all the files inside had some= thing like > >> 973:gdm > > > > The underlying problem here, which I've also experienced, is that if yo= u > > reconfigure your system with fewer users/groups, and then later add > > those users/groups back, there is no guarantee that they will be > > assigned the same UIDs and GIDs. >=20 > Yes. >=20 > The patch Brendan posted LGTM (though I=E2=80=99m surprised the directory= itself > can have the right UID/GID while files inside it don=E2=80=99t; perhaps t= his was > made possible by 2161820ebbbab62a5ce76c9101ebaec54dc61586, which chowns > the home directory unconditionally.) >=20 > Note that there are other places, in addition to GDM, where we > forcefully reset the UID/GID of the home directory (e.g., for the > =E2=80=98knot-resolver=E2=80=99 service.) >=20 > My preferred solution to this would be to unconditionally chown -R home > directories upon activation (for efficiency, it would be best if we > could do that if and only if the home directory itself has wrong > ownership). Thoughts? >=20 I'm confused. It sounds like you're suggesting to add the very IF condition= that my patch removes from %gdm-activation in order to fix the problem.