From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id Zs9gDNkeN2L/pQAAgWs5BA (envelope-from ) for ; Sun, 20 Mar 2022 13:32:25 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id SK3ACNkeN2JPjAAA9RJhRA (envelope-from ) for ; Sun, 20 Mar 2022 13:32:25 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B322838870 for ; Sun, 20 Mar 2022 13:32:24 +0100 (CET) Received: from localhost ([::1]:32922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVujP-00009t-IE for larch@yhetil.org; Sun, 20 Mar 2022 08:32:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVuj4-00008V-Jz for guix-patches@gnu.org; Sun, 20 Mar 2022 08:32:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39227) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVuj3-00043t-Ut for guix-patches@gnu.org; Sun, 20 Mar 2022 08:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVuj3-0006Ia-Sj for guix-patches@gnu.org; Sun, 20 Mar 2022 08:32:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54352] [PATCH v2] services: dnsmasq: Add more options. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Mar 2022 12:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54352 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Remco van 't Veer Cc: 54352@debbugs.gnu.org Received: via spool by 54352-submit@debbugs.gnu.org id=B54352.164777947224126 (code B ref 54352); Sun, 20 Mar 2022 12:32:01 +0000 Received: (at 54352) by debbugs.gnu.org; 20 Mar 2022 12:31:12 +0000 Received: from localhost ([127.0.0.1]:33114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuiG-0006H4-F9 for submit@debbugs.gnu.org; Sun, 20 Mar 2022 08:31:12 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:59948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVuiD-0006Gu-SW for 54352@debbugs.gnu.org; Sun, 20 Mar 2022 08:31:10 -0400 Received: from [192.168.100.254] ([188.189.229.90]) by laurent.telenet-ops.be with bizsmtp id 8cX22700G1xgCic01cX7KC; Sun, 20 Mar 2022 13:31:08 +0100 Message-ID: <25d571d30b3ea33ef2bdb7b09b28014c3f45a883.camel@telenet.be> From: Maxime Devos Date: Sun, 20 Mar 2022 13:30:57 +0100 In-Reply-To: <8735jcddav.fsf@remworks.net> References: <20220312154813.5538-1-remco@remworks.net> <20220320114405.4702-1-remco@remworks.net> <8735jcddav.fsf@remworks.net> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-UZMGllmheTEVSW189CpU" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647779468; bh=8X/R4wR/TApiJr/Au8KEHQT2vhshySvVHvbYicEKR1Q=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=h5Maqn8gsOAN3sbmoUMrzPtfGD+44owLxWKQhVEzsi+K7Im3eu+XLctZKi+U8Zsdk uTq0EcFmQrustByBviJze60FPOmLZcyih1NvIuQWCeZlfZRDjnB3zmSm0ZOLjpwUoX B4SgL7HfYnBQNFUTnlI8RdUr1rA5Tv56haOEFxm3zK9jZFdON8mOUTvvU06Glakz5+ /USnFQ5UbPPru82Ria56eijuwFpfI30gnmFpn4T+BkQkgpbWw3+Z57D+Xpc/00UD2T mQqREjl5eQ37zuviZiGfbQvLskYSb8lLm57wVszIT3RylOLVfldXnPji8iezc7MMPp uKB5RdnorPezA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647779544; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=8X/R4wR/TApiJr/Au8KEHQT2vhshySvVHvbYicEKR1Q=; b=BQnNWyCUw9Cx3eEhQdEBjRBwlpxnGXJNjqU6kFPVWZOkTEveyh+ujnMOOVpl6n7YNj49VM zELEaojEqIa9mJWq9R6HPcrbGhGQa7kQ+kk6EbjbZq4SVcHRMi53zeGQzxyF2icN6Wzu/x dy4h0yjuVEXBzRJ5rmmaVwkJJR0nlWYvWsmokysJd6p5Qz8gCled5D5/Kau5RdGuI4UPn1 qB01n9OAW8QQBLS1jUQuoc4q2ajiwvb83DL8dUz8oc5x2LUNJ/SquoaZueidsp7EQ9WDdo oMehyqkQjwLZbh26rYmVJMPpG/JdS9LaDH37XxxjmaOyjlLQrQ0maX52OVqYvA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647779544; a=rsa-sha256; cv=none; b=uKs5ePixOSK6qmN3cXvqQAqCRqPDZchRO8V/IiIhRfgA66RnYq7gQm02aCPg3BKboFydgu c+qM1cdBmDi4lv/krVV8sZa7z/P9fO1JJjXJ3YTLv831Q/RtISVJ4oaEkPtoHnpXmFCaUn 79r5ocLsyJ/U1ZEXg5eKviu+5nkN2nhYJyM0/1pQOUCqGPEVKaQbQxOjmUgPo9asBiMOD4 AFtFIEYSczPKMKIrDckCPN4M7xlI01P6lCGjrTQ5LQDXh/oKUiacZnYQzYp4YEYLGEYS5S g0zlLoTFLW3NNFCrUxpy9iyGc6EDA8Qn7dMrNmHm32asLGXi7VwIQS++jUhlhw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=h5Maqn8g; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.77 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=h5Maqn8g; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B322838870 X-Spam-Score: 3.77 X-Migadu-Scanner: scn1.migadu.com X-TUID: x1EhoUhTqYp5 --=-UZMGllmheTEVSW189CpU Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Remco van 't Veer schreef op zo 20-03-2022 om 13:22 [+0100]: > 2022/03/20 12:56, Maxime Devos: >=20 > > It would be nice to verify that these are, in fact, booleans, > > using field sanitizers.=C2=A0 See, e.g., ensure-setuid-program-list > > in (gnu system). >=20 > I agree but the same could be said about the other fields and types in > this record, and those of other services.=C2=A0 In the long-term, it would be nice to eventually add error checking to other services and fields as well. In the short-term, I would avoid making error handling worse. > In this case, the names of the fields ending with "?" should be > enough for somebody to realise this is a boolean, IMHO.=C2=A0 > The";boolean" comments I've added are just me trying to blend in. It's technically sufficient, but it does not make for nice error messages, see the thread at . In this particular case, there won't be an error message *at all*, due to how (if forward-private-reverse-lookup? ... ...) works. For example, consider the case where someone new to Guile and Guix sees =E2=80=98boolean=E2=80=99 in the documentation and then tries using "true" = and "false" (the strings): (dnsmasq-configuration (forward-private-reverse-lookup? "false")) Currently, this will silently do the wrong thing. Greetings, Maxime. --=-UZMGllmheTEVSW189CpU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYjcegRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rEZAP0cD2uSdoXB0vp01y9Z96ehr3wX uGcLbrOfwWm2L4O5gAD/duaPheEZvrqss7AT9cwfGFqYt2ae0JMgDTxSNNFSBQ0= =1+B2 -----END PGP SIGNATURE----- --=-UZMGllmheTEVSW189CpU--