From: Raghav Gururajan <raghavgururajan@disroot.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org
Subject: Re: [FONTS]: Media Type Specification Changed.
Date: Mon, 11 May 2020 00:11:02 -0400 [thread overview]
Message-ID: <259afe46-ebd1-bf95-3893-6120ef50097a@disroot.org> (raw)
In-Reply-To: <87d07boe60.fsf@nckx>
[-- Attachment #1.1.1: Type: text/plain, Size: 1472 bytes --]
Hi Tobias!
> The bad things. All of them. In order.
Oh! How are you doing now? Let me know if you need anything. I can try
and help in any way plausible. :-)
> You did fine, only renaming ‘truetype’ -> ‘ttf’ should have been
> separate. If it had been, I don't think it would have been merged.
That change has been discussed during review and was only merged after I
gave the fact of about fontconfig. :-)
> Also omitting it from the change log feels... sneaky, while I'm sure
> that wasn't your intention.
I understand. I should have mentioned in the log. But it was not sneaky.
As mentioned above, it was discussed during review. ;-)
But yeah, I should add that to my workflow of making comments/logs.
> Anyway: since ‘share/fonts/ttf’ makes font-gnu-freefont inconsistent
> with our other fonts[0] for little reason I'd like to revert it back to
> ‘truetype’ & change ‘share/fonts/otf’ to ‘opentype’ as well. What do
> you think?
>
> (Not sure what to do with ‘woff’ so I won't touch it.)
Agreed! I do not like inconsistencies either. Please find the patch
attached with this email.
>> But anyway, before merging I well-tested the patch. It does not affect
>> anything.
>
> I know :-) Fontconfig doesn't care about the subdirectory names, it
> just scans them all. The names are for humans. All the more reason not
> to abbreviate them IMO.
Makes sense.
Regards,
RG.
[-- Attachment #1.1.2: 0001-gnu-font-gnu-freefont-Correct-fonts-sub-directory-na.patch --]
[-- Type: text/x-patch, Size: 1788 bytes --]
From 6f709f5dcdb452df365a2f6927c761fc386c0b0e Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sun, 10 May 2020 23:57:23 -0400
Subject: [PATCH] gnu: font-gnu-freefont: Correct fonts' sub-directory names.
* gnu/packages/fonts.scm (font-gnu-freefont): Fix /share/fonts/*.
[arguments]<#:phases>: Change sub-dir strings from ttf, otf and woff;
to truetype, opentype and webopen; respectively.
---
gnu/packages/fonts.scm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
index 6e9b080299..8924c377c6 100644
--- a/gnu/packages/fonts.scm
+++ b/gnu/packages/fonts.scm
@@ -255,11 +255,11 @@ The Lato 2.010 family supports more than 100 Latin-based languages, over
(let ((doc-dir (string-append %output "/share/doc/"
,name "-" ,version))
(ttf-font-dir (string-append %output
- "/share/fonts/ttf"))
+ "/share/fonts/truetype"))
(otf-font-dir (string-append %output
- "/share/fonts/otf"))
+ "/share/fonts/opentype"))
(woff-font-dir (string-append %output
- "/share/fonts/woff")))
+ "/share/fonts/webopen")))
(mkdir-p doc-dir)
(substitute* "Makefile"
(("\\$\\(TMPDIR\\)") doc-dir)
--
2.26.2
[-- Attachment #1.1.3: 0xAE6EF3046D6F7B57.asc --]
[-- Type: application/pgp-keys, Size: 2877 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-05-11 4:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 14:41 [FONTS]: Media Type Specification Changed Raghav Gururajan
2020-05-10 15:55 ` Tobias Geerinckx-Rice
2020-05-10 16:13 ` Raghav Gururajan
2020-05-10 18:09 ` Tobias Geerinckx-Rice
2020-05-11 4:11 ` Raghav Gururajan [this message]
2020-05-13 16:13 ` Tobias Geerinckx-Rice
2020-05-13 19:04 ` Raghav Gururajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=259afe46-ebd1-bf95-3893-6120ef50097a@disroot.org \
--to=raghavgururajan@disroot.org \
--cc=guix-devel@gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.