From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AFcpFv9LEmIXmgAAgWs5BA (envelope-from ) for ; Sun, 20 Feb 2022 15:11:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mGHGEv9LEmKqYQEAauVa8A (envelope-from ) for ; Sun, 20 Feb 2022 15:11:11 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4C11A3587B for ; Sun, 20 Feb 2022 15:11:10 +0100 (CET) Received: from localhost ([::1]:53966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLmvd-0000cv-Ho for larch@yhetil.org; Sun, 20 Feb 2022 09:11:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLmvX-0000bA-Dn for guix-patches@gnu.org; Sun, 20 Feb 2022 09:11:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37576) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nLmvX-0001g4-2x for guix-patches@gnu.org; Sun, 20 Feb 2022 09:11:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nLmvW-0002m8-VE for guix-patches@gnu.org; Sun, 20 Feb 2022 09:11:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53878] [PATCH v4 15/15] gnu: racket: Update to 8.4. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Feb 2022 14:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53878 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53878@debbugs.gnu.org, Liliana Marie Prikler , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Liliana Marie Prikler Cc: Attila Lendvai , zimoun , Malte Gerdes , raingloom Received: via spool by 53878-submit@debbugs.gnu.org id=B53878.164536621110583 (code B ref 53878); Sun, 20 Feb 2022 14:11:02 +0000 Received: (at 53878) by debbugs.gnu.org; 20 Feb 2022 14:10:11 +0000 Received: from localhost ([127.0.0.1]:59701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLmuV-0002jw-To for submit@debbugs.gnu.org; Sun, 20 Feb 2022 09:10:10 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:45479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nLmuO-0002jP-LK for 53878@debbugs.gnu.org; Sun, 20 Feb 2022 09:09:53 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 9CECE580338; Sun, 20 Feb 2022 09:09:47 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 20 Feb 2022 09:09:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= philipmcgrath.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=HWkWDCMm1m4mtW BbrYPqHKRwutKhPTYSZN/U3LDQo0U=; b=nKqofT+EbZXsFpf+0i8ZExJbr/dSo3 IM4GIB0G9jSNBsRF6f/oRPOah6U07tzOq80VovHVnfQ8lLOotYoz8PNq501/foGN m52j0Q3XmkR7PWd1dcuiuUJuya+zNPMlXzFEJW8EaXyyJjDdItoPQbul3PJdXXSh xQi0XmZr8WcmjZzy3iqtE6gL26XhfKKPhyaa0xH9eOtlgeWRljy9JlKD1k7dPbwX HRuhkgJ1LoSmrrKamYSoVupKHeC1RnGPXlEkazK2oMzQwFI5Dk4l+HFs+VUr2kHp SMhAVt6RrlUyYVbcaP3+o4uvUzOaMdKJXJyZxTGFAnopR/J26ogODhzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=HWkWDCMm1m4mtWBbr YPqHKRwutKhPTYSZN/U3LDQo0U=; b=IhKmSr/aTeP0pHtitG0O/YiStHvs/lQ9a rpWvp+TFMskS30Lw8cYbx9Gf7qIBdK+R/RRAx15SP/Vjpv8oJ8XQdKR5ei9XL9yz fyAI/iCDEdPpfBvWeWWnFqubJaqataFhiXQ0PJDz+AU6bdDNKf94pkXLvL8FYd3Z r5oSMwJxaDOPyU6fb6THLyvRnmUNnzsGsjkzQ8oqKT9hbGtFBOIzcG6ZW/sXyUUw Xkb5yKNWeBXvQPGByr/1ivYl1U+EBJhMsG1Vq+8Sp0t8m1DRMYX9dbEN8hvH20FS 4KueLQqeLtug2tmg6GKWj8YnOvkyo8LTpcq0BwWGXIti4/hUXF2Yg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeeggdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfgggtsehgtderredttdejnecuhfhrohhmpefrhhhilhhiphcu ofgtifhrrghthhcuoehphhhilhhiphesphhhihhlihhpmhgtghhrrghthhdrtghomheqne cuggftrfgrthhtvghrnhepleejffegjeetieeuleelgfekuedtgfdvjedtkeefueduudfh geeukeevieeuiedunecuffhomhgrihhnpehgnhhurdhorhhgpdhrrggtkhgvthdqlhgrnh hgrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepphhhihhlihhpsehphhhilhhiphhmtghgrhgrthhhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Feb 2022 09:09:46 -0500 (EST) From: Philip McGrath Date: Sun, 20 Feb 2022 09:09:45 -0500 Message-ID: <2466017.hpQdrOUuIC@bastet> In-Reply-To: <39bfc6f557bf2ef03ce22067d5c73adcbb67b167.camel@gmail.com> References: <20220208151316.1897345-1-philip@philipmcgrath.com> <20220220060610.178131-16-philip@philipmcgrath.com> <39bfc6f557bf2ef03ce22067d5c73adcbb67b167.camel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2066579.fovGzxi7Es"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645366271; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=HWkWDCMm1m4mtWBbrYPqHKRwutKhPTYSZN/U3LDQo0U=; b=qzFnvVQ7IGYUBtWra7bEcGEnTJB5HOdQzaJiGuS1pBMtiULwR2ZplrfPR9hpTWkcH96bsr uGd7c2b7ovEjni/9x70ngWW3yP3Yy6m+bqVja4Z3uKUA/Tv2EXxFCxvrXdHKZAYRiMIvXy lR3nMWHpbAbP0P4ABeqxsebF9mJYbYbHOBHdb4cUDMfGVYsoLbD86Yce9lSewkYOmM9UrH puUgYB7dJGYoSbuf7nZZOa/wA4vbXYRJdaOa+FblFN9noxm5votbrZ4Y8VcIWh1W3dcVqz UqpPaG3kc99kFnJfum677Ryh7KFP1jhU6/1MU8h8cXzXBoa40sSHj2j/9bRdvQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645366271; a=rsa-sha256; cv=none; b=Ui5uYJLq42aKE8AgAzWt8VolLMArBQY9RKPAJPTzXiGC9Csuj8Uym0EB/kI3dPfh6/tYQQ PfwZ3qIFk8dbLpMR1iNUDl9NHrLlCGvdU/ShF4bUl+0i5cc96sxhI++fLFLaP3ZsWCJdRq vpY1VVN5tz1Y3rSxGgXTaz0CxqkRvrQI2V9HtRDWuyO1uXXLJKax5KoNtzNpJvwnBMVy86 6BhWANDQbCTIRNYNe2UVim10wv8p/LUu6Z6O7tRqeKlIUQnBtw2BSjZTS2CMqLowfxau5T yj9giX1x5ymRaJH1VERxO8iJedjJ1nzWFF2er/PpCMY9yaiM+S18caW/ausYWQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm1 header.b=nKqofT+E; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="IhKmSr/a"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.93 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm1 header.b=nKqofT+E; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="IhKmSr/a"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 4C11A3587B X-Spam-Score: -3.93 X-Migadu-Scanner: scn0.migadu.com X-TUID: UqUh/SUEKGvb --nextPart2066579.fovGzxi7Es Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8"; protected-headers="v1" From: Philip McGrath To: 53878@debbugs.gnu.org, Liliana Marie Prikler , Ludovic =?ISO-8859-1?Q?Court=E8s?= , Liliana Marie Prikler Cc: Attila Lendvai , Malte Gerdes , raingloom , zimoun Subject: Re: [PATCH v4 15/15] gnu: racket: Update to 8.4. Date: Sun, 20 Feb 2022 09:09:45 -0500 Message-ID: <2466017.hpQdrOUuIC@bastet> In-Reply-To: <39bfc6f557bf2ef03ce22067d5c73adcbb67b167.camel@gmail.com> References: <20220208151316.1897345-1-philip@philipmcgrath.com> <20220220060610.178131-16-philip@philipmcgrath.com> <39bfc6f557bf2ef03ce22067d5c73adcbb67b167.camel@gmail.com> On Sunday, February 20, 2022 5:16:04 AM EST Liliana Marie Prikler wrote: > > #:use-module (gnu packages xorg) > > #:use-module ((guix licenses) > > #:prefix license:) >=20 > Small note, #:prefix license: should be on the same line as #:use- > module. >=20 Ok. > > -(define %racket-version "8.4") > > +(define %racket-version "8.4") ; MUST match "racket.scm" > > +;; The definition of %racket-version is duplicated to avoid an > > import cycle: > > +;; see . > > (define %chez-scheme-for-racket-version "9.5.7.3") > > [...] > > +(define %racket-version "8.4") ; MUST match "chez-and-racket- > > bootstrap.scm" > > +;; The definition of %racket-version is duplicated to avoid an > > import cycle: > > +;; see . > > +(define %racket-commit > > + (string-append "v" %racket-version)) >=20 > That works, but it's not really nice. I did send my mail w.r.t. making > the bootstrap packages procedures that take racket-version and origin > as arguments before reading this mail, but I think my comment still > applies mostly. WDYT? >=20 As I said, I think that would cause an import cycle. This seems like a very= =20 subtle and confusing issue! I haven't heard anyone but Ludo=E2=80=99 expres= s much=20 confidence in their understanding of how this works=E2=80=94certainly I don= 't feel=20 much! > > +(define (extract-package-source origin spec) > > + "Extract the source for a Racket package specified by SPEC from > > ORIGIN into > > +a new file-like object. In the resulting file-like object, the > > package source > > +will be in the directory \"/share/racket/pkgs/NAME/\", where NAME is > > the Racket > > +name for the package. > > + > > +SPEC is a list of the form: > > + > > + (NAME PATH) > > + > > +where PATH is the path to the package source relative to ORIGIN--- > > possibly > > +`\".\"`. As a special case, SPEC may also be given a string, which > > is > > +equivalent to: > > + > > + (NAME NAME) > > + >=20 > > +Examples: > Would it make sense to use this procedure for our bootstrap packages > already? (In particular for bootfiles or extracting chez-scheme from > the racket source). >=20 Well, for one thing, trying to use this package in "chez-and-racket- bootstrap.scm" seems like it could get us into trouble with import cycles=20 again. I think it will be less painful if we can have at least "chez-and- racket-bootstrap.scm", "chez.scm", and "racket.scm" form a DAG. Also, this function was really intended to handle the quite common `?path=3D=E2=80=B9path=E2=80=BA` case for Racket Git "package sources"[1]. = Eventually, it should=20 be part of a `racket-build-system`. >=20 > Regarding the big racket package, the recipe currently looks a little > nicer in that it no longer overrides `build', but I think we could > still do a union-build with #:symlink copy-recursively if the full > racket is just racket plus a bunch of packages on top. This would have > the benefit that we could declare each of them as a package. Not sure > if this is something we ought to address here or in a separate patch > set, though. Well, I certainly do want to declare each of them as a package! But I don't= =20 know what the benefit would be for doing so before its possible for a Guix = user=20 to usefully, say, install one. Maybe you know this, but installing a Racket package isn't just a matter of= =20 putting a directory in the right place and setting a search path. Most=20 obviously, it has to be compiled, and it would be most useful to explicitly= =20 generate "built packages"[2] separately from installing them into a layer.= =20 Installation into a layer potentially involves generating collection links= =20 files, indexing documentation cross-reference information, moving man pages= or=20 other kinds of files, creating launchers like the `drracket` command, and=20 potentially various other steps: indeed, collections (not just packages) ca= n=20 specify arbitrary functions to be invoked by `raco setup` at pre-install,=20 install, or post-install time. Creating a "config-tethered" layer=E2=80=94t= he kind we'd=20 want to install into a Guix profile, as opposed to a sparse intermediate la= yer=E2=80=94 also creates new `racket` and other executables in the layer's "bin" direct= ory=20 that exec the `racket` from the VM layer while propagating information abou= t=20 the layers that have been installed. Anyway, the packaging for racket@8.4 should be less of a hack than before=20 (which was better than when we used to duplicate racket-minimal, VM and all= ),=20 but this is all still fundamentally a hack, and I'd rather spend my effort= =20 trying to do the right thing, rather than overly fine-tuning the details of= the=20 temporary workarounds. =2DPhilip [1]: https://docs.racket-lang.org/pkg/ Package_Concepts.html#%28part._concept~3asource%29 [2]: https://docs.racket-lang.org/pkg/strip.html --nextPart2066579.fovGzxi7Es Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE9GWrrNY3rqwUFVXPygNjjfo/HHoFAmISS6kACgkQygNjjfo/ HHrYzRAAlL83d8yxYruFEbC8zVBfevket1To9GrpM4WstkluAbxpIV9rEDrFNFBF QoYPfOpHl9PeX4ICP9rUY6EFQFMhD3Nld9XXQMu7G4PuEybt93PBRtza3SmqB8aX dF/oyNnxt9fc5fkwxoHwtlSO16DxpzluVjQ40SoUtpJbzh250vf1j6oN0wVmwx4k /mbjWjjZU2rludNJKET0YtT9FVzVcYZ8vJ29hiKmNLcmDk25xNdXIEcyq0TJWzTf nbnMGhQOM1z32Uu/FF+8vSY51Ruzp35kZ04sY3SBL8mfd1jfvXU5xUso8mcMOmPu oHoDnlyL1UE5eTemwYhIcDkbS0iWQRTPT+MVz88HnRw39nyMOGLg1H3u3GAOFJzq BYtkrieWATiY/q09D1EkNU9w7ar3adSBkV1bQ5AQTkWXK+isHO7jdpnKV36+9X4p TRv1h2PolyqVA5DZ0VLlrNBZuhhUm0hdNAI+INnFwGBDCuphxtLSwgksM/zMB6lG xjLaRW2PxnmTNt0uiUGrf7gK2cVu8XZFN3eEqVlBA5eGENEfpf+bIepljVbb8orO wsEWzNvePCuN/6gcREy2V0IqyWMOih2cjto/SdiR8FkA2vIxdcsCblKCyVs443UG 8Se71ILBostG3vHrO6Pz8JG62Ay6P/g6Iekx6v4FuNoUfeH2bq0= =JlQ7 -----END PGP SIGNATURE----- --nextPart2066579.fovGzxi7Es--