From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yA+bN+e7jWFl4wAAgWs5BA (envelope-from ) for ; Fri, 12 Nov 2021 01:57:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id cAVIM+e7jWHkAwAAB5/wlQ (envelope-from ) for ; Fri, 12 Nov 2021 00:57:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3D53A25741 for ; Fri, 12 Nov 2021 01:57:11 +0100 (CET) Received: from localhost ([::1]:42468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlKsP-0005W8-QJ for larch@yhetil.org; Thu, 11 Nov 2021 19:57:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlKsI-0005Vz-Gk for guix-patches@gnu.org; Thu, 11 Nov 2021 19:57:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59326) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlKsI-0005Bh-8X for guix-patches@gnu.org; Thu, 11 Nov 2021 19:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlKsI-0001hH-7o for guix-patches@gnu.org; Thu, 11 Nov 2021 19:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#49672] [PATCH 0/9] Target check fixes and cleanups Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 12 Nov 2021 00:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49672 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 49672@debbugs.gnu.org Received: via spool by 49672-submit@debbugs.gnu.org id=B49672.16366785896482 (code B ref 49672); Fri, 12 Nov 2021 00:57:02 +0000 Received: (at 49672) by debbugs.gnu.org; 12 Nov 2021 00:56:29 +0000 Received: from localhost ([127.0.0.1]:42639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlKrl-0001gU-4i for submit@debbugs.gnu.org; Thu, 11 Nov 2021 19:56:29 -0500 Received: from mx.kolabnow.com ([212.103.80.153]:52264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlKrj-0001gG-OT for 49672@debbugs.gnu.org; Thu, 11 Nov 2021 19:56:28 -0500 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 6127940D66; Fri, 12 Nov 2021 01:56:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:date:subject:subject :from:from:received:received:received; s=dkim20160331; t= 1636678580; x=1638492981; bh=cJxKj3QT171JqnE0qVrRFtKlngsCKNefook cOJF0HaA=; b=QYR+t1lMAi5Qqq0CH+PFKGKMUKyDSAlpt8X7E1MC5Aee4WgArMB 3nRAq4ufnqH4fN46x+CE5yhMe+yhLA+GHdYlAp6vRFd6z0tIz3DOkdUm2epx5Wm3 tTYX5XVkLr+fh9SKEbbAwERZqcVEIcRp+gQfauTy/c2wiVW828c4pi2Mekk7NF92 W5bjHw/pzsJoCu6TMZudnu9ZbuZjLcbiEz28JPQFOxdF0RJi9tdKRUvj7lkcAmLr 4f7VmIDD+qJ5twL2W8HEopu+5nnCKuHRhaBmrFNsymrTu7gGOEUTUvWd+MclcUgx OojKl4CyGH+Dsuk9fAmPxJER81bF+RCdNIfqT99fIG/2wrft2U7+DYo5knEPdF/q Eo8agTYdxwb8auZYL8AXGwUJVYR6oW+yx2g+/yyiGjCOFQFMDCl9ZHPihO4UZuIB KXTF+RLAHeDMqoRb1agvDwfstcY8Op6SbPEdCLVfvuSz24T5Pb8IJ0Cvoz/QFpgP sVgZgKERyLNmw3vP5QcjHqNbZTVop7raBg08BWhoVGmu2+QOtXbz3M7OUS2MSsVr 0ua3aGL3yAvUt2HGz5gMKqJgQKGZoWufQdhKX4V8Z3ST4eJuiLjrMv/dezhQDAvc V4NyGKedUFKwZc+LqNsQ05sUb9wS8333DYUTrAFU/0W63x4jthTXOvVo= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out003.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QdkLQvTiHHLu; Fri, 12 Nov 2021 01:56:20 +0100 (CET) Received: from int-mx001.mykolab.com (unknown [10.9.13.1]) by mx.kolabnow.com (Postfix) with ESMTPS id B76FD403E1; Fri, 12 Nov 2021 01:56:20 +0100 (CET) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx001.mykolab.com (Postfix) with ESMTPS id D8A99881; Fri, 12 Nov 2021 01:56:19 +0100 (CET) Date: Thu, 11 Nov 2021 21:56:14 -0300 Message-ID: <2451084.S0jLYT9aXA@popigai> In-Reply-To: References: <20210721004615.631777-1-bauermann@kolabnow.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Thiago Jung Bauermann X-ACL-Warn: , Thiago Jung Bauermann via Guix-patches From: Thiago Jung Bauermann via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636678631; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cJxKj3QT171JqnE0qVrRFtKlngsCKNefookcOJF0HaA=; b=b4mTPlSxFEYGwLwLDZVCjHwIKEO/wk583rQfyj+qIAhRnZe7m1+DgJIBgwhR5uym5P8NK7 n8oMugpjJuychEg+3pWZHQuOhjOt57pcXYT6cAbJ5lpTzWNMrOEiY2RJ1PGzNSrnY4SxWm BtfJgYT6SsCyZ6UuM6StlfvD6ICQgnGnC3hjehjl3b+uJvWvCvcO+5CJ0Zo5tr3lo4J6XW qg/3RChhVaBV+eciklHPcf0Vxr+dJ9KMgT4l4dOsUcG761nOF7TpWPYyECxZwIcisMQswH osxXrzqGsrZwHq5tH7i34xZKBTLW5XFNQx8VR+qB5R5LiT5tdxr7c4ZYkv0mmQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636678631; a=rsa-sha256; cv=none; b=bJK2D1gUSMKa17tAm+mmezI4IJz7JEVc+v0lGC7P3wB8fRuYpRP2Xo5b9Ur6intcEtuRmW HRkQOTql5FqhXwt9p5dEdj7jSAr1VhCZgcc7d4mN2hBKLN9Nbv+05eBz8KSUjbPBLhHQfz Si6MbIBnwwmmbVBPLxw/864+szJDQ9eWUugnGa83XjOBoNqiyCK4ICopSlcFQPB8uv0aJ9 vda2PtBcz0pY1OmRvGBnGVam0N9FCv3kpogDiUcB9C79bH6Iay4N6beTTCjIjrajzhl9OF Twv4aVjliIYZHUxMMInw/FwFpnpmT4BaqKUow5Ua9L2Omo3rGwn8DwE824YlIQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=QYR+t1lM; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=QYR+t1lM; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 3D53A25741 X-Spam-Score: -2.83 X-Migadu-Scanner: scn1.migadu.com X-TUID: 3gEYassjwEKf Hello Maxime, Em domingo, 7 de novembro de 2021, =C3=A0s 08:23:37 -03, Maxime Devos escre= veu: > I looked over the patch series, and almost all seems reasonable to me. Thank you for reviewing the patches! I will work on a second version=20 addressing your comments. > though I would split patch 7/9 into a patch defining > current-target-gnu-triplet and into a patch using current-target-gnu- > triplet, Ok, I will do this. > and possibly a rebase might be neccesary. I will do this as well. > Warning: I only looked at the patches, I didn't apply them for testing. I don=E2=80=99t recall how thoroughly I tested these patches. I=E2=80=99ll = try to do more=20 extensive testing on v2. > I don't think the following change is necessary though: >=20 > - ,@(if (string-match "^x86_64-linux" > - (or (%current-target-system) > - (%current-system))) > + ,@(if (string-match "^x86_64-linux" (current-target-nix- > system)) >=20 > because the regex ^x86_64-linux would match both the nix system and GNU > triplet > IIUC. Maybe in the way Guix uses GNU triplets the regex would match (I don=E2=80= =99t=20 actually know) but in theory at least it wouldn=E2=80=99t, because =E2=80= =9Cx86_64-linux=E2=80=9D=20 isn=E2=80=99t a complete GNU triplet: it=E2=80=99s missing the vendor field= =2E A complete=20 triplet would be =E2=80=9Cx86_64-unknown-linux-gnu=E2=80=9D, or =E2=80=9Cx8= 6_64-pc-linux-gnu=E2=80=9D. There=E2=80=99s a bit more information here: https://wiki.osdev.org/Target_= Triplet This is actually one of the main reasons why I decided to clean up the=20 handling of Nix system identifiers and GNU triplet identifiers. =2D-=20 Thanks, Thiago