From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id SLd2G1M4RmfkCwAAqHPOHw:P1 (envelope-from ) for ; Tue, 26 Nov 2024 21:06:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id SLd2G1M4RmfkCwAAqHPOHw (envelope-from ) for ; Tue, 26 Nov 2024 22:06:27 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=qMajvDBS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1732655187; a=rsa-sha256; cv=none; b=U4x/42wLfxNvSWz5Gvx6y3NvugV4dLdTFAoxBWL0s7fT+g5eUyu9BFJXeMmmSE+pp+YpVy pPUIuiS2k6nbUBj49rbb5tAAUuWed5vVaPT4CcrWp9CMzW4q7nhEnvSBzIWFmSGP9sUFLK xYpU+/79UQ9MvEL0qBwcoNHhsVkCFbmmtOcMsIGYaM7BMiDp1gyvpMu3hsqD0lCLUPgzZZ GeuezdT10DNmuZsEDuhLbmfw5B5nPT42JUu9QtaRP6GtkszE3v2Aa8Byby3qjf2cfdQVSR Rbs4YY6qiQy0/WWFuVdfS+7NuhWmnWyGZmTrSFGFG0ZxF5z2KbU846b2WPrb6Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=qMajvDBS; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1732655187; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=hFtSlnmTvwDUpgd31cge1kM9ZlCrPjLV9VNCFo6h3Og=; b=p1AZhwf6EcZ6cbUyPci9Curhd4lxhYVD5UTvgE6FYY0I9jVw1GwBq3AoaovoOtEU2kj8Dc zKVbKny6yx9ChUUAUtadx9/5ZZ7wSsxKC+DBIB3mR9nflJJ2F+QU+twjwGaitnRS61ibo7 eOqfBa/fhCXNJNVzCzAjfzkcqHHMA8W/ql0sdAsrinR9Ty1qb/KwtaeR2yO1hLp+9W5r+U y4gvgwxsabYHsogn2DYVjbqM99OzHHjIwYrB4iR+Eygfu3bArhpILpjZlKBc6XQwjM5kol 31phzfYzBgu4ebnIDfNUmrNfdvUD6M7SSHwb0wPvaG42fb+6EXCKdXHoOPe7ng== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5F1FC5DC6F for ; Tue, 26 Nov 2024 22:06:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tG2l3-00076P-EY; Tue, 26 Nov 2024 16:06:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tG2l0-000761-OC for guix-patches@gnu.org; Tue, 26 Nov 2024 16:06:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tG2l0-0006aP-G2 for guix-patches@gnu.org; Tue, 26 Nov 2024 16:06:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:MIME-Version:References:From:Date:To:Subject; bh=hFtSlnmTvwDUpgd31cge1kM9ZlCrPjLV9VNCFo6h3Og=; b=qMajvDBSguw91s0Lw4nqU+3GsHupkLTnX+VQrkvJujhMcDb29QTuJ4LGA0UkNB1Sczv1DL9k+Aa7c74HschGEEo0W404fDLroetj7Mvyr8VfTisfs1bjFV1E9l0VydbmkCXGA3/mpIU86OI5taURjstI0VOH5KqyOCogrhXhEmVBXLm8a0J96Rt8SywhiaE9H42rv+L1CtZ8d0g2e1qHBYExsUx3NLk/7XKy4guPmpEI+wcgYc5y5Eimi+jClnnORR4hr+IVMAqpJHblZsSrWG4cMwhMuzVWa2IeMmLFiM0BsKN+knvjSTVVsBfEY+51DSCN4f/u5a8ePYHPEv9EHQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tG2l0-0000KX-5K for guix-patches@gnu.org; Tue, 26 Nov 2024 16:06:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69593] Add FluidPlug Resent-From: Gabriel Wicki Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 26 Nov 2024 21:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69593 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: paul Cc: 69593@debbugs.gnu.org Received: via spool by 69593-submit@debbugs.gnu.org id=B69593.1732655107965 (code B ref 69593); Tue, 26 Nov 2024 21:06:02 +0000 Received: (at 69593) by debbugs.gnu.org; 26 Nov 2024 21:05:07 +0000 Received: from localhost ([127.0.0.1]:53164 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG2k6-0000FK-HI for submit@debbugs.gnu.org; Tue, 26 Nov 2024 16:05:06 -0500 Received: from cotopaxi.ee.ethz.ch ([129.132.148.196]:53143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tG2k3-0000CB-Pw for 69593@debbugs.gnu.org; Tue, 26 Nov 2024 16:05:04 -0500 Received: from localhost (antispam.ee.ethz.ch [129.132.2.16]) by cotopaxi.ee.ethz.ch (Postfix) with ESMTP id 956912028A; Tue, 26 Nov 2024 22:04:56 +0100 (CET) X-Virus-Scanned: by amavisd at antispam.ee.ethz.ch Received: from cotopaxi.ee.ethz.ch ([129.132.148.196]) by localhost (antispam.ee.ethz.ch [129.132.2.16]) (amavisd-new, port 10028) with ESMTP id GB1OLLpwFJJ7; Tue, 26 Nov 2024 22:04:55 +0100 (CET) Received: from blackbox (212-51-128-25.fiber7.init7.net [212.51.128.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by cotopaxi.ee.ethz.ch (Postfix) with ESMTPSA; Tue, 26 Nov 2024 22:04:55 +0100 (CET) Date: Tue, 26 Nov 2024 22:04:52 +0100 From: Gabriel Wicki Message-ID: <23xkrbku5rvjfi4hyus5u63374nw43rmwfutgs6acfpnjg2ybs@oaee42d6eaqx> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 5F1FC5DC6F X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -9.13 X-Spam-Score: -9.13 X-TUID: 7gI9osLEYgRC Hi Giacomo! First of all, thanks for this amazing patch and sorry for the long delay. A few assorted comments to your commit messages: - fluidplug-plugin->package is a function, not a variable. - you can sum the list of variables in the commit message like so: (fluidplug-airfont320-lv2, fluidplug-avl-drumkits-perc-lv2, fluidplug-black-pearl-4a-lv2, ...): New variables. To the package definitions: great job! I like how you simplified the definitions and create them programmatically! Really cool! A couple of comments I do have, though: - I personally wouldn't mix #:exports and define-public in the same file - not sure whether there's some sort of Guix (or Guile)-wide consensus on the issue. - You might want to omit the "-fluidplug-plugin" part in each of the plugin variable names. You do not export those names so I think you can save some of these bytes (: - Did you consider cross compilation? I've tried some rather naively, but failed. Also building for aarch64 (natively) failed. Is this package not supposed to work on other architectures except amd64? If that is the case, please specify it - Changing env var CC= should happen within the #:make-flags block instead of its own build phase. And it shouldn't hard-code "gcc" but rather #$(cc-for-target) to allow for cross-compilation. - I think lv2 should be in `inputs', not in `native-inputs' (again, considering cross-compilation) of the fluidplug-lv2 package. Since I can not commit merging still needs some work by someone else. But except for the lack of cross-compilation (and foreign native compilation) I do not see any show-stoppers. Have a nice week! gabber