[bug#29758] [PATCH] gnu: mutter: Add xorg-xserver-xwayland input. (GNOME on Wayland)

[bug#29758] [PATCH] gnu: mutter: Add xorg-xserver-xwayland input. (GNOME on Wayland)

[Rutger Helling]

[-- Attachment #1.1: Type: text/plain, Size: 148 bytes --]

Hey Guix, 

This patch adds xorg-server-xwayland support to mutter.
With this patch I'm able to launch a GNOME on Wayland session, on SDDM
at least.

[-- Attachment #1.2: Type: text/html, Size: 346 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-mutter-Add-xorg-xserver-xwayland.patch --]
[-- Type: text/x-diff; name=0001-gnu-mutter-Add-xorg-xserver-xwayland.patch, Size: 1752 bytes --]

From 514c3aa846a7b4828fd190781d25d726a2938524 Mon Sep 17 00:00:00 2001
From: Rutger Helling <rhelling@mykolab.com>
Date: Sun, 17 Dec 2017 21:37:11 +0100
Subject: [PATCH] gnu: mutter: Add xorg-xserver-xwayland input.

* gnu/packages/gnome.scm (mutter): [inputs]: Add xorg-server-xwayland.
[arguments]: Add '--with-xwayland-path' to #:configure-flags.
---
 gnu/packages/gnome.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 7b93ddd14..6750c125e 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -144,6 +144,7 @@
   #:use-module (gnu packages speech)
   #:use-module (gnu packages virtualization)
   #:use-module (gnu packages vpn)
+  #:use-module (gnu packages xorg)
   #:use-module (srfi srfi-1))
 
 (define-public brasero
@@ -4726,6 +4727,10 @@ to display dialog boxes from the commandline and shell scripts.")
              ;; The following flags are needed for the bundled clutter
              "--enable-x11-backend=yes"
 
+             (string-append "--with-xwayland-path="
+                            (assoc-ref %build-inputs "xorg-server-xwayland")
+                            "/bin/Xwayland")
+
              ;; the remaining flags are needed for the bundled cogl
              "--enable-cogl-gst"
              (string-append "--with-gl-libname="
@@ -4786,6 +4791,7 @@ to display dialog boxes from the commandline and shell scripts.")
        ("startup-notification" ,startup-notification)
        ("upower-glib" ,upower)
        ("xkeyboard-config" ,xkeyboard-config)
+       ("xorg-server-xwayland" ,xorg-server-xwayland)
        ("zenity" ,zenity)))
     (synopsis "Window and compositing manager")
     (home-page "https://www.gnome.org")
-- 
2.15.1

[bug#29758] [PATCH] gnu: mutter: Add xorg-xserver-xwayland input. (GNOME on Wayland)

[Ludovic Courtès]

Hi Rutger,

Rutger Helling <rhelling@mykolab.com> skribis:

> With this patch I'm able to launch a GNOME on Wayland session, on SDDM
> at least.

Woohoo!  Do you have a GuixSD config to do that?  Eventually we should
provide an easy way for people to use Wayland if they want to.

> From 514c3aa846a7b4828fd190781d25d726a2938524 Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Sun, 17 Dec 2017 21:37:11 +0100
> Subject: [PATCH] gnu: mutter: Add xorg-xserver-xwayland input.
>
> * gnu/packages/gnome.scm (mutter): [inputs]: Add xorg-server-xwayland.
> [arguments]: Add '--with-xwayland-path' to #:configure-flags.

Applied!

Could you create an account on savannah.gnu.org so we can give you
commit access?  That would be more convenient for you and a good thing
for the project’s growth I believe.  :-)

Thank you,
Ludo’.

[bug#29758] [PATCH] gnu: mutter: Add xorg-xserver-xwayland input. (GNOME on Wayland)

[Rutger Helling]

Thanks for pushing! I mailed you the login name of the account I created 
on savannah.gnu.org.

I'm actually not using the GuixSD config for it. What I have in it 
related to SDDM is:
          (service sddm-service-type
                  (sddm-configuration
                   (display-server "wayland")))

The only thing that's different from an untouched sddm-service-type is 
that the above says that SDDM should be using Wayland as well.
However, this doesn't work yet, so SDDM still uses X11 (I think upstream 
SDDM is working on it).

On SDDM you can select "GNOME (Wayland)" under sessions. For me that 
works out of the box.
I'll try SLiM, GDM and vanilla SDDM this weekend and see if they all 
work properly.

On 2017-12-22 09:58, ludo@gnu.org wrote:

> Hi Rutger,
> 
> Rutger Helling <rhelling@mykolab.com> skribis:
> 
>> With this patch I'm able to launch a GNOME on Wayland session, on SDDM
>> at least.
> 
> Woohoo!  Do you have a GuixSD config to do that?  Eventually we should
> provide an easy way for people to use Wayland if they want to.
> 
>> From 514c3aa846a7b4828fd190781d25d726a2938524 Mon Sep 17 00:00:00 2001
>> From: Rutger Helling <rhelling@mykolab.com>
>> Date: Sun, 17 Dec 2017 21:37:11 +0100
>> Subject: [PATCH] gnu: mutter: Add xorg-xserver-xwayland input.
>> 
>> * gnu/packages/gnome.scm (mutter): [inputs]: Add xorg-server-xwayland.
>> [arguments]: Add '--with-xwayland-path' to #:configure-flags.
> 
> Applied!
> 
> Could you create an account on savannah.gnu.org so we can give you
> commit access?  That would be more convenient for you and a good thing
> for the project's growth I believe.  :-)
> 
> Thank you,
> Ludo'.

[bug#29758] [PATCH] gnu: mutter: Add xorg-xserver-xwayland input. (GNOME on Wayland)

[Ludovic Courtès]

Rutger Helling <rhelling@mykolab.com> skribis:

> I'm actually not using the GuixSD config for it. What I have in it
> related to SDDM is:
>          (service sddm-service-type
>                  (sddm-configuration
>                   (display-server "wayland")))
>
> The only thing that's different from an untouched sddm-service-type is
> that the above says that SDDM should be using Wayland as well.
> However, this doesn't work yet, so SDDM still uses X11 (I think
> upstream SDDM is working on it).
>
> On SDDM you can select "GNOME (Wayland)" under sessions. For me that
> works out of the box.
> I'll try SLiM, GDM and vanilla SDDM this weekend and see if they all
> work properly.

Sounds nice!

Ludo'.

bug#29758: [PATCH] gnu: mutter: Add xorg-xserver-xwayland input. (GNOME on Wayland)

[Rutger Helling]

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

Hey Ludo,

Here's a signed reply back as talked about.

On Fri, 22 Dec 2017 14:34:03 +0100
ludo@gnu.org (Ludovic Courtès) wrote:

> Rutger Helling <rhelling@mykolab.com> skribis:
> 
> > I'm actually not using the GuixSD config for it. What I have in it
> > related to SDDM is:
> >          (service sddm-service-type
> >                  (sddm-configuration
> >                   (display-server "wayland")))
> >
> > The only thing that's different from an untouched sddm-service-type
> > is that the above says that SDDM should be using Wayland as well.
> > However, this doesn't work yet, so SDDM still uses X11 (I think
> > upstream SDDM is working on it).
> >
> > On SDDM you can select "GNOME (Wayland)" under sessions. For me that
> > works out of the box.
> > I'll try SLiM, GDM and vanilla SDDM this weekend and see if they all
> > work properly.  
> 
> Sounds nice!
> 
> Ludo'.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#29758] [PATCH] gnu: mutter: Add xorg-xserver-xwayland input. (GNOME on Wayland)

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

Rutger Helling <rhelling@mykolab.com> skribis:

> Here's a signed reply back as talked about.

You’re all set now!

Please read ‘HACKING’ for the rules that apply to commit access (and
re-read
<https://www.gnu.org/software/guix/manual/html_node/Contributing.html>
if needed ;-)).  If you have any questions, don’t hesitate to ask.

You’re also welcome to review other people’s patches and to push them on
their behalf if they don’t have commit access and you’re confident.

Thank you, and welcome aboard!  :-)

Ludo’.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#29758] [PATCH] gnu: mutter: Add xorg-xserver-xwayland input. (GNOME on Wayland)

[Rutger Helling]

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

Thanks a lot! I'll read up on the rules this weekend and test out
the Wayland logins :).

On Fri, 22 Dec 2017 16:45:39 +0100
ludo@gnu.org (Ludovic Courtès) wrote:

> Rutger Helling <rhelling@mykolab.com> skribis:
> 
> > Here's a signed reply back as talked about.  
> 
> You’re all set now!
> 
> Please read ‘HACKING’ for the rules that apply to commit access (and
> re-read
> <https://www.gnu.org/software/guix/manual/html_node/Contributing.html>
> if needed ;-)).  If you have any questions, don’t hesitate to ask.
> 
> You’re also welcome to review other people’s patches and to push them
> on their behalf if they don’t have commit access and you’re confident.
> 
> Thank you, and welcome aboard!  :-)
> 
> Ludo’.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]