From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gPt9Gsm0kGKCCwAAbAwnHQ (envelope-from ) for ; Fri, 27 May 2022 13:23:53 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id wIBtGsm0kGKJFgEAauVa8A (envelope-from ) for ; Fri, 27 May 2022 13:23:53 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2A30DFE48 for ; Fri, 27 May 2022 13:23:53 +0200 (CEST) Received: from localhost ([::1]:49484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuY4O-0001Iz-9B for larch@yhetil.org; Fri, 27 May 2022 07:23:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuXyk-0004qn-NX for guix-patches@gnu.org; Fri, 27 May 2022 07:18:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39015) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nuXyk-0007s0-8U for guix-patches@gnu.org; Fri, 27 May 2022 07:18:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nuXyk-0003B3-30 for guix-patches@gnu.org; Fri, 27 May 2022 07:18:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 May 2022 11:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55673 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 55673@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 55673-submit@debbugs.gnu.org id=B55673.165365024211341 (code B ref 55673); Fri, 27 May 2022 11:18:02 +0000 Received: (at 55673) by debbugs.gnu.org; 27 May 2022 11:17:22 +0000 Received: from localhost ([127.0.0.1]:32912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuXy5-0002wg-Oi for submit@debbugs.gnu.org; Fri, 27 May 2022 07:17:22 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:35376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nuXy2-0002tB-2s for 55673@debbugs.gnu.org; Fri, 27 May 2022 07:17:20 -0400 Received: from [172.20.10.5] ([188.188.253.34]) by baptiste.telenet-ops.be with bizsmtp id bnHG2700G0lHqdo01nHGCA; Fri, 27 May 2022 13:17:17 +0200 Message-ID: <22ddd5b3d9906b84b0f1ca79dc78964e59345a6d.camel@telenet.be> From: Maxime Devos Date: Fri, 27 May 2022 13:17:16 +0200 In-Reply-To: References: <20220527082519.501697-1-zimon.toutoune@gmail.com> <9432b1161007faacc0bd0e58da0bf839e2e8ec39.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-iAXrXFrz0d4vEFvUfopi" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1653650237; bh=/M4Inbifp/sFFCzaXkKJrV9o6S/NVvrpxP0p8KrOQxs=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=dU99Z2L5prgGHeAKt4YLyRA80GqJn5jJQiGAjlgf8W/l8WywLNPTjqbYKv5SIqxGI qs/L7fpJQfQ9u/Gfquji6IoF/iwhxBqZPzafTkcexNlvi425qwNT3B48NV1AMrsDM6 Vt5qLvJdjtG6u7G1GRHYnh8N6m1xtQvB0NNNdbe2fkq2y2VR2rwiaeF6Tf8N4zKd3a YiPTZQh/U3XWPods2HiLxjgZMJycZBY7OHnX+XVLYpnO40SMTlUuA8fHsIRuTUoOBh zIrCiH1CtR7C08iiepevgZAcK0rj8lIg+ZlVmJuIsvz6QaAfUOkbyibkMFT4o4J0IB 692oMw8+zFsyg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653650633; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=/M4Inbifp/sFFCzaXkKJrV9o6S/NVvrpxP0p8KrOQxs=; b=e1CEXG6mi2tWsdNTcjnOkpfR2Her4KVaUk0JGwAskxU+HDKpKO+2QcoSAs/AN3f8DbZL2C ER9aftaHvarA8WzaaExL0lD2YEDlKMNhZK2yfm4ccGe+NGI0shbBH9QPQVwVQT5Ta3RWMT qNzaP5l0TcEQEVQpXNWau7qWLsr52uuUl5mpbpdVz3/cgvsWfEoAM+Uh+WhkOQ6swoWRA4 ndKZEfhHxhKl+snmrnltLusw1FfkedPgyID9VLQD6oWlWO99IyxlX8QfgHowLBsTyvDc7+ naSRQpmyDB2GX5o0W6bVfL+90uPbbS4/pdtseGQmTg3OwJ2DMvqBSZAz0WiOIA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653650633; a=rsa-sha256; cv=none; b=cU0SJmPt+DW/TqVETI9IB39G8Uta76S/1eFAERxk3C4WB+6MuyLit3lfICOCZrLJWRfKJz Y57Q4/7oBburvqxodPwymn3lvB27OxLb0G9dAGTqZ4mS6Dd7c9t3mHbUxqwz7tdAdCKyZs cbA66htEaklBa3fmXt+9EdcDImMxeU15aw5RljdRxFNc8EyzZcaAxBmEfaTUjZvJgkLus8 T6kbQh1gasVdAG29CMz2aQ69oFwSisXzslAr4L2epNG0Se16NWR2VJ6S3oSxVSKpn925Vc nDD07n3x5bVIBMUts87N2LdAbTJFpV+Dyjo3V+wOw1czMED1VN1613sGrxUB3Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=dU99Z2L5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.85 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=dU99Z2L5; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2A30DFE48 X-Spam-Score: 3.85 X-Migadu-Scanner: scn1.migadu.com X-TUID: zvcmkDJ0NUgq --=-iAXrXFrz0d4vEFvUfopi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable zimoun schreef op vr 27-05-2022 om 12:28 [+0200]: > > Also, I'd switch the catch and the (match ...) because 'read' and > > integer? shouldn't raise any 'system-error'. >=20 > All the cases are covered, IMHO. Too many cases are covered. E.g., what if the file was a directory? scheme@(guile-user)> (call-with-input-file "." read) ice-9/boot-9.scm:1669:16: In procedure raise-exception: In procedure fport_read: Is een map Greetings, Maxime. --=-iAXrXFrz0d4vEFvUfopi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYpCzPBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7qPoAQD7aCZXfdItRx4XPRgOOLW8IEZ1 jH20EGIIshZKl3pN+QEAsWJZzPSMkah+eh+hf8iMctpBmMXmMl0IUjn6e+hxyQc= =0Ksy -----END PGP SIGNATURE----- --=-iAXrXFrz0d4vEFvUfopi--