Custom 'install phase

Custom 'install phase

[Raghav Gururajan]

[-- Attachment #1.1: Type: text/plain, Size: 1040 bytes --]

Hello Guix!

I am trying to re-write the custom 'install phase of this 
(https://paste.debian.net/1188301/) package definition,as follows:

```
            (replace 'install
              (lambda _
                (for-each (lambda (solution)
                            (with-directory-excursion solution
                                 (apply (assoc-ref copy:%standard-phases 
'install)
                                        #:install-plan
                                        '(("src" (string-append 
"include/" solution)
                                           #:include-regexp ("\\.h$"))))))
                          (list
                           "qtlockedfile"
                           "qtpropertybrowser"
                           "qtservice"
                           "qtsingleapplication"
                           "qtsoap"))
                #t))
```

I get an error In procedure apply: Apply to non-list: "src".

Can anyone help me with the correct snippet please?

Regards,
RG.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

Re: Custom 'install phase

[Julien Lepiller]

I think you need to remove the apply, but keep one level of parenthesis, like so:

((assoc-ref …) args …)

Apply takes the last arguments, which must be a list and appends all its elements to the invocation. Like (apply foo '(1 2 3 4)) is tge same as (foo 1 2 3 4). Here you're probably confused because of the assoc-ref is not a procodure, but it's fine: it returns a procedure, so guile can execute it and pass arguments to it the normal way.

Le 7 mars 2021 14:06:37 GMT-05:00, Raghav Gururajan <rg@raghavgururajan.name> a écrit :
>Hello Guix!
>
>I am trying to re-write the custom 'install phase of this 
>(https://paste.debian.net/1188301/) package definition,as follows:
>
>```
>            (replace 'install
>              (lambda _
>                (for-each (lambda (solution)
>                            (with-directory-excursion solution
>                               (apply (assoc-ref copy:%standard-phases 
>'install)
>                                        #:install-plan
>                                        '(("src" (string-append 
>"include/" solution)
>                                        #:include-regexp ("\\.h$"))))))
>                          (list
>                           "qtlockedfile"
>                           "qtpropertybrowser"
>                           "qtservice"
>                           "qtsingleapplication"
>                           "qtsoap"))
>                #t))
>```
>
>I get an error In procedure apply: Apply to non-list: "src".
>
>Can anyone help me with the correct snippet please?
>
>Regards,
>RG.

Re: Custom 'install phase

[Raghav Gururajan]

[-- Attachment #1.1: Type: text/plain, Size: 1458 bytes --]

Hi Julien!

> I think you need to remove the apply, but keep one level of parenthesis, 
> like so:
> 
> ((assoc-ref …) args …)
> 
> Apply takes the last arguments, which must be a list and appends all its 
> elements to the invocation. Like (apply foo '(1 2 3 4)) is tge same as 
> (foo 1 2 3 4). Here you're probably confused because of the assoc-ref is 
> not a procodure, but it's fine: it returns a procedure, so guile can 
> execute it and pass arguments to it the normal way.

So I tried the following:

```
            (replace 'install
              (lambda _
                (for-each (lambda (solution)
                            (with-directory-excursion solution
                                 ((assoc-ref copy:%standard-phases 'install)
                                        #:install-plan
                                        '(("src" (string-append 
"include/" solution)
                                           #:include-regexp ("\\.h$"))))))
                          (list
                           "qtlockedfile"
                           "qtpropertybrowser"
                           "qtservice"
                           "qtsingleapplication"
                           "qtsoap"))
                #t))
```

I get "In procedure string-append: Wrong type (expecting string): #f", 
with and without replacing `(string-append "include/" solution)` with 
`"include"`.

Regards,
RG.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

Re: Custom 'install phase

[Ricardo Wurmus]

Raghav Gururajan <rg@raghavgururajan.name> writes:

> Hi Julien!
>
>> I think you need to remove the apply, but keep one level of
>> parenthesis, like so:
>> ((assoc-ref …) args …)
>> Apply takes the last arguments, which must be a list and appends all
>> its elements to the invocation. Like (apply foo '(1 2 3 4)) is tge
>> same as (foo 1 2 3 4). Here you're probably confused because of the
>> assoc-ref is not a procodure, but it's fine: it returns a procedure,
>> so guile can execute it and pass arguments to it the normal way.
>
> So I tried the following:
>
> ```
>            (replace 'install
>              (lambda _
>                (for-each (lambda (solution)
>                            (with-directory-excursion solution
>                                 ((assoc-ref copy:%standard-phases 'install)
>                                        #:install-plan
>                                        '(("src" (string-append
>                                        "include/" solution)

The (string-append …) is quoted.  Is this on purpose?

>                #t))

Note that we no longer need to end phases on #t.

-- 
Ricardo

Re: Custom 'install phase

[Raghav Gururajan]

[-- Attachment #1.1: Type: text/plain, Size: 1007 bytes --]

Hi Ricardo!

> The (string-append …) is quoted.  Is this on purpose?
> 
>>                 #t))
> 
> Note that we no longer need to end phases on #t.

Oops, I meed to change that to (list. I now did:

```
            (replace 'install
              (lambda _
                (for-each (lambda (solution)
                            (with-directory-excursion solution
                                 ((assoc-ref copy:%standard-phases 'install)
                                        #:install-plan
                                        (list ("src" (string-append 
"include/" solution)
                                           #:include-regexp ("\\.h$"))))))
                          (list
                           "qtlockedfile"
                           "qtpropertybrowser"
                           "qtservice"
                           "qtsingleapplication"
                           "qtsoap"))))
```

I now get Wrong type to apply: "\\.h$"

Regards,
RG.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

Re: Custom 'install phase

[Julien Lepiller]

Maybe quote it? #:include-regexp '("\\.h$")

Le 8 mars 2021 04:35:28 GMT-05:00, Raghav Gururajan <rg@raghavgururajan.name> a écrit :
>Hi Ricardo!
>
>> The (string-append …) is quoted.  Is this on purpose?
>> 
>>>                 #t))
>> 
>> Note that we no longer need to end phases on #t.
>
>Oops, I meed to change that to (list. I now did:
>
>```
>            (replace 'install
>              (lambda _
>                (for-each (lambda (solution)
>                            (with-directory-excursion solution
>                            ((assoc-ref copy:%standard-phases 'install)
>                                        #:install-plan
>                                        (list ("src" (string-append 
>"include/" solution)
>                                        #:include-regexp ("\\.h$"))))))
>                          (list
>                           "qtlockedfile"
>                           "qtpropertybrowser"
>                           "qtservice"
>                           "qtsingleapplication"
>                           "qtsoap"))))
>```
>
>I now get Wrong type to apply: "\\.h$"
>
>Regards,
>RG.

Re: Custom 'install phase

[Raghav Gururajan]

[-- Attachment #1.1: Type: text/plain, Size: 865 bytes --]

Hi Julien!

> Maybe quote it? #:include-regexp '("\\.h$")

So I did:

```
            (replace 'install
              (lambda _
                (for-each (lambda (solution)
                            (with-directory-excursion solution
                                 ((assoc-ref copy:%standard-phases 'install)
                                        #:install-plan
                                        (list ("src" (string-append 
"include/" solution)
                                           #:include-regexp '("\\.h$"))))))
                          (list
                           "qtlockedfile"
                           "qtpropertybrowser"
                           "qtservice"
                           "qtsingleapplication"
                           "qtsoap"))))
```

I get Wrong type to apply: "src"

Regards,
RG.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

Re: Custom 'install phase

[Julien Lepiller]

Well, look at the location of that "src". You have ("src" (string-append …)). That can't work, "src" is a string, not a function (that's what the error message is trying to tell you).

Since you need two lists for the install-plan, you can fix that with:

#:install-plan
(list (list "src" (string-append …)))

Le 8 mars 2021 20:09:24 GMT-05:00, Raghav Gururajan <rg@raghavgururajan.name> a écrit :
>Hi Julien!
>
>> Maybe quote it? #:include-regexp '("\\.h$")
>
>So I did:
>
>```
>            (replace 'install
>              (lambda _
>                (for-each (lambda (solution)
>                            (with-directory-excursion solution
>                            ((assoc-ref copy:%standard-phases 'install)
>                                        #:install-plan
>                                        (list ("src" (string-append 
>"include/" solution)
>                                       #:include-regexp '("\\.h$"))))))
>                          (list
>                           "qtlockedfile"
>                           "qtpropertybrowser"
>                           "qtservice"
>                           "qtsingleapplication"
>                           "qtsoap"))))
>```
>
>I get Wrong type to apply: "src"
>
>Regards,
>RG.

Re: Custom 'install phase

[Raghav Gururajan]

[-- Attachment #1.1: Type: text/plain, Size: 521 bytes --]

Hi Julien!

> Well, look at the location of that "src". You have ("src" (string-append 
> …)). That can't work, "src" is a string, not a function (that's what the 
> error message is trying to tell you).
> 
> Since you need two lists for the install-plan, you can fix that with:
> 
> #:install-plan
> (list (list "src" (string-append …)))

Wouldn't that make `"src"` and `(string-append "include/" solutions)` 
make two separate components of a list? They must be one single argument.

Regards,
RG.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

Re: Custom 'install phase

[Raghav Gururajan]

[-- Attachment #1.1: Type: text/plain, Size: 879 bytes --]

So this appears to be close to working one:

```
            (replace 'install
              (lambda args
                (for-each (lambda (solution)
                            (with-directory-excursion solution
                              (apply (assoc-ref copy:%standard-phases 
'install)
                                     #:install-plan
                                     '(("src" "include/qtsolutions"
                                        #:include-regexp ("\\.h$")))
                                     args)))
                          (list
                           "qtlockedfile"
                           "qtpropertybrowser"
                           "qtservice"
                           "qtsingleapplication"
                           "qtsoap"))))
```

I now get "In procedure copy-file: Permission denied".

Regards,
RG.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

Re: Custom 'install phase

[Ricardo Wurmus]

Raghav Gururajan <rg@raghavgururajan.name> writes:

>            (replace 'install
>              (lambda _
>                (for-each (lambda (solution)
>                            (with-directory-excursion solution
>                                 ((assoc-ref copy:%standard-phases 'install)
>                                        #:install-plan
>                                        (list ("src" (string-append
>                                        "include/" solution)
>                                           #:include-regexp '("\\.h$"))))))
>                          (list
>                           "qtlockedfile"
>                           "qtpropertybrowser"
>                           "qtservice"
>                           "qtsingleapplication"
>                           "qtsoap"))))
[…]

> I get Wrong type to apply: "src"

As Julien wrote this is expected as you have an expression that starts
with a string:

   ("hello" whatever)

This will try to apply the string "hello" to the argument “whatever”.  I
don’t know how to apply a string to anything, and neither does Scheme.

I would go with quasiquotation:

--8<---------------cut here---------------start------------->8---
(with-directory-excursion solution
  ((assoc-ref copy:%standard-phases 'install)
   #:install-plan
   `(("src" ,(string-append "include/" solution)
      #:include-regexp ("\\.h$")))))
--8<---------------cut here---------------end--------------->8---

The expression following #:install-plan is quoted (so it’s inert data),
and we temporarily unquote to evaluate the “string-append” expression;
then we go straight back to “data mode”, so we don’t have to explicitly
quote “("\\.h$")”.

-- 
Ricardo

Re: Custom 'install phase

[Raghav Gururajan]

[-- Attachment #1.1: Type: text/plain, Size: 997 bytes --]

Hi Ricardo!

> As Julien wrote this is expected as you have an expression that starts
> with a string:
> 
>     ("hello" whatever)
> 
> This will try to apply the string "hello" to the argument “whatever”.  I
> don’t know how to apply a string to anything, and neither does Scheme.
> 
> I would go with quasiquotation:
> 
> --8<---------------cut here---------------start------------->8---
> (with-directory-excursion solution
>    ((assoc-ref copy:%standard-phases 'install)
>     #:install-plan
>     `(("src" ,(string-append "include/" solution)
>        #:include-regexp ("\\.h$")))))
> --8<---------------cut here---------------end--------------->8---
> 
> The expression following #:install-plan is quoted (so it’s inert data),
> and we temporarily unquote to evaluate the “string-append” expression;
> then we go straight back to “data mode”, so we don’t have to explicitly
> quote “("\\.h$")”.

It worked. Thanks so much!

Regards,
RG.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]