[bug#74728] [PATCH] gnu: python-asyncssh: Disable flaky connection tests.

[bug#74728] [PATCH] gnu: python-asyncssh: Disable flaky connection tests.

[Roman Scherer]

* gnu/packages/ssh.scm (python-asyncssh): Disable flaky connection tests.

Change-Id: If99cc686679fd2c731f3d66a85abe23eff6f1234
---
 gnu/packages/ssh.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
index 1f33259246..a44976b598 100644
--- a/gnu/packages/ssh.scm
+++ b/gnu/packages/ssh.scm
@@ -833,7 +833,15 @@ (define-public python-asyncssh
                ;; TODO Test fails for unknown reason
                (("(.+)async def test_confirm" all indent)
                 (string-append indent "@unittest.skip('disabled by guix')\n"
-                               indent "async def test_confirm")))))
+                               indent "async def test_confirm")))
+             (substitute* "tests/test_connection.py"
+               ;; Tests fail with: asyncssh.misc.ConnectionLost: Connection lost
+               (("(.+)async def test_get_server_host_key_proxy" all indent)
+                (string-append indent "@unittest.skip('disabled by guix')\n"
+                               indent "async def test_get_server_host_key_proxy"))
+               (("(.+)async def test_connect_reverse_proxy" all indent)
+                (string-append indent "@unittest.skip('disabled by guix')\n"
+                               indent "async def test_connect_reverse_proxy")))))
          (replace 'check
            (lambda* (#:key tests? inputs outputs #:allow-other-keys)
              (when tests?

base-commit: bc630c5ebed27edd821ec363706f8b9cf1ee05cc
-- 
2.46.0

[bug#74728] [PATCH] gnu: python-asyncssh: Disable flaky connection tests.

[Sharlatan Hellseher]

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

Hi,

Thanks for the patch.

Give it a try to refactor it by using pyproject-build-system,
contsing much simpler test excluding mechanics.

Oleg

[-- Attachment #2: Type: text/html, Size: 326 bytes --]

bug#74728: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.

[Sharlatan Hellseher]

[-- Attachment #1: Type: text/plain, Size: 86 bytes --]



Hi,

Pushed as f2ad73507b9a313024893e837aa11774f61b273f to master.

--
Thanks,
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[bug#74728] [PATCH] gnu: python-asyncssh: Disable more tests.

[Roman Scherer]

* gnu/packages/ssh.scm (python-asyncssh): Disable more tests.

Change-Id: I9f3a746bdf820c1d357fd655f1ed1ff197327856
---
 gnu/packages/ssh.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
index 95ad38a642..dc344b850f 100644
--- a/gnu/packages/ssh.scm
+++ b/gnu/packages/ssh.scm
@@ -824,8 +824,11 @@ (define-public python-asyncssh
                     (list "not test_confirm"
                           ;; Tests fail with: asyncssh.misc.ConnectionLost:
                           ;; Connection lost
-                          "test_get_server_host_key_proxy"
-                          "test_connect_reverse_proxy")
+                          "test_connect_non_tcp_sock"
+                          "test_connect_reverse_proxy"
+                          "test_get_server_auth_methods_no_sockn"
+                          "test_get_server_auth_methods_no_sockname"
+                          "test_get_server_host_key_proxy")
                     " and not " ))
       #:phases
       #~(modify-phases %standard-phases

base-commit: eafd91c26232f039a3170b73e40b0a2d5983c474
--
2.46.0

[bug#74728] [PATCH] gnu: python-asyncssh: Disable more tests.

[Sharlatan Hellseher]

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

Hi,


CI for x86_64 just finished without issues, note I've refunded the

version.

Maybe we may make flakey test architecture specific, WDYT?


Oleg

[-- Attachment #2: Type: text/html, Size: 294 bytes --]

[bug#74728] [PATCH] gnu: python-asyncssh: Disable more tests.

[Roman Scherer]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

Sharlatan Hellseher <sharlatanus@gmail.com> writes:

Hi Oleg,

yes, maybe better. I sent a version of the previous patch that only
disables those tests on aarch64.

Wdyt?

Thanks, Roman.

> Hi,
>
> CI for x86_64 just finished without issues, note I've refunded the
>
> version.
>
> Maybe we may make flakey test architecture specific, WDYT?
>
> Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]

[bug#74728] closed ([PATCH] gnu: python-asyncssh: Disable flaky connection tests.)

[Roman Scherer]

[-- Attachment #1: Type: text/plain, Size: 3416 bytes --]

References: <87y10q73sd.fsf@gmail.com>
	<8403c5159deb34bf4dac119d55c57c9dba530a20.1733594283.git.roman@burningswell.com>
	<handler.74728.D74728.173366126726317.notifdone@debbugs.gnu.org>
User-Agent: mu4e 1.12.7; emacs 29.4
Hi Oleg,

thanks for applying my patch. I now tried to build python-asyncssh from the
Guix master branch, but unfortunatly now other tests started to fail, which
didn't fail before for some reason.

I guess you don't see those issues, so maybe it is specific to my aarch64 system?

I sent a new mail and added a new patch that disables more tests. Could you
take a look at them?

Thanks, Roman.

Date: Sun, 08 Dec 2024 15:18:14 +0100

help-debbugs@gnu.org (GNU bug Tracking System) writes:

> Your bug report
>
> #74728: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.
>
> which was filed against the guix-patches package, has been closed.
>
> The explanation is attached below, along with your original report.
> If you require more details, please reply to 74728@debbugs.gnu.org.
>
> --
> 74728: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74728
> GNU Bug Tracking System
> Contact help-debbugs@gnu.org with problems
>
> From: Sharlatan Hellseher <sharlatanus@gmail.com>
> Subject: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.
> To: 74728-done@debbugs.gnu.org
> Date: Sun, 08 Dec 2024 12:33:22 +0000 (1 hour, 42 minutes, 21 seconds ago)
>
>
>
> Hi,
>
> Pushed as f2ad73507b9a313024893e837aa11774f61b273f to master.
>
> --
> Thanks,
> Oleg
>
> ----------
>
> From: Roman Scherer <roman@burningswell.com>
> Subject: [PATCH] gnu: python-asyncssh: Disable flaky connection tests.
> To: guix-patches@gnu.org
> Cc: Roman Scherer <roman@burningswell.com>
> Date: Sat,  7 Dec 2024 19:00:20 +0100
> Date: Sat,  7 Dec 2024 19:00:20 +0100 (20 hours, 15 minutes, 23 seconds ago)
>
> * gnu/packages/ssh.scm (python-asyncssh): Disable flaky connection tests.
>
> Change-Id: If99cc686679fd2c731f3d66a85abe23eff6f1234
> ---
>  gnu/packages/ssh.scm | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
> index 1f33259246..a44976b598 100644
> --- a/gnu/packages/ssh.scm
> +++ b/gnu/packages/ssh.scm
> @@ -833,7 +833,15 @@ (define-public python-asyncssh
>                 ;; TODO Test fails for unknown reason
>                 (("(.+)async def test_confirm" all indent)
>                  (string-append indent "@unittest.skip('disabled by guix')\n"
> -                               indent "async def test_confirm")))))
> +                               indent "async def test_confirm")))
> +             (substitute* "tests/test_connection.py"
> +               ;; Tests fail with: asyncssh.misc.ConnectionLost: Connection lost
> +               (("(.+)async def test_get_server_host_key_proxy" all indent)
> +                (string-append indent "@unittest.skip('disabled by guix')\n"
> +                               indent "async def test_get_server_host_key_proxy"))
> +               (("(.+)async def test_connect_reverse_proxy" all indent)
> +                (string-append indent "@unittest.skip('disabled by guix')\n"
> +                               indent "async def test_connect_reverse_proxy")))))
>           (replace 'check
>             (lambda* (#:key tests? inputs outputs #:allow-other-keys)
>               (when tests?
>
> base-commit: bc630c5ebed27edd821ec363706f8b9cf1ee05cc

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]

[bug#74728] [PATCH] gnu: python-asyncssh: Disable failing tests on aarch64.

[Roman Scherer]

* gnu/packages/ssh.scm (python-asyncssh): Disable failing tests on aarch64.

Change-Id: I9f3a746bdf820c1d357fd655f1ed1ff197327856
---
 gnu/packages/ssh.scm | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/ssh.scm b/gnu/packages/ssh.scm
index 95ad38a642..bf4e04d55b 100644
--- a/gnu/packages/ssh.scm
+++ b/gnu/packages/ssh.scm
@@ -820,12 +820,19 @@ (define-public python-asyncssh
      (list
       #:test-flags
       #~(list "-k" (string-join
-                    ;; TODO Test fails for unknown reason
-                    (list "not test_confirm"
-                          ;; Tests fail with: asyncssh.misc.ConnectionLost:
-                          ;; Connection lost
-                          "test_get_server_host_key_proxy"
-                          "test_connect_reverse_proxy")
+                    (list
+                     ;; TODO Test fails for unknown reason
+                     "not test_confirm"
+                     #$@(if (target-aarch64?)
+                            (list
+                             ;; Tests fail with: asyncssh.misc.ConnectionLost:
+                             ;; Connection lost
+                             "test_connect_non_tcp_sock"
+                             "test_connect_reverse_proxy"
+                             "test_get_server_auth_methods_no_sockn"
+                             "test_get_server_auth_methods_no_sockname"
+                             "test_get_server_host_key_proxy")
+                            '()))
                     " and not " ))
       #:phases
       #~(modify-phases %standard-phases

base-commit: 17d86ac9df841deca4f2f5e173f50bd2461fe680
-- 
2.46.0

[bug#74728] [PATCH] gnu: python-asyncssh: Disable flaky connection tests.

[Sharlatan Hellseher]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]


Hi,

[PATCH] gnu: python-asyncssh: Disable failing tests on aarch64.
Pushed as ec1a67d4ff7435fdf50de35c3f57d2f60a9cccf9 to master.

It was built successfully both on x86_68 and aarch64 in Qemu.

Pleas, open other issue if you find something else ;-).

--
Thanks,
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]