From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SAwSJgWR62GPGAAAgWs5BA (envelope-from ) for ; Sat, 22 Jan 2022 06:07:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GBdiIwWR62EYrgAA9RJhRA (envelope-from ) for ; Sat, 22 Jan 2022 06:07:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 42C2A20586 for ; Sat, 22 Jan 2022 06:07:17 +0100 (CET) Received: from localhost ([::1]:44260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nB8cO-00019K-0h for larch@yhetil.org; Sat, 22 Jan 2022 00:07:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49984) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nB8cA-00017f-Qi for guix-patches@gnu.org; Sat, 22 Jan 2022 00:07:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nB8cA-0008Dj-GT for guix-patches@gnu.org; Sat, 22 Jan 2022 00:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nB8cA-000330-8Q for guix-patches@gnu.org; Sat, 22 Jan 2022 00:07:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53015] [PATCH 2/4] gnu: spdlog: Build with '-fpic'. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 22 Jan 2022 05:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53015 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "53015@debbugs.gnu.org" <53015@debbugs.gnu.org> Cc: Nicolas Goaziou Received: via spool by 53015-submit@debbugs.gnu.org id=B53015.164282799011670 (code B ref 53015); Sat, 22 Jan 2022 05:07:02 +0000 Received: (at 53015) by debbugs.gnu.org; 22 Jan 2022 05:06:30 +0000 Received: from localhost ([127.0.0.1]:35524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nB8be-00032A-Dn for submit@debbugs.gnu.org; Sat, 22 Jan 2022 00:06:30 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:34239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nB8bb-00031r-JM for 53015@debbugs.gnu.org; Sat, 22 Jan 2022 00:06:28 -0500 Date: Sat, 22 Jan 2022 05:06:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail2; t=1642827980; bh=keE2gxr7j1aBAqt9cTOFLeI7wY40aKvdNcVgRvr3p3s=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc; b=FSt8iNMWAIalx2Hpe3ME3//XTgRA1HcVZ2RfnpAsLrNXpXewGR965LsbV+lgkySwb MjVDHxNnIE5vE9gmpfSmMQvcF0BEGDPoYcnxHsH4FzFMWcPDzccxvEalxTw/fTgG7f Af2uAIQ4yE1tTgIkZv9+XKZHrSZT4QfCybAhwv7gUk2Gzfre0QafDBc4Iu00j2XBih /w5s9blaMY26OGogPdBagcqL1wJBpFOGNF0co9lyuDYvObZHDd+KyXbhFkSO+DJAp1 3gACtcFuy2CxjYABFCFJ+dQ4ZGB29sWugfPW5tUnVHK0GSwOyRg9zj0waaA3HJhtLc HnaRwRb+C2wxQ== Message-ID: <20wqWzWXCQm8C64APXWiUBQfFY0dYThLJMM9eoq7iiTvAoYra7wo97BUbAZwwW8O8PUdY5JNx_7gdA6QIAv-x6-dU3QsnkXKGW7V6mJjpaY=@protonmail.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642828037; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=keE2gxr7j1aBAqt9cTOFLeI7wY40aKvdNcVgRvr3p3s=; b=SL9tx0vJ17byz4t4CudZIHf0KpHZhre7pAoze+aP4l0UxHHjBLaiGeaRzXiUkWy/MGGigp 2M7NyBxtHx4BklJXngom/4qOHJC8mRRsPavnmV+wT7oVROgntOc8VLooLWfThP29+L9Nam Vf+UsOavq19Chf1Msc10RsipRJdAD9Vz0DYxgdoTMPAvf48yqksuIl3CtJ7dh0gAYb6hOo 1utUCI4bXFUTxWoJFpa44JmEA/pyY9DiHvsuuDtvHztvzI3fXp7uNZ8Om/0Cz17G+mMhBT 58UnqfnTxwpdA1YCLwMF46eKg7bpflCHkD4YM292DGx2FqKcw8ku7UQaPbDeFw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642828037; a=rsa-sha256; cv=none; b=YaVA8UOcLtsOC1At/lnZGSdb8WnRpOVvNOqrrSR6skHQzqaGPnW614jHRCeh/7jtVpvECK U+i224rTWtoboN6WxludW8uZwU7OZOx/qfDBKGfviiu6vuNOWGoS02UirJh3xo5Ut+ssdg c/NFBDOlB2TR8dwUrp9GfojvOKoPTjKthRvdWH4ymyAiIPyvULsi8oJqISbZ65CMBuAmnl CcATjjLf/gPumIgtnVoCcB7VbNYiaSBUTAYan3GiSmiZLCC8J62+gehB0gl7DmYRhahXI7 OyfxQ0+ylmO58e4gm85814ttE/kihYv8iB7iJKg7zOxk0pAwjWqDoGeHw8d+kA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail2 header.b=FSt8iNMW; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail2 header.b=FSt8iNMW; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 42C2A20586 X-Spam-Score: -4.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: /7JsUr4BGeAz Hello, This patch (2/4 build option for spdlog, part of the MangoHud patch series)= may be superseded by https://git.savannah.gnu.org/cgit/guix.git/commit/?id= =3Db1542d59606919d0da04914fa6916b85354e2f89 (CCing Nicolas, hope that's ok= ay!) I've built MangoHud with the shared spdlog before, seems to work. However, given what spdlog has in its documentation, I wonder if it would b= e better to default to the static version as before? I think the "-fpic" bu= ild option would also work for shared linking in general? Or does that not = work for nheko, which this change was for I believe? I'm not really sure though, nor have a strong opinion, just going based on = spdlog's info and that some projects (like MangoHud) build spdlog as a stat= ic library by default when bundling. I'm guessing it is for performance rea= sons, though I don't know if that is realized. John