From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id YL9DOHO5TGTcygAASxT56A (envelope-from ) for ; Sat, 29 Apr 2023 08:30:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id MAdpN3O5TGQfQAEAG6o9tA (envelope-from ) for ; Sat, 29 Apr 2023 08:30:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3A99BEC2E for ; Sat, 29 Apr 2023 08:30:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pse5t-00075B-Rx; Sat, 29 Apr 2023 02:30:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pse5r-00074w-GW for bug-guix@gnu.org; Sat, 29 Apr 2023 02:30:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pse5q-00072O-Uk for bug-guix@gnu.org; Sat, 29 Apr 2023 02:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pse5q-0000um-Ja for bug-guix@gnu.org; Sat, 29 Apr 2023 02:30:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH 11/17] services: mpd: Warn when the MPD user is not in the "audio" group. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 29 Apr 2023 06:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer , 63082@debbugs.gnu.org Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.16827498013488 (code B ref 63082); Sat, 29 Apr 2023 06:30:02 +0000 Received: (at 63082) by debbugs.gnu.org; 29 Apr 2023 06:30:01 +0000 Received: from localhost ([127.0.0.1]:34998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pse5p-0000uC-0g for submit@debbugs.gnu.org; Sat, 29 Apr 2023 02:30:01 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:62911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pse5o-0000u0-3X for 63082@debbugs.gnu.org; Sat, 29 Apr 2023 02:30:00 -0400 Received: by mail-ed1-f66.google.com with SMTP id 4fb4d7f45d1cf-50a145a0957so24050966a12.1 for <63082@debbugs.gnu.org>; Fri, 28 Apr 2023 23:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682749794; x=1685341794; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=ja/MlC8rPXErLv63vw5ds3BpKAmfBJ9035PZQ0IIri4=; b=li4T73N9Ca9CxiQG9N/8EuNlWdozdrr620vmBLuj8yuHorKdfqiYxqNpstThq45i84 3OkhdsNhxsm+gjN0oDMWT+V2yPWuUoMgL463ik8OTRScTHODg83H/Vz01Y4prvC4AW4c zasbb1yQmSgSK+DFuy2SaO/ub36/ymUrnUpO5tBh8XTLVGW0Zk5KyWbxYM+bYGmtT3qq fcW5dB1JqyRZFt1/xwd+wFWYB6qbZyQWCoOtyKz0iqHKfYPcyJXuka6D/9yziWmty3nV NJwRp8mcHBPXiczlt/yrWcTZJ86knulcNMbF6im450/BV5R5T/E1YmyYUDDdmD0rXn5o LYjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682749794; x=1685341794; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ja/MlC8rPXErLv63vw5ds3BpKAmfBJ9035PZQ0IIri4=; b=Gumef+TH78K9wi2ae03c/YKDfpCZQJYXJ2EoLJTVrjdyJhDfrY5XOnLDkiDZNAcYHr 6c3M0mU81JXIBlmDbku8t0zLNcSNXwJlzRowhI+gefHQ5LdjV+QRQUKM3BLgW71OihVh POgBm1oCL1P5gCJlbYNlbXpLs5w9FpSysWvbQ7r0yPI7HK76F6qk8B75KgCiBi2rKdYB xu42WwityJfgbjCSlc5T0TaK+W9malnrGJz3SX4JBt3623DxnL+e7Y6Den/TtclWd+yP qgdWAQ96E8YOCD+mslXmyQ6Ib7eraXqiMb4p13CH/NxJ/O/cbCRxifbslIwSk+6BFaUe 0usg== X-Gm-Message-State: AC+VfDyFwdZ2aLiV5qNXzBrgwC20AhZA95iQbbkIv5tOPmf8MAJSxTXj kh5f9YWLIpLXgN5XK4cYs/s= X-Google-Smtp-Source: ACHHUZ65HnDFdTD2Fwl/cLDclXVL2pvxiEfenWgYqrUlocenj1BpM0UtZuafbeyn83DBBIfpqGfbEQ== X-Received: by 2002:aa7:d0ce:0:b0:506:a44c:e213 with SMTP id u14-20020aa7d0ce000000b00506a44ce213mr828930edo.20.1682749794335; Fri, 28 Apr 2023 23:29:54 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id s16-20020a056402165000b0050477decdfasm9717429edx.3.2023.04.28.23.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 23:29:54 -0700 (PDT) Message-ID: <20ba24c1173d4377731c70380e630076e88a4ef4.camel@gmail.com> From: Liliana Marie Prikler Date: Sat, 29 Apr 2023 08:29:53 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682749811; a=rsa-sha256; cv=none; b=XtMbj8odhsOfidYwIwcvqSOnRj6WF8JYS0lYuGxbCzjrJrVasJpvXdnBHEQNuHY7cQNCAf jRwEYkXlisfsf2roU/GDnII9lC1mS1E0JeMaEmbBuyv87suvN3Ny1XHhQoWDfdLr8o5zp1 qJjxuRniTwmED0uYwikYQe2MOhTjDErhJHMoHXpEYNfTbVJFWTC1IhpgBuhFtlmc2BWqqQ 8Rwb7FpuAv8rclaIF0G7jsjHL62kj1G7diZFvPjjaZEwulE9813owgzqba1L8fmsRB3kce YlQqp9N5ltDXGGHqd+7+l6tkLeLZJjZL2H8Z47V/zczv+r6suzsNDwPsquM+UQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=li4T73N9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682749811; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ja/MlC8rPXErLv63vw5ds3BpKAmfBJ9035PZQ0IIri4=; b=NkgNqxIFyRF1juumJJkDca8FwF/yvzecYh2GAi3Kagv6NPJ4VlmEFQn62Vs12H3CMT/5Eh yeNB50cMPE2amOmvlpfoK8wUsIFJ4IaXXQw6aHq2xye+TfuPXYohVfBc0L+p+mTslLlgOE 5ltjJB1p1+bcB3ZFVRPF3FMtmPR2KrSakdVB7tXPOEiqKtFpv2f6EQX7hfiHXwr2pYR/fP Hz/NRAy4rJmHeQnA0248bCwqLgsuvIgfuOWganlBCSUP9NXWKWoeIU+0+7TmrIc3Z20GBv x5C4oFJtd3wm27hqodSsvGuHYjdeAsNWt7sCAvrq0CgqyQEOJNx/LG/B+6Dg4A== X-Migadu-Spam-Score: -2.11 X-Spam-Score: -2.11 X-Migadu-Queue-Id: 3A99BEC2E X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=li4T73N9; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: LryGc7YFoqdX Am Freitag, dem 28.04.2023 um 10:27 -0400 schrieb Maxim Cournoyer: > Relates to . >=20 > * gnu/services/audio.scm (%mpd-user) [group]: Add comment. > (mpd-user-sanitizer): Warn if the MPD user is not in the audio group. > --- > =C2=A0gnu/services/audio.scm | 16 +++++++++++++--- > =C2=A01 file changed, 13 insertions(+), 3 deletions(-) >=20 > diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm > index 550ccc542c..9579432ea3 100644 > --- a/gnu/services/audio.scm > +++ b/gnu/services/audio.scm > @@ -30,6 +30,7 @@ (define-module (gnu services audio) > =C2=A0=C2=A0 #:use-module (gnu services configuration) > =C2=A0=C2=A0 #:use-module (gnu services shepherd) > =C2=A0=C2=A0 #:use-module (gnu services admin) > +=C2=A0 #:use-module (gnu system accounts) > =C2=A0=C2=A0 #:use-module (gnu system shadow) > =C2=A0=C2=A0 #:use-module (gnu packages admin) > =C2=A0=C2=A0 #:use-module (gnu packages mpd) > @@ -172,6 +173,8 @@ (define-maybe boolean (prefix mpd-)) > =C2=A0(define %mpd-user > =C2=A0=C2=A0 (user-account > =C2=A0=C2=A0=C2=A0 (name "mpd") > +=C2=A0=C2=A0 ;; Being in the audio group ensures that PulseAudio can acc= ess > sound > +=C2=A0=C2=A0 ;; devices. > =C2=A0=C2=A0=C2=A0 (group "audio") > =C2=A0=C2=A0=C2=A0 (system? #t) > =C2=A0=C2=A0=C2=A0 (comment "Music Player Daemon (MPD) user") > @@ -208,10 +211,17 @@ (define (mpd-serialize-port field-name value) > =C2=A0 > =C2=A0(define-maybe port (prefix mpd-)) > =C2=A0 > -;;; Procedures for unsupported value types, to be removed. > - > +;;; Sanitizer procedures. > =C2=A0(define (mpd-user-sanitizer value) > -=C2=A0 (cond ((user-account? value) value) > +=C2=A0 (cond ((user-account? value) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (match-record value > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (group supp= lementary-groups) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (unless (or= (string=3D? "audio" group) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (member "audio= " supplementary-groups)) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= ;; Being in the "audio" group is necessary for access > to the > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= ;; sound devices. > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= (warning (G_ "mpd user not member of \"audio\" > group~%")))) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 value) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ((string? value) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (warning (G_ "stri= ng value for 'user' is deprecated, use \ > =C2=A0user-account instead~%")) I think this check is "only" required when using alsa/pulseaudio for outputs and should be a hard error then. When configured to write to httpd or null outputs, other checks are needed. Cheers