From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH] gnu: Add p7zip.
Date: Tue, 02 Aug 2016 13:38:17 -0500
Message-ID: <20ae08af155acdc7edd02b68afb9e66d@openmailbox.org>
References: <87a8gwxa9c.fsf@openmailbox.org> <87y44f4plm.fsf@mdc-berlin.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39256)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1bUeaE-00075f-MT
	for guix-devel@gnu.org; Tue, 02 Aug 2016 14:38:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1bUeaD-0005E2-Qb
	for guix-devel@gnu.org; Tue, 02 Aug 2016 14:38:30 -0400
In-Reply-To: <87y44f4plm.fsf@mdc-berlin.de>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org, Guix-devel <guix-devel-bounces+ericbavier=openmailbox.org@gnu.org>

On 2016-08-02 02:06, Ricardo Wurmus wrote:
> Hi Kei,
>=20
>> This patch should install p7zip correctly on every architecture
>> supported by Guix. Ideally, this should be tested it on each arch for
>> the sake of completeness and safety. I've got x86_64 covered so far.=20
>> :-)
>=20
> thank you for this patch!
>=20
> I see that you took care of removing non-free parts in a patch and a
> build phase.  Since =E2=80=9Cguix build -S p7zip=E2=80=9D doesn=E2=80=99=
t run the build phase
> users would still end up with a source archive containing the non-free
> parts.  The best way is thus to remove things in a snippet.
>=20
> In =E2=80=9Cshogun=E2=80=9D from the =E2=80=9Cmachine-learning=E2=80=9D=
 module we remove supporting=20
> code
> for non-free features in a snippet by cutting out anything between some
> ifdef markers, but looking at the patch I see that it wouldn=E2=80=99t =
be
> feasible for p7zip.

Also note that it is not completely desirable for nonfree code to be=20
removed with a patch, and is one of the reasons Guix supports snippets=20
in the first place.

In this case, I don't think we need to go as far as removing mentions of=20
unRAR in the ChangeLog.

--=20
`~Eric