* [bug#28561] Add gnome-clocks
@ 2017-09-23 3:35 Mohammed Sadiq
2017-09-23 3:49 ` Mohammed Sadiq
[not found] ` <handler.28561.D28561.15061842884303.notifdone@debbugs.gnu.org>
0 siblings, 2 replies; 5+ messages in thread
From: Mohammed Sadiq @ 2017-09-23 3:35 UTC (permalink / raw)
To: 28561
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: 0001-gnu-libgweather-Enable-vala-support.patch --]
[-- Type: text/x-patch, Size: 1758 bytes --]
From 5d0f93a67a221e9a331405fad9322f4fb0ab6991 Mon Sep 17 00:00:00 2001
From: Mohammed Sadiq <sadiq@sadiqpk.org>
Date: Fri, 22 Sep 2017 21:28:53 +0530
Subject: [PATCH 1/3] gnu: libgweather: Enable vala support.
* gnu/packages/gnome.scm (libgweather)[native-inputs]: Add vala.
(libgweather)[arguments]: Install vala bindings into out.
---
gnu/packages/gnome.scm | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index bee1f3bc9..ebfc844aa 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -26,6 +26,7 @@
;;; Copyright © 2017 Hartmut Goebel <h.goebel@crazy-compilers.com>
;;; Copyright © 2017 nee <nee-git@hidamari.blue>
;;; Copyright © 2017 Chris Marusich <cmmarusich@gmail.com>
+;;; Copyright © 2017 Mohammed Sadiq <sadiq@sadiqpk.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2963,11 +2964,20 @@ service via the system message bus.")
(substitute* "data/Locations.xml"
(("Asia/Rangoon")
"Asia/Yangon"))
- #t)))))
+ #t))
+ (replace 'install
+ (lambda _
+ (zero?
+ (system* "make"
+ ;; Install vala bindings into $out.
+ (string-append "vapidir=" %output
+ "/share/vala/vapi")
+ "install")))))))
(native-inputs
`(("glib:bin" ,glib "bin") ; for glib-mkenums
("gobject-introspection" ,gobject-introspection)
("pkg-config" ,pkg-config)
+ ("vala" ,vala)
("intltool" ,intltool)))
(propagated-inputs
;; gweather-3.0.pc refers to GTK+, GDK-Pixbuf, GLib/GObject, libxml, and
--
2.14.1
[-- Attachment #3: 0002-gnu-Add-gsound.patch --]
[-- Type: text/x-patch, Size: 1809 bytes --]
From c58d6ac5feceecee26a258145a06fd39a6d3f0c8 Mon Sep 17 00:00:00 2001
From: Mohammed Sadiq <sadiq@sadiqpk.org>
Date: Fri, 22 Sep 2017 21:29:34 +0530
Subject: [PATCH 2/3] gnu: Add gsound.
* gnu/packages/gnome.scm (gsound): New public variable.
---
gnu/packages/gnome.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index ebfc844aa..336a5f329 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5967,6 +5967,34 @@ specified duration and save it as a GIF encoded animated image file.")
(home-page "https://git.gnome.org/browse/byzanz")
(license license:gpl2+))))
+(define-public gsound
+ (package
+ (name "gsound")
+ (version "1.0.2")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0lwfwx2c99qrp08pfaj59pks5dphsnxjgrxyadz065d8xqqgza5v"))))
+ (build-system glib-or-gtk-build-system)
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("gobject-introspection" ,gobject-introspection)
+ ("vala" ,vala)))
+ (inputs
+ `(("glib" ,glib)
+ ("libcanberra" ,libcanberra)))
+ (home-page "https://wiki.gnome.org/Projects/GSound")
+ (synopsis "GObject wrapper for libcanberra")
+ (description
+ "GSound is a small library for playing system sounds. It's designed to be
+used via GObject Introspection, and is a thin wrapper around the libcanberra C
+library.")
+ (license license:lgpl2.1+)))
+
(define-public libzapojit
(package
(name "libzapojit")
--
2.14.1
[-- Attachment #4: 0003-gnu-Add-gnome-clocks.patch --]
[-- Type: text/x-patch, Size: 2473 bytes --]
From 907a4a7ba7458062cd9097cfc36147b0376b410b Mon Sep 17 00:00:00 2001
From: Mohammed Sadiq <sadiq@sadiqpk.org>
Date: Fri, 22 Sep 2017 21:38:44 +0530
Subject: [PATCH 3/3] gnu: Add gnome-clocks.
* gnu/packages/gnome.scm (gnome-clocks): New public variable.
---
gnu/packages/gnome.scm | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 336a5f329..8c752298b 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -52,6 +52,7 @@
#:use-module (guix build-system cmake)
#:use-module (guix build-system gnu)
#:use-module (guix build-system glib-or-gtk)
+ #:use-module (guix build-system meson)
#:use-module (guix build-system trivial)
#:use-module (gnu packages)
#:use-module (gnu packages admin)
@@ -6023,6 +6024,44 @@ library.")
Microsoft SkyDrive and Hotmail, using their REST protocols.")
(license license:lgpl2.1+)))
+(define-public gnome-clocks
+ (package
+ (name "gnome-clocks")
+ (version "3.26.0")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "00a5bqi1hbyb9kbl4p393l1g6rddl2y6ljxjby9c5j3k1qka0c0g"))))
+ (build-system meson-build-system)
+ (arguments
+ '(#:glib-or-gtk? #t))
+ (native-inputs
+ `(("vala" ,vala)
+ ("pkg-config" ,pkg-config)
+ ("glib" ,glib "bin") ; for glib-compile-resources
+ ("gtk+-bin" ,gtk+ "bin") ; for gtk-update-icon-cache
+ ("desktop-file-utils" ,desktop-file-utils)
+ ("gettext" ,gettext-minimal)
+ ("itstool" ,itstool)))
+ (inputs
+ `(("glib" ,glib)
+ ("gtk+" ,gtk+)
+ ("gsound" ,gsound)
+ ("geoclue" ,geoclue)
+ ("geocode-glib" ,geocode-glib)
+ ("libgweather" ,libgweather)
+ ("gnome-desktop" ,gnome-desktop)))
+ (home-page "https://wiki.gnome.org/Apps/Calendar")
+ (synopsis "GNOME's calendar application")
+ (description
+ "GNOME Calendar is a simple calendar application designed to fit the GNOME
+desktop. It supports multiple calendars, monthly view and yearly view.")
+ (license license:gpl3+)))
+
(define-public gnome-calendar
(package
(name "gnome-calendar")
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#28561] Add gnome-clocks
2017-09-23 3:35 [bug#28561] Add gnome-clocks Mohammed Sadiq
@ 2017-09-23 3:49 ` Mohammed Sadiq
2017-09-23 4:17 ` Mohammed Sadiq
[not found] ` <handler.28561.D28561.15061842884303.notifdone@debbugs.gnu.org>
1 sibling, 1 reply; 5+ messages in thread
From: Mohammed Sadiq @ 2017-09-23 3:49 UTC (permalink / raw)
To: 28561
[-- Attachment #1: Type: text/plain, Size: 52 bytes --]
Forgot to update the details. Updated patch attached
[-- Attachment #2: 0003-gnu-Add-gnome-clocks.patch --]
[-- Type: text/x-patch, Size: 2468 bytes --]
From a3b48556761fb30b8f340e72de6ecb73414c1b4c Mon Sep 17 00:00:00 2001
From: Mohammed Sadiq <sadiq@sadiqpk.org>
Date: Fri, 22 Sep 2017 21:38:44 +0530
Subject: [PATCH 3/3] gnu: Add gnome-clocks.
* gnu/packages/gnome.scm (gnome-clocks): New public variable.
---
gnu/packages/gnome.scm | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 336a5f329..57b4a5715 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -52,6 +52,7 @@
#:use-module (guix build-system cmake)
#:use-module (guix build-system gnu)
#:use-module (guix build-system glib-or-gtk)
+ #:use-module (guix build-system meson)
#:use-module (guix build-system trivial)
#:use-module (gnu packages)
#:use-module (gnu packages admin)
@@ -6023,6 +6024,44 @@ library.")
Microsoft SkyDrive and Hotmail, using their REST protocols.")
(license license:lgpl2.1+)))
+(define-public gnome-clocks
+ (package
+ (name "gnome-clocks")
+ (version "3.26.0")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "00a5bqi1hbyb9kbl4p393l1g6rddl2y6ljxjby9c5j3k1qka0c0g"))))
+ (build-system meson-build-system)
+ (arguments
+ '(#:glib-or-gtk? #t))
+ (native-inputs
+ `(("vala" ,vala)
+ ("pkg-config" ,pkg-config)
+ ("glib" ,glib "bin") ; for glib-compile-resources
+ ("gtk+-bin" ,gtk+ "bin") ; for gtk-update-icon-cache
+ ("desktop-file-utils" ,desktop-file-utils)
+ ("gettext" ,gettext-minimal)
+ ("itstool" ,itstool)))
+ (inputs
+ `(("glib" ,glib)
+ ("gtk+" ,gtk+)
+ ("gsound" ,gsound)
+ ("geoclue" ,geoclue)
+ ("geocode-glib" ,geocode-glib)
+ ("libgweather" ,libgweather)
+ ("gnome-desktop" ,gnome-desktop)))
+ (home-page "https://wiki.gnome.org/Apps/Clocks")
+ (synopsis "GNOME's clock application")
+ (description
+ "GNOME Clocks is a simple clocks application designed to fit the GNOME
+desktop. It supports world clock, stop watch, alarms, and count down timer.")
+ (license license:gpl3+)))
+
(define-public gnome-calendar
(package
(name "gnome-calendar")
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#28561] Add gnome-clocks
2017-09-23 3:49 ` Mohammed Sadiq
@ 2017-09-23 4:17 ` Mohammed Sadiq
2017-09-23 16:31 ` bug#28561: " Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Mohammed Sadiq @ 2017-09-23 4:17 UTC (permalink / raw)
To: 28561
[-- Attachment #1: Type: text/plain, Size: 112 bytes --]
Sorry, a few more fixes reported by 'guix lint'.
Btw, this is my first contribution. Hope to get reviewed soon.
[-- Attachment #2: 0001-gnu-libgweather-Enable-vala-support.patch --]
[-- Type: text/x-patch, Size: 1758 bytes --]
From 5d0f93a67a221e9a331405fad9322f4fb0ab6991 Mon Sep 17 00:00:00 2001
From: Mohammed Sadiq <sadiq@sadiqpk.org>
Date: Fri, 22 Sep 2017 21:28:53 +0530
Subject: [PATCH 1/3] gnu: libgweather: Enable vala support.
* gnu/packages/gnome.scm (libgweather)[native-inputs]: Add vala.
(libgweather)[arguments]: Install vala bindings into out.
---
gnu/packages/gnome.scm | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index bee1f3bc9..ebfc844aa 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -26,6 +26,7 @@
;;; Copyright © 2017 Hartmut Goebel <h.goebel@crazy-compilers.com>
;;; Copyright © 2017 nee <nee-git@hidamari.blue>
;;; Copyright © 2017 Chris Marusich <cmmarusich@gmail.com>
+;;; Copyright © 2017 Mohammed Sadiq <sadiq@sadiqpk.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -2963,11 +2964,20 @@ service via the system message bus.")
(substitute* "data/Locations.xml"
(("Asia/Rangoon")
"Asia/Yangon"))
- #t)))))
+ #t))
+ (replace 'install
+ (lambda _
+ (zero?
+ (system* "make"
+ ;; Install vala bindings into $out.
+ (string-append "vapidir=" %output
+ "/share/vala/vapi")
+ "install")))))))
(native-inputs
`(("glib:bin" ,glib "bin") ; for glib-mkenums
("gobject-introspection" ,gobject-introspection)
("pkg-config" ,pkg-config)
+ ("vala" ,vala)
("intltool" ,intltool)))
(propagated-inputs
;; gweather-3.0.pc refers to GTK+, GDK-Pixbuf, GLib/GObject, libxml, and
--
2.14.1
[-- Attachment #3: 0002-gnu-Add-gsound.patch --]
[-- Type: text/x-patch, Size: 1810 bytes --]
From 684afe8b15baf153178e1a2d66c10f12b221ebee Mon Sep 17 00:00:00 2001
From: Mohammed Sadiq <sadiq@sadiqpk.org>
Date: Fri, 22 Sep 2017 21:29:34 +0530
Subject: [PATCH 2/3] gnu: Add gsound.
* gnu/packages/gnome.scm (gsound): New public variable.
---
gnu/packages/gnome.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index ebfc844aa..c0b5a8a41 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5967,6 +5967,34 @@ specified duration and save it as a GIF encoded animated image file.")
(home-page "https://git.gnome.org/browse/byzanz")
(license license:gpl2+))))
+(define-public gsound
+ (package
+ (name "gsound")
+ (version "1.0.2")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "0lwfwx2c99qrp08pfaj59pks5dphsnxjgrxyadz065d8xqqgza5v"))))
+ (build-system glib-or-gtk-build-system)
+ (native-inputs
+ `(("pkg-config" ,pkg-config)
+ ("gobject-introspection" ,gobject-introspection)
+ ("vala" ,vala)))
+ (inputs
+ `(("glib" ,glib)
+ ("libcanberra" ,libcanberra)))
+ (home-page "https://wiki.gnome.org/Projects/GSound")
+ (synopsis "GObject wrapper for libcanberra")
+ (description
+ "GSound is a small library for playing system sounds. It's designed to be
+used via GObject Introspection, and is a thin wrapper around the libcanberra C
+library.")
+ (license license:lgpl2.1+)))
+
(define-public libzapojit
(package
(name "libzapojit")
--
2.14.1
[-- Attachment #4: 0003-gnu-Add-gnome-clocks.patch --]
[-- Type: text/x-patch, Size: 2469 bytes --]
From d0620afbb72d340ead5546509d5cc3699c2edac6 Mon Sep 17 00:00:00 2001
From: Mohammed Sadiq <sadiq@sadiqpk.org>
Date: Fri, 22 Sep 2017 21:38:44 +0530
Subject: [PATCH 3/3] gnu: Add gnome-clocks.
* gnu/packages/gnome.scm (gnome-clocks): New public variable.
---
gnu/packages/gnome.scm | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index c0b5a8a41..838077124 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -52,6 +52,7 @@
#:use-module (guix build-system cmake)
#:use-module (guix build-system gnu)
#:use-module (guix build-system glib-or-gtk)
+ #:use-module (guix build-system meson)
#:use-module (guix build-system trivial)
#:use-module (gnu packages)
#:use-module (gnu packages admin)
@@ -6023,6 +6024,44 @@ library.")
Microsoft SkyDrive and Hotmail, using their REST protocols.")
(license license:lgpl2.1+)))
+(define-public gnome-clocks
+ (package
+ (name "gnome-clocks")
+ (version "3.26.0")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "mirror://gnome/sources/" name "/"
+ (version-major+minor version) "/"
+ name "-" version ".tar.xz"))
+ (sha256
+ (base32
+ "00a5bqi1hbyb9kbl4p393l1g6rddl2y6ljxjby9c5j3k1qka0c0g"))))
+ (build-system meson-build-system)
+ (arguments
+ '(#:glib-or-gtk? #t))
+ (native-inputs
+ `(("vala" ,vala)
+ ("pkg-config" ,pkg-config)
+ ("glib" ,glib "bin") ; for glib-compile-resources
+ ("gtk+-bin" ,gtk+ "bin") ; for gtk-update-icon-cache
+ ("desktop-file-utils" ,desktop-file-utils)
+ ("gettext" ,gettext-minimal)
+ ("itstool" ,itstool)))
+ (inputs
+ `(("glib" ,glib)
+ ("gtk+" ,gtk+)
+ ("gsound" ,gsound)
+ ("geoclue" ,geoclue)
+ ("geocode-glib" ,geocode-glib)
+ ("libgweather" ,libgweather)
+ ("gnome-desktop" ,gnome-desktop)))
+ (home-page "https://wiki.gnome.org/Apps/Clocks")
+ (synopsis "GNOME's clock application")
+ (description
+ "GNOME Clocks is a simple clocks application designed to fit the GNOME
+desktop. It supports world clock, stop watch, alarms, and count down timer.")
+ (license license:gpl3+)))
+
(define-public gnome-calendar
(package
(name "gnome-calendar")
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#28561: Add gnome-clocks
2017-09-23 4:17 ` Mohammed Sadiq
@ 2017-09-23 16:31 ` Ludovic Courtès
0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2017-09-23 16:31 UTC (permalink / raw)
To: Mohammed Sadiq; +Cc: 28561-done
Hi Mohammed,
Mohammed Sadiq <sadiq@sadiqpk.org> skribis:
> From 5d0f93a67a221e9a331405fad9322f4fb0ab6991 Mon Sep 17 00:00:00 2001
> From: Mohammed Sadiq <sadiq@sadiqpk.org>
> Date: Fri, 22 Sep 2017 21:28:53 +0530
> Subject: [PATCH 1/3] gnu: libgweather: Enable vala support.
>
> * gnu/packages/gnome.scm (libgweather)[native-inputs]: Add vala.
> (libgweather)[arguments]: Install vala bindings into out.
[...]
> From 684afe8b15baf153178e1a2d66c10f12b221ebee Mon Sep 17 00:00:00 2001
> From: Mohammed Sadiq <sadiq@sadiqpk.org>
> Date: Fri, 22 Sep 2017 21:29:34 +0530
> Subject: [PATCH 2/3] gnu: Add gsound.
>
> * gnu/packages/gnome.scm (gsound): New public variable.
[...]
> From d0620afbb72d340ead5546509d5cc3699c2edac6 Mon Sep 17 00:00:00 2001
> From: Mohammed Sadiq <sadiq@sadiqpk.org>
> Date: Fri, 22 Sep 2017 21:38:44 +0530
> Subject: [PATCH 3/3] gnu: Add gnome-clocks.
>
> * gnu/packages/gnome.scm (gnome-clocks): New public variable.
Applied all 3 patches. This first contribution is perfect. :-)
Maybe you’ll find that some packages should be added to our ‘gnome’
meta-package. Let us know.
Thank you, and welcome aboard!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#28561] closed (Re: [bug#28561] Add gnome-clocks)
[not found] ` <handler.28561.D28561.15061842884303.notifdone@debbugs.gnu.org>
@ 2017-09-24 7:28 ` Mohammed Sadiq
0 siblings, 0 replies; 5+ messages in thread
From: Mohammed Sadiq @ 2017-09-24 7:28 UTC (permalink / raw)
To: 28561
I didn't find a way to make gnome-shell optionally support gnome-clocks.
And so I didn't add that.
I don't need gnome-shell to have a propagated-input dependency on gnome-clocks.
But in case gnome-clocks is installed, gnome-shell should have access to
gnome-clocks' gsettings schema settings (The only the added clocks will be
displayed in gnome-shell dropdown). How can I do that.
And thanks for the review. :)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-24 7:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-23 3:35 [bug#28561] Add gnome-clocks Mohammed Sadiq
2017-09-23 3:49 ` Mohammed Sadiq
2017-09-23 4:17 ` Mohammed Sadiq
2017-09-23 16:31 ` bug#28561: " Ludovic Courtès
[not found] ` <handler.28561.D28561.15061842884303.notifdone@debbugs.gnu.org>
2017-09-24 7:28 ` [bug#28561] closed (Re: [bug#28561] Add gnome-clocks) Mohammed Sadiq
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.