From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id aAfJMF/Ce2dpeAEA62LTzQ:P1 (envelope-from ) for ; Mon, 06 Jan 2025 11:45:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id aAfJMF/Ce2dpeAEA62LTzQ (envelope-from ) for ; Mon, 06 Jan 2025 12:45:35 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=hHJlZWYA; dkim=fail ("headers rsa verify failed") header.d=ens-lyon.fr header.s=2024 header.b=p78L9txs; dkim=fail ("headers rsa verify failed") header.d=ens-lyon.fr header.s=2024 header.b=p78L9txs; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=ens-lyon.fr (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1736163935; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:list-id:list-help:list-unsubscribe:list-subscribe: list-post:dkim-signature; bh=ExVF8rqxMWcTIVQAKIGSYMQzB7e0Vx33Mb/ps2znjsU=; b=oiRWQEt7JT19dz++2iBstA5aV1t3lYcWcbzFR5DZimadPzv30at1j+/bNU6nEDOmUBc4mO gGjzWrIsqB6Qx1pCFGXZJmplCS5Fyz4wXI/iRw1MrIDqGqkIagqni0IZW1V7vbaePEDyDF 9cyaTMfB9ezhcummFFpsYzN3UrLWqKPY6wZqC1vk+cssC1/HNl4+Xr3lnidCB4RxwJuKnu 5Al5rDRcFThUvfzwjpQZsMN3H+MQHJVUURQpmF8KRdIIJjGAa/yXuSJjNs4uy7FMzODHPA K7IJ75HUJUO05ypnX+PjM8jEFmpJF9UUjbROp6nruJvkvOX7FsgWBXcJY6g/RA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=hHJlZWYA; dkim=fail ("headers rsa verify failed") header.d=ens-lyon.fr header.s=2024 header.b=p78L9txs; dkim=fail ("headers rsa verify failed") header.d=ens-lyon.fr header.s=2024 header.b=p78L9txs; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=ens-lyon.fr (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1736163935; a=rsa-sha256; cv=none; b=ku/7jC2oDBG1hL56JQ9FmpT3Cug1Aa33NacbLzZvtVcwqImGI5qwAoT1lzKkZakEZyOWsj yG+2xXSfuw5Q0t4vTXRAgrBX5/zGsvoJmHS8MoWp/ssxivsTi4hcZS22vpdFJvX9z7qHNC ASfy/DcYBgihLFsO1EoMaHKFb1FKlukA4WnX8vXQMz6q7/GwwbLfG6F0bCt4oyfpUyOIZE JHe3tYAXIax+D5ipzJDA43DtUcRN4M9elrP+nOO54mxoXaR3g4lCzO5/emA0u/hFfj7NsR cQDRdZdTV97wljLJfeQ0BGRbeDDopOqovbLL4pIUYdEYB7dNV1BoWTl6GDzoTw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5E7FF45A1E for ; Mon, 06 Jan 2025 12:45:34 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tUlXk-0002Yz-88; Mon, 06 Jan 2025 06:45:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUlXc-0002Wa-Bb for guix-patches@gnu.org; Mon, 06 Jan 2025 06:45:05 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUlXb-00056X-UW for guix-patches@gnu.org; Mon, 06 Jan 2025 06:45:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:From:Date:To:Subject; bh=ExVF8rqxMWcTIVQAKIGSYMQzB7e0Vx33Mb/ps2znjsU=; b=hHJlZWYAQEn79YP3LZFu7/ryim8qWdG+Ysld9TYCeeIrARWKNINETKxp2kirCi4+1jQ+phxM0ZZHLOsIWssQyq46isvnKGU6jt4ugtc5uAmICc9Nwcn5qxWgF3hqMaZENL6tQIWAAuHVgCs/uVlPM6Y8rTdM641S88Z6n+5XMCbqseCiiyrlW6t5pOcUezbs3Y0Vo4l7EpTjWPWcSfVSDLNOP4j9kRg5gDD/cJseJDu7M/JaWpDwQM9IOCr7P4MWvLOR9+wLen6SlyfaFLLG0iFKP491HrF/OSE+Fs5B/t37G3h5EnOQc6VYqtwkuVHVedUTLgVolEs3AzlX3geLHg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tUlXa-0007At-P4 for guix-patches@gnu.org; Mon, 06 Jan 2025 06:45:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#75400] [PATCH] Fixing python-spacy Resent-From: Alice BRENON Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Jan 2025 11:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75400 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75400@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173616387527512 (code B ref -1); Mon, 06 Jan 2025 11:45:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Jan 2025 11:44:35 +0000 Received: from localhost ([127.0.0.1]:37014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUlX8-00079f-Ow for submit@debbugs.gnu.org; Mon, 06 Jan 2025 06:44:35 -0500 Received: from lists.gnu.org ([2001:470:142::17]:41182) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUlX5-00079G-AP for submit@debbugs.gnu.org; Mon, 06 Jan 2025 06:44:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUlWy-0002Rq-Jv for guix-patches@gnu.org; Mon, 06 Jan 2025 06:44:24 -0500 Received: from lxc-smtp2.ens-lyon.fr ([140.77.167.81]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUlWv-00054H-Jq for guix-patches@gnu.org; Mon, 06 Jan 2025 06:44:24 -0500 Received: from localhost (localhost [127.0.0.1]) by lxc-smtp2.ens-lyon.fr (Postfix) with ESMTP id B98C1145753 for ; Mon, 6 Jan 2025 12:44:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ens-lyon.fr; s=2024; t=1736163855; bh=xiH7Or9P6TmV/BrfpZjd9jWbpdUE4ifwaUDp03NiWV0=; h=Date:From:To:Subject:From; b=p78L9txsGxDuSC9p5d86F/oeiSYM6UyydRYEF4K75NY/cibAAza6WWi+aK0I/Kgoe sv7yEZgfZVxn2LVsxc1av8uR+Gi7Oh78Y1GzTCBrcUGlEGYx5hj5t0GvXZrQ4vUp8p e+fQHQ+U3hySmJ2VliUQqJAr4fhh5Y3TmI3LA/xIRNmW8g353BUM6+LrBzUMc9hRGX UeExDjajQzr+8mttqiXTb1xRPu0C29eUlj/swWUrhyOsSOuoadYw5GxXADBXdzuHn3 5MEUGsQUgzq/y8VrLrEzRL2TcyUYKSqKGmeUZa/44TRBeySV9LHvxxetIZJG3OeX6D 6wlo9axm3930Q== X-Virus-Scanned: by amavisd-new-2.11.0 (20160426) (Debian) at ens-lyon.fr Received: from lxc-smtp2.ens-lyon.fr ([127.0.0.1]) by localhost (lxc-smtp2.ens-lyon.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YPpBw6uIOmi2 for ; Mon, 6 Jan 2025 12:44:15 +0100 (CET) Received: from localhost (dhcp-67-68.ixxi.ens-lyon.fr [140.77.67.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by lxc-smtp2.ens-lyon.fr (Postfix) with ESMTPSA id A1ECC140388 for ; Mon, 6 Jan 2025 12:44:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=ens-lyon.fr; s=2024; t=1736163855; bh=xiH7Or9P6TmV/BrfpZjd9jWbpdUE4ifwaUDp03NiWV0=; h=Date:From:To:Subject:From; b=p78L9txsGxDuSC9p5d86F/oeiSYM6UyydRYEF4K75NY/cibAAza6WWi+aK0I/Kgoe sv7yEZgfZVxn2LVsxc1av8uR+Gi7Oh78Y1GzTCBrcUGlEGYx5hj5t0GvXZrQ4vUp8p e+fQHQ+U3hySmJ2VliUQqJAr4fhh5Y3TmI3LA/xIRNmW8g353BUM6+LrBzUMc9hRGX UeExDjajQzr+8mttqiXTb1xRPu0C29eUlj/swWUrhyOsSOuoadYw5GxXADBXdzuHn3 5MEUGsQUgzq/y8VrLrEzRL2TcyUYKSqKGmeUZa/44TRBeySV9LHvxxetIZJG3OeX6D 6wlo9axm3930Q== Date: Mon, 6 Jan 2025 12:44:14 +0100 From: Alice BRENON Message-ID: <20250106124414.7861f9b8@ens-lyon.fr> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/WIle2chhq6j4hF1jjIUpwVM" Received-SPF: pass client-ip=140.77.167.81; envelope-from=alice.brenon@ens-lyon.fr; helo=lxc-smtp2.ens-lyon.fr X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -0.64 X-Spam-Score: -0.64 X-Migadu-Queue-Id: 5E7FF45A1E X-TUID: Q9rsNVadCRf6 --MP_/WIle2chhq6j4hF1jjIUpwVM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi all, The package `python-spacy` seems to have been broken at least partially by = the recent changes in python tooling. The attached patch is a very short first = step into fixing it. This message doesn't hope to get it accepted but is rather = meant to open the discussion on the topic. - the first issue is naturally the new required dependencies in `native-inp= uts` mentioned in bdde278dc9c565d8e9d11427c3a670ba86808af5 an visible in many python packages commit these past weeks. Surprisingly, I managed to compi= le `python-spacy` by adding only `python-wheel`, without `python-setuptools`. What makes both required? Are we sure that both were required in each and every python package recently modified? - the second issue which I can't link with the changes in our tooling is ca= used by two packages which tests have broken: `python-aws-xray-sdk` and `python-jose`. First one seems to have a problem in sqlalchemy version (it seems to be using too recent a syntax; which is weird considering the fact that it uses version 2 and that it used to work =E2=80=94 `python-aws-xra= y-sdk` hasn't been modified since cec543e7 on april the 27th 2023!). Second one now has trouble checking several certificates for mere formatting reasons (expect= ed and actual PEMs are almost the same, only newlines are different; fixing = the code of the test itself, another one breaks somewhere else. It seems that these source codes aren't sturdy enough and don't work at all in the pack= age environment guix provides. - these packages are dependencies of `python-moto`. Removing them from the dependencies, many tests break as expected for lack of these modules, but disabling them isn't enough: I played a game of whack-a-mole yesterday tr= ying to get the tests to pass. Strangely, whereas testing with hypothesis runs= all the tests and then reports all that have failed, fixing the one reported = and running the tests again doesn't help: new tests break in different files = that were apparently fine before=E2=80=A6 I had three iterations of this proce= ss, each one consuming half and hour on my machine. As far as I am concerned, these te= sts are unreliable and don't bring any additional confidence to the package. I have disabled them to test the fix for `python-spacy` and have been able = to compile it and use the package. Appart from that, everything looks ok. `python-moto` appears as a dependenc= y of `python-smart-open` which itself is both a direct dependency of `python-spa= cy` and a dependency of `python-pathy` which is also a dependency of `python-sp= acy`. python-smart-open -> python-moto python-pathy -> python-smart-open python-spacy -> python-smart-open, python-pathy I understand that disabling the tests on a package entirely isn't a very so= und practice for a distribution so I doubt this is an acceptable fix. As I understand the situation the next steps will be to sort things between `python-aws-xray-sdk` and `python-sqlalchemy` and to understand why the tes= ts in `python-jose` have suddenly broken so bad. Best, Alice --MP_/WIle2chhq6j4hF1jjIUpwVM Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-gnu-python-spacy-Fix-build.patch >From 9a349ac01cec33fc1e49ba7f80ae18ef5cfdf922 Mon Sep 17 00:00:00 2001 Message-ID: <9a349ac01cec33fc1e49ba7f80ae18ef5cfdf922.1736155491.git.alice.brenon@ens-lyon.fr> From: Alice BRENON Date: Sat, 4 Jan 2025 23:01:50 +0100 Subject: [PATCH] gnu: python-spacy: Fix build. * gnu/packages/machine-learning.scm (python-spacy): Fix build. [native-inputs]: Add python-wheel Change-Id: I6550f6dc0cb1fb88fc733f6471f1831c4ba95977 --- gnu/packages/machine-learning.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/machine-learning.scm b/gnu/packages/machine-learning.scm index c7d336b8b3..1617ef917e 100644 --- a/gnu/packages/machine-learning.scm +++ b/gnu/packages/machine-learning.scm @@ -1282,7 +1282,7 @@ (define-public python-spacy python-typing-extensions python-wasabi)) (native-inputs - (list python-cython python-pytest python-mock)) + (list python-cython python-pytest python-mock python-wheel)) (home-page "https://spacy.io") (synopsis "Natural Language Processing (NLP) in Python") (description base-commit: 7a7c01b393ecb20dff142b9ea9bf8317e994bef2 -- 2.47.1 --MP_/WIle2chhq6j4hF1jjIUpwVM--