[bug#75101] [PATCH 0/2] Fix broken Retroarch while respecting FSDG

[bug#75101] [PATCH 0/2] Fix broken Retroarch while respecting FSDG

[Andrew Wong via Guix-patches via]

Retroarch's ability to download "cores" (libraries) to userspace was removed
recently because of non-free cores being available. However, I have found a
more sensible solution which enables the free-licensed cores (which make up
the majority of the list) to still be downloaded. All that is needed is for
the entries for nonfree cores in the retroarch-core-info package to be
removed; without these entries, Retroarch cannot download or update the
nonfree cores, and the FSDG are respected while keeping the software usable.

Andrew Wong (2):
  gnu: retroarch-core-info: Remove non-free core listings.
  gnu: retroarch-minimal: Enable core downloading with limited core
    info.

 gnu/packages/emulators.scm | 59 +++++++++++++++++++++++++++-----------
 1 file changed, 42 insertions(+), 17 deletions(-)

-- 
2.46.0

[bug#75101] [PATCH 1/2] gnu: retroarch-core-info: Remove non-free core listings.

[Andrew Wong via Guix-patches via]

Change-Id: Ic6f656dac299080eaa097df5375dd23b96966cfb
---
 gnu/packages/emulators.scm | 54 +++++++++++++++++++++++++++++---------
 1 file changed, 42 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index ab3f28cfae..75d924253c 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -1584,22 +1584,52 @@ (define-public retroarch-core-info
     (package
       (name "retroarch-core-info")
       (version (git-version "1.19.0" revision commit))
-      (source (origin
-                (method git-fetch)
-                (uri (git-reference
-                      (url "https://github.com/libretro/libretro-core-info")
-                      (commit commit)))
-                (file-name (git-file-name name version))
-                (sha256
-                 (base32
-                  "11xpy3zhy2smp4a70fc0r1b76mvmjyabkaaipifsxm3j25drki5z"))))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/libretro/libretro-core-info")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "11xpy3zhy2smp4a70fc0r1b76mvmjyabkaaipifsxm3j25drki5z"))
+         (modules '((guix build utils)))
+         (snippet '(begin
+                     (for-each delete-file
+                               ;; incompatibly-licensed cores are
+                               ;; removed. When updating check the "license"
+                               ;; line of each file.
+                               '("duckstation_libretro.info"
+                                 "dinothawr_libretro.info"
+                                 "chimerasnes_libretro.info"
+                                 "cannonball_libretro.info"
+                                 "fmsx_libretro.info"
+                                 "fbalpha2012_cps3_libretro.info"
+                                 "fbalpha2012_cps2_libretro.info"
+                                 "fbalpha2012_cps1_libretro.info"
+                                 "mame2003_plus_libretro.info"
+                                 "fbneo_libretro.info"
+                                 "fbalpha2012_neogeo_libretro.info"
+                                 "fbalpha2012_libretro.info"
+                                 "mu_libretro.info"
+                                 "genesis_plus_gx_wide_libretro.info"
+                                 "genesis_plus_gx_libretro.info"
+                                 "opera_libretro.info"
+                                 "snes9x2005_plus_libretro.info"
+                                 "snes9x_libretro.info"
+                                 "px68k_libretro.info"
+                                 "snes9x2005_libretro.info"
+                                 "snes9x2010_libretro.info"
+                                 "snes9x2002_libretro.info"))))))
       (build-system copy-build-system)
       (arguments
-       (list #:install-plan #~'(("." "lib/libretro/"
-                                 #:include-regexp ("\\.info$")))))
+       (list
+        #:install-plan #~'(("." "lib/libretro/"
+                            #:include-regexp ("\\.info$")))))
       (home-page "https://github.com/libretro/libretro-core-info")
       (synopsis "Libretro core info files")
-      (description "This is a versioned snapshot of the files containing
+      (description
+       "This is a versioned snapshot of the files containing
 metadata about each known libretro core.  The snapshot is taken from the
 @url{https://github.com/libretro/libretro-super, libretro-super} repository.")
       (license license:expat))))
-- 
2.46.0

[bug#75101] [PATCH 2/2] gnu: retroarch-minimal: Enable core downloading with limited core info.

[Andrew Wong via Guix-patches via]

Change-Id: I5087bed9c7fd1747df6dd7debc7e606ab3aeb73c
---
 gnu/packages/emulators.scm | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index 75d924253c..2060b14ec3 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -2441,11 +2441,6 @@ (define (directory? x)
                  ;; D-Bus support is required for 'suspend screensaver' option
                  ;; to work.
                  "--enable-dbus"
-                 ;; Non-free software are available through the core updater,
-                 ;; disable it.  See <https://issues.guix.gnu.org/38360>.
-                 "--disable-update_cores"
-                 "--disable-update_core_info"
-                 "--disable-online_updater"
                  ;; The assets are provided via the `retroarch-assets' package.
                  "--disable-update_assets"
                  "--disable-builtinmbedtls"
-- 
2.46.0