[bug#74778] [PATCH] gnu: linux-libre: Enable simpledrm driver.

[bug#74778] [PATCH] gnu: linux-libre: Enable simpledrm driver.

[Homo via Guix-patches via]

Without it GDM and Wayland don't work on unsupported GPUs.

Change-Id: Id3bf1e890fee527ef8a24243a2f642271877b5c2
---
 gnu/packages/linux.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 62d6f0adb9..7d374456bd 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -894,6 +894,12 @@ (define (default-extra-linux-options version)
     ("CONFIG_MEMCG_KMEM" . #t)
     ("CONFIG_CPUSETS" . #t)
     ("CONFIG_PROC_PID_CPUSET" . #t)
+    ;; Allow GDM and Wayland on unsupported GPUs.
+    ("CONFIG_DRM" . #t)
+    ("CONFIG_DRM_SIMPLEDRM" . #t)
+    ("CONFIG_SYSFB_SIMPLEFB" . #t)
+    ("CONFIG_FB_EFI" . #f)
+    ("CONFIG_FB_SIMPLE" . #f)
     ;; Allow disk encryption by default
     ("CONFIG_DM_CRYPT" . m)
     ;; Support zram on all kernel configs
-- 
2.46.0

[bug#74778] [PATCH v2] gnu: linux-libre: Enable simpledrm driver.

[Homo via Guix-patches via]

Without it GDM and Wayland don't work on unsupported GPUs.

Fixes <https://issues.guix.gnu.org/74390>

* gnu/packages/linux.scm (default-extra-linux-options): Enable
CONFIG_DRM, CONFIG_DRM_SIMPLEDRM and CONFIG_SYSFS_SIMPLEFB.
Disable CONFIG_FB_EFI and CONFIG_FB_SIMPLE.

Change-Id: Id4e8d595d56416581e1be5093a224a19cc2d3dfb
---
Changed commit log.

 gnu/packages/linux.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 0fc2c4428a..67bcc5e6db 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -894,6 +894,12 @@ (define (default-extra-linux-options version)
     ("CONFIG_MEMCG_KMEM" . #t)
     ("CONFIG_CPUSETS" . #t)
     ("CONFIG_PROC_PID_CPUSET" . #t)
+    ;; Allow GDM and Wayland on unsupported GPUs.
+    ("CONFIG_DRM" . #t)
+    ("CONFIG_DRM_SIMPLEDRM" . #t)
+    ("CONFIG_SYSFB_SIMPLEFB" . #t)
+    ("CONFIG_FB_EFI" . #f)
+    ("CONFIG_FB_SIMPLE" . #f)
     ;; Allow disk encryption by default
     ("CONFIG_DM_CRYPT" . m)
     ;; Support zram on all kernel configs
-- 
2.46.0

[bug#74778] [PATCH v3] gnu: linux-libre: Enable simpledrm driver.

[Homo via Guix-patches via]

Without it GDM and Wayland don't work on unsupported GPUs.

Fixes <https://issues.guix.gnu.org/74390>

* gnu/packages/linux.scm (default-extra-linux-options): Enable
CONFIG_DRM, CONFIG_DRM_SIMPLEDRM and CONFIG_SYSFB_SIMPLEFB.
Disable CONFIG_FB_EFI and CONFIG_FB_SIMPLE.

Change-Id: I4e4adca508875e25faa09ef51d6cb325e27ce328
---
Corrected typo mistake in log message
s/CONFIG_SYSFS_SIMPLEFB/CONFIG_SYSFB_SIMPLEFB/

 gnu/packages/linux.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 0fc2c4428a..67bcc5e6db 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -894,6 +894,12 @@ (define (default-extra-linux-options version)
     ("CONFIG_MEMCG_KMEM" . #t)
     ("CONFIG_CPUSETS" . #t)
     ("CONFIG_PROC_PID_CPUSET" . #t)
+    ;; Allow GDM and Wayland on unsupported GPUs.
+    ("CONFIG_DRM" . #t)
+    ("CONFIG_DRM_SIMPLEDRM" . #t)
+    ("CONFIG_SYSFB_SIMPLEFB" . #t)
+    ("CONFIG_FB_EFI" . #f)
+    ("CONFIG_FB_SIMPLE" . #f)
     ;; Allow disk encryption by default
     ("CONFIG_DM_CRYPT" . m)
     ;; Support zram on all kernel configs
-- 
2.46.0

[bug#74778] [PATCH v3] gnu: linux-libre: Enable simpledrm driver.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

On Tue, Dec 17, 2024 at 02:14:00PM +0200, Homo via Guix-patches via wrote:
> Without it GDM and Wayland don't work on unsupported GPUs.
> 
> Fixes <https://issues.guix.gnu.org/74390>
> 
> * gnu/packages/linux.scm (default-extra-linux-options): Enable
> CONFIG_DRM, CONFIG_DRM_SIMPLEDRM and CONFIG_SYSFB_SIMPLEFB.
> Disable CONFIG_FB_EFI and CONFIG_FB_SIMPLE.

Hi, thanks for looking into this problem and sending a patch!

I've pushed it to the 'kernel-updates' branch on Savannah, so that
ci.guix.gnu.org will build affected packages:

https://ci.guix.gnu.org/eval/1954549

Once the relevant kernel packages are built, people can test the change
with Guix time-machine, like so:

$ guix time-machine --commit=0bdfe09560bef85d5145f431ee3c9e7907652630 -- system reconfigure $OS_CONFIG_FILE

If your system has been upgraded past the previous master branch commit,
Guix will refuse to use this alternate history, even though it is signed
properly by my key, but you can disable the code-signing authentication
like this:

$ guix time-machine --commit=0bdfe09560bef85d5145f431ee3c9e7907652630 --allow-downgrades -- system reconfigure --allow-downgrades $OS_CONFIG_FILE

I'll test it on my headless machine, but it would be great if some other
people could make sure their systems still work with this change.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#74778] [PATCH v3] gnu: linux-libre: Enable simpledrm driver.

[gay--- via Guix-patches via]

Hi,

It's important to note that I made this change following this 
documentation 
<https://fedoraproject.org/wiki/Changes/ReplaceFbdevDrivers>

I'm sorry for not being careful, just now I paid extra attention that 
kernels older than 5.14 might be broken on someones' computers, so I 
guess it's necessary to add check for kernel version even if older 
kernels are built without throwing errors.

[bug#74778] [PATCH v3] gnu: linux-libre: Enable simpledrm driver.

[Leo Famulari]

On Wed, Jan 01, 2025 at 05:36:05AM +0000, gay@disroot.org wrote:
> It's important to note that I made this change following this documentation
> <https://fedoraproject.org/wiki/Changes/ReplaceFbdevDrivers>
> 
> I'm sorry for not being careful, just now I paid extra attention that
> kernels older than 5.14 might be broken on someones' computers, so I guess
> it's necessary to add check for kernel version even if older kernels are
> built without throwing errors.

Okay, thanks for bringing this up! I am a person that has to use an
older kernel because suspend no longer works reliably on my laptop in
the newer release series.

Stepping back, as Tobias brings up, this DRM issue is kind of tricky
overall. We've been down this road previously and didn't find a good
solution for everyone.

Let's identify some test cases that we need to satisfy regarding this
subject. I like to use the OS declaration examples found here:

https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/system/examples

Specifically, I've used the desktop and lightweight-desktop examples.
Do I understand correctly that both of them create desktops based on
Xorg and not Wayland?

Do we have a wayland-desktop test case that we can use? Does the
gdm-wayland system test help us here?

We'll need to test operation on all the kernel versions, for both X and
Wayland, on x86_64. If anyone wants to help test on aarch64, please
chime in.

[bug#74778] [PATCH v3] gnu: linux-libre: Enable simpledrm driver.

[gay--- via Guix-patches via]

Yes, those examples don't include Wayland.

Default %desktop-services provides GDM, even though by-default it is 
Wayland, changing it to use X11 doesn't drop /dev/dri requirement, I 
already tried.

When I sent this patch, I was still using both GDM and GNOME on Wayland 
(a default provided by installer), but now I use wlgreet-greetd and 
Sway.

Looking at those examples, does it mean I just copy my /etc/config.csm 
as gnu/system/examples/wlgreet-sway.tmpl?

[bug#74778] [PATCH v3] gnu: linux-libre: Enable simpledrm driver.

[Leo Famulari]

On Thu, Jan 02, 2025 at 05:52:46AM +0000, gay@disroot.org wrote:
> Yes, those examples don't include Wayland.

Okay, thanks for confirming.

> Looking at those examples, does it mean I just copy my /etc/config.csm as
> gnu/system/examples/wlgreet-sway.tmpl?

I think you could just copy the services. The packages could be the
minimal packages to boot and log in to the system. The filesystems,
bootloader, and user accounts could be adapted from the other examples.

Let me know if you want some help.

[bug#74778] [PATCH v3] gnu: linux-libre: Enable simpledrm driver.

[Tobias Geerinckx-Rice via Guix-patches via]

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

Happy newest year, all!

Polite nack.  Let's not make these same changes yet again without 
better documenting our chosen combination and any accepted 
trade-offs.

Otherwise, some frustratingly obtuse half-wit's only going to 
revert them without a proper commit message to fix somebody's bug 
only to re-enable them later to fix somebody's bug, probably:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=1dfe8c372163d481ebebb97dd3b4cafa49906b28
  …
  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=6d7e181ba18d11c92409a93936025fb46b9c8171
  …
  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=e49fdc231b0be00490fe1321888eb5c2acc480ac

I'll try to find the context for my reversion in my own logs, but 
it surely broke something.  There may be no way to support all 
users.

I do urge people to test it on kernel-updates, but this is not a 
simple ‘enable CONFIG_FOOBLES to get foobles!’ situation.

Aside: why do we keep adding DEFAULT-EXTRA-LINUX-OPTIONS instead 
of modifying the configuration files themselves?  Maybe this is a 
separate discussion.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

[bug#74778] [PATCH v3] gnu: linux-libre: Enable simpledrm driver.

[Leo Famulari]

On Wed, Jan 01, 2025 at 04:27:41PM +0100, Tobias Geerinckx-Rice wrote:
> Polite nack.

[...]

> I'll try to find the context for my reversion in my own logs, but it surely
> broke something.  There may be no way to support all users.

Thanks for chiming in Tobias. I thought these options sounded familiar
and hoped it wasn't a rehash of this old issue. I do seem to remember
that we had, basically, traded one form of breakage for another.

> Aside: why do we keep adding DEFAULT-EXTRA-LINUX-OPTIONS instead of
> modifying the configuration files themselves?  Maybe this is a separate
> discussion.

I think that modifying the config files is better because, while doing
so, the combination of options is properly set by the kernel
configuration machinery and, at the end of the process, we have a
config that can be inspected to check for a sensible outcome.

On the other hand, if we use the Scheme machinery, the final config file
is only created while building the kernel packages and we are less
likely to inspect it. Of course it's still possible to inspect
regardless of which method is used.

I'd suggest only using the Scheme interface to correct FSDG issues and
serious problems like that.

But, in a related aside where I zoom further out, we need more people
involved with the kernel packaging in order to get a really optimal
result. So I'm not too picky about details like this.