From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id aE+UIrSOH2czMwAAqHPOHw:P1 (envelope-from ) for ; Mon, 28 Oct 2024 13:16:36 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id aE+UIrSOH2czMwAAqHPOHw (envelope-from ) for ; Mon, 28 Oct 2024 14:16:36 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=VzB8GLzi; dkim=fail ("headers rsa verify failed") header.d=cyberdimension.org header.s=dkim header.b="P3nJyn/i"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1730121396; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=JPCBUg6Nq1Gf4i+h6cpzlv3dPaEXS8TB4rw0LOmIQZs=; b=ALp3jSIuk4fdmAlmHJTXmlbB0bFgRb6fneC7IhOrJcv7DrtGmt4vQhUKdhNhvCHIFo1R4/ m7CAC64B1CwJfaZKMYRNyaWeeBOd1YzHVgzNobM4R/9uX6V6Vleuryzwueb79oMCaSPGaz +bllpIs9daxw8fZS3IJUk2xD7tbGkYOKZh/q5MKF0Ze+PWGSxBxpMtaY8kOKCd5K/BGFn8 brk+jRpCXzW2VKi3Q0KcTTD5E359oyc46bV6/1f6EKisN10DLe4hYHf+j2RFmDtazOHRO+ LK2HnkABahKaSwVR7iPSUKF0uBDCRGR5oDy6O9zborikLQ4GC9DmUbxuPIIKxg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=VzB8GLzi; dkim=fail ("headers rsa verify failed") header.d=cyberdimension.org header.s=dkim header.b="P3nJyn/i"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1730121396; a=rsa-sha256; cv=none; b=TJtMZIAKaPmjZBrBMjEbVsFOhTOwzeHfLo9qAETJVylbSNpeup0A9z+8hzpMufc7wyYSqa Z9XQ42F8+QrfH7q2XOHNDnlIpxedNwzW+PFoi+845QBBiZ3RHNNwwfCaKsqyj6dsGcxtiF wxUK0QigXI0wyCsOXCScWxGguKeR6dsO36WQH26dylTyvU3kGjPKiasomSJR7OXNA+Vr9n hP7ZWVrHSOp0ZlvK6D1Vt1vUAV4KKPPwahRvuCchQEP9Lggh4Vy8c74/uyEvUpmaruASXQ AxtP0DGN01F6tX3QFUK9X0BHCwM1TbbttecLD9ybIPeL2xupTu31JX0np6Tzqw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CBBD887825 for ; Mon, 28 Oct 2024 14:16:35 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t5Pbg-0002Se-VH; Mon, 28 Oct 2024 09:16:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t5Pbe-0002SN-BI for guix-patches@gnu.org; Mon, 28 Oct 2024 09:16:26 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t5Pbd-00020O-SB for guix-patches@gnu.org; Mon, 28 Oct 2024 09:16:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=JPCBUg6Nq1Gf4i+h6cpzlv3dPaEXS8TB4rw0LOmIQZs=; b=VzB8GLziXeq9/fzqehSC7e0IAGayN2uHtiQ0jgjwM+9JxhiuLSt+UsfFOSEmXj0/qStc7sEk4pkoh9ibggugZVqpXg5ZTQa31dgb7h5Aj1vkA9LAzVvPid6PREyy2IhbtRrOivCjn1FEGMcZBPdquDDNz+ejLlqUDhafRDkNb9x0m5jzbmtJ6r1MHEkJtH7+85z0uDRl4D5OwgazIk6io1ynzJk3mrdPT/0p384x8lQs1GPtujg/1VBiYwCwMYhL6cI0jub7jJIzHStRuj6Lfgdv3P0dt/kAuSF7U46w67VUCJw5UWbzZYyCwoJ8yUYsD++mBW+k7p7ouC+0dvC6Ug==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t5PcD-00081O-Sa for guix-patches@gnu.org; Mon, 28 Oct 2024 09:17:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#74049] [PATCH v1] gnu: matterbridge: Unbundle most golang.org dependencies. Resent-From: Denis 'GNUtoo' Carikli Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Oct 2024 13:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74049 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sharlatan Hellseher Cc: 74049@debbugs.gnu.org Received: via spool by 74049-submit@debbugs.gnu.org id=B74049.173012136330733 (code B ref 74049); Mon, 28 Oct 2024 13:17:01 +0000 Received: (at 74049) by debbugs.gnu.org; 28 Oct 2024 13:16:03 +0000 Received: from localhost ([127.0.0.1]:52920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5PbH-0007zc-2B for submit@debbugs.gnu.org; Mon, 28 Oct 2024 09:16:03 -0400 Received: from cyberdimension.org ([79.143.250.36]:41344 helo=rockpro64.cyberdimension.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t5PbD-0007z7-E4 for 74049@debbugs.gnu.org; Mon, 28 Oct 2024 09:16:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=dkim; bh=h6+biB4EOrxoWf3 mQRgSayrGDNo6p6YnuuCHVEkoTV8=; h=references:in-reply-to:subject:cc:to: from:date; d=cyberdimension.org; b=P3nJyn/i1dKdi7OMMf2uX4UcvGEA9KKR4Tj WAQ6zfxUAkXDeCTGjsJwlLUSlr65h2PO4fvd2pdJm/HEqVgqcG0UNTRgmb8L9419VuIvQz VPyKtwtgoNPu8QtTX1SeB6rNq5r9/qi75u97uOoouRh2+lZGlUO+bLevbAMck7cFS9LshB xyOCkokEVJLBlDOWgFwq1n6q6uzWZtoOjlsodQoV7daKYJ0GljIBq88TUVzEIXNuW6h+ba 0sZFPjkZecd+PZkQ2rnrVF9TdahQCX2guHLi3ndJRpsJH6jM4GhpzinjpfrE8iB27ktPUq hVGpA+kxLevk4dVlEtl8HAZ/pQA== Received: from primarylaptop.localdomain (localhost [127.0.0.1]) by rockpro64.cyberdimension.org (OpenSMTPD) with ESMTP id 4bdeb902; Mon, 28 Oct 2024 13:15:18 +0000 (UTC) Date: Mon, 28 Oct 2024 14:00:01 +0100 From: Denis 'GNUtoo' Carikli Message-ID: <20241028140001.1d996969@primarylaptop.localdomain> In-Reply-To: <87iktduwbo.fsf@gmail.com> References: <87iktduwbo.fsf@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/mVHXOzM/sN//9tgH604Z0rU"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -3.74 X-Spam-Score: -3.74 X-Migadu-Queue-Id: CBBD887825 X-TUID: wFUn9ry4gcj+ --Sig_/mVHXOzM/sN//9tgH604Z0rU Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 27 Oct 2024 20:26:03 +0000 Sharlatan Hellseher wrote: > Thanks for the initiation of unbundeling process for materbridge! Thanks a lot for the review. > A general comments for Golang packages which is just final binary, you > may apply "#:install-source? #f" parameter which mean do not place > source of the project into store and just move produced binary. Thanks, I'll do that in a newer patch. > Also for the final binary all build inputs may be placed to > "native-inputs" they will never be used elsewhere after the install > phase. Right, I just copied a bit what was done in the example I followed, so that might need to be fixed as well. Using inputs didn't look right to me but it was done in this way so I assumed that there was a good reason for it (I tried unbundling long time ago and it didn't work at the time, but maybe I was just unlucky). > While you are keen to unbundle let's pick up as many as we can. You > may also add some other inputs which are available already: I was already unsure about the patch I sent. In the v2 should I do it all at once in a single patch or should I split the work across multiple patches? The advantage of the former is that it becomes easier to bisect issues. The downside is that if the granularity is too small, I fear that we'll end up with hundreds of patches.=20 So I also think it's a good idea to agree on how to make these changes before doing more and more patches. For instance you could validate one patch (without necessarily pushing it) so I could use that as a blueprint for the next ones and not have to redo all the work for so many patches. Here I picked something in between where I grouped the unbundling of dependencies by selecting something they had in common, but I've no idea if it's the right way to do it. Also note that I ran the resulting binary, but without feeding it a configuration. I'll do a more complete test later on as tests are quite expensive: I need to install Guix on the production server, update it, build the matterbridge package, and uninstall guix after that to reduce the attack surface. > - filippo.io/edwards25519 > - go.uber.org/multierr > - gopkg.in/ini.v1 > - gopkg.in/natefinch/lumberjack.v2 > - gopkg.in/natefinch/lumberjack.v2 > - gopkg.in/yaml.v2 > - gopkg.in/yaml.v3 > - google.golang.org/protobuf > - github.com/hashicorp ;; all of them are available > - github.com/golang/protobuf > - github.com/fatih/color > - github.com/google/uuid > - github.com/gorilla/websocket > - github.com/pkg/errors Thanks, I found some of them like the protobuf one but I didn't add them in my patch yet. > Basically we targeting to have just the first level of dependentices > in "native-inputs" as seen in > . OK, I didn't look at that yet, I just started looking at what was in vendor/ with a script and made a patch with the group that is closer to the language (golang). > Please take a look if removing them from vendor and adding them to > native-inputs still keeps the build green. Thanks for the additional list, I'll definitely do that. Denis. --Sig_/mVHXOzM/sN//9tgH604Z0rU Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAmcfitEACgkQX138wUF3 4mODkw//eevg70/gkJxGnTZUBwasdGgEc5U1s8d2eSVOEL+uWM2SurQXLCcpxxIM a143IVYVkX0MzSbdQuXcLxc5xzd2pNio/3uVOfZulLPX5BW0LielD+ktLkwPjNC4 E8G2HNFEWA9pHjsbpEr9OliFCq74EHDjF7sVrEZar5Q7QDs315pC66QGpkEc4wll 8ly4S1ws+nGu5OpAD9kHNezUlPt9m+qO5qEBBT0+KbfC249owPP8jUXJGxjGW/mp yhbeZ0ecuuDeZLTQ6rfPPEN5Jj4OyUDcmeb9oWiD0awKRof5YzmXomb1Qdw+CRgO iNjLw4QYT+oDb/cyFlkJtrXc2iEWvoDBqgIqdivHU4Pv6plQbUoGw4uCKKVu2a29 FaYO2LnRLpJzCyTZpglKQXIQc4au7IG8VYJLyoGXTmvfbn0Ni2cs4CQL8kgUjmaL b4bLKHeV3RIFhry7zs4P0IcKyHnzCw1M3SKP1h5puzQJX0XwecYTQEK2pdpy6p3i 7zptp7dBtUXFz+kGLlZ3e2y2tsq8dNHH6LT0SMzuNvA5PZSyJYkzEN82UqieKa6Q IRkWphyY8BQpcFemXyp1/uueO5LFvX6GCsp85hT1s+LYBRL9gIeeD/K47WHWwe/C hCeW/CcdCIWoDpYEgeG5FwcqsO7CsfuUyPndQG2vhTyWl+dUTKM= =dxUf -----END PGP SIGNATURE----- --Sig_/mVHXOzM/sN//9tgH604Z0rU--