From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: 74058@debbugs.gnu.org
Cc: Nicolas Graves <ngraves@ngraves.fr>
Subject: [bug#74058] [PATCH 1/2] gnu: postgresql-configuration: Set default postgresql to #f.
Date: Mon, 28 Oct 2024 12:13:29 +0100 [thread overview]
Message-ID: <20241028111340.17913-1-ngraves@ngraves.fr> (raw)
In-Reply-To: <20241028105741.12834-1-ngraves@ngraves.fr>
* gnu/services/databases.scm (postgresql-configuration)[postgresql]:
Set default to #f.
(postgresql-services): Revert default to postgresql-10 (rationale: We
can remove this service at the same time than postgresql-10, in
something like 6 months to a year).
---
gnu/services/databases.scm | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm
index 0933eb5e79..f8ae085339 100644
--- a/gnu/services/databases.scm
+++ b/gnu/services/databases.scm
@@ -167,8 +167,12 @@ (define contents
(define-record-type* <postgresql-configuration>
postgresql-configuration make-postgresql-configuration
postgresql-configuration?
- (postgresql postgresql-configuration-postgresql ;file-like
- (default postgresql))
+ ;; Setting it to #f ensures that the user sets its current postgresql
+ ;; explicitely. Since major upgrades currently require a manual migration
+ ;; of the database, this way the user is responsible for upgrading properly.
+ ;; MAYBE TODO: Write an action to automatically upgrade in Guix.
+ (postgresql postgresql-configuration-postgresql ;file-like or #f
+ (default #f))
(port postgresql-configuration-port
(default 5432))
(locale postgresql-configuration-locale
@@ -346,7 +350,7 @@ (define postgresql-service-type
(default-value (postgresql-configuration))
(description "Run the PostgreSQL database server.")))
-(define-deprecated (postgresql-service #:key (postgresql postgresql)
+(define-deprecated (postgresql-service #:key (postgresql postgresql-10)
(port 5432)
(locale "en_US.utf8")
(config-file (postgresql-config-file))
--
2.46.0
next prev parent reply other threads:[~2024-10-28 11:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 10:56 [bug#74058] [PATCH 0/2] [important] Set postgresql default value to #f and warn users Nicolas Graves via Guix-patches via
2024-10-28 11:13 ` Nicolas Graves via Guix-patches via [this message]
2024-10-28 11:13 ` [bug#74058] [PATCH 2/2] etc: news: Warn users about postgresql default update Nicolas Graves via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028111340.17913-1-ngraves@ngraves.fr \
--to=guix-patches@gnu.org \
--cc=74058@debbugs.gnu.org \
--cc=ngraves@ngraves.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.