all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Romain GARBAGE <romain.garbage@inria.fr>
To: 73448@debbugs.gnu.org
Cc: ludovic.courtes@inria.fr, Romain GARBAGE <romain.garbage@inria.fr>
Subject: [bug#73448] [PATCH] gnu: netcdf-parallel-openmpi: Build shared library.
Date: Tue, 24 Sep 2024 13:12:27 +0200	[thread overview]
Message-ID: <20240924111425.21948-1-romain.garbage@inria.fr> (raw)

* gnu/packages/maths.scm (netcdf-parallel-openmpi) [arguments]: Enable
building of shared library.

Change-Id: I6e901d5939108421e041252207f10f4800890e97
---
The parallel version of the netcdf package was build without shared
libraries, which were not supported at the time the package was written
for parallel I/O. This doesn't seem to be the case anymore: the
documentation talks about both parallel and shared library support, e.g.
at
https://docs.unidata.ucar.edu/nug/current/getting_and_building_netcdf.html#build_pnetcdf_from_source.
---
 gnu/packages/maths.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 5f47d5e390..03fa4d2fae 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -2363,8 +2363,9 @@ (define-public netcdf-parallel-openmpi
        ((#:configure-flags flags)
         `(cons* "CC=mpicc" "CXX=mpicxx"
                 "--enable-parallel-tests"
-                ;; Shared libraries not supported with parallel IO.
-                "--disable-shared" "--with-pic"
+                ;; NetCDF supports both parallel and shared library building
+                ;; See https://docs.unidata.ucar.edu/nug/current/getting_and_building_netcdf.html#build_parallel
+                "--enable-shared" "--with-pic"
                 ,flags))
        ((#:phases phases '%standard-phases)
         `(modify-phases ,phases

base-commit: 1c088531cf0be8fe6706c4624a920fca2ab2fee0
-- 
2.46.0





                 reply	other threads:[~2024-09-24 11:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240924111425.21948-1-romain.garbage@inria.fr \
    --to=romain.garbage@inria.fr \
    --cc=73448@debbugs.gnu.org \
    --cc=ludovic.courtes@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.