From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id OE2bL5t/8WYD2QAA62LTzQ:P1 (envelope-from ) for ; Mon, 23 Sep 2024 14:47:55 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id OE2bL5t/8WYD2QAA62LTzQ (envelope-from ) for ; Mon, 23 Sep 2024 16:47:55 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=hREzPzPP; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm1 header.b=NXOn4frV; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="q UNId8d"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1727102875; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Se5sRY5hOt4Sq4kNr0gj47GHaUtS/JrbyjVubxY5WxQ=; b=ZDYmr2+Rr12KlJ7InoWkm0KnYatXd487ORlJg3b4dc4Ny8tV5IL1ijcfobCw9hhe9fPWP1 +EAzuW92mr01TbDfpCE5kgnZQ2sbCtH8ou/lkYhcEF7erOOS3ZgIchUwpGIZHymZlKORbM KLXDa3pos7sBvuc2YNW2jTTCR4N3TZGhKh9Ve13wQC6gF1Z1/HcHtXpO7p16oRGGvRimse QYl5tO5zLfxPR8RCBTZJpvsnm5sI1K2O2q6cgDtChB7ldmnOtdRKUDGRoFUGXBwcAkPH7O sviXl9zTYjsDWrzjGE/fGThGeYkZ+1TGJPfYhuX/EufZXlb1f9VRl+MXKEb/wA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=hREzPzPP; dkim=fail ("headers rsa verify failed") header.d=retrospec.tv header.s=fm1 header.b=NXOn4frV; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="q UNId8d"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1727102875; a=rsa-sha256; cv=none; b=R201Bipb8hhKodzD83FTMNUtWUVUBGS/kyNNCZRtZh2GqG57shzTY5c359yj2718X6nfpT AHwez3xU+Np8vTyX6XNLPUAoe6/bTSaB+QN2BlNQwcIFLluXjkX+9tcUJcA73DknkExQir 9BydwC1ayUYBgviDbBO8ujvh6y0cVHcka6N3T/DYKshZOyRi/+CUpn1/4nN0Yeuft6Fd0q 5g4FfRDErEUzUAlJEkDfTqVFRJSrcJCkKJgEVTNqDvFH3zkF4wuX097fYLHOF9aML/BV9l gF/V0p3usk/Pa+ES8QdJwAYMO0ugXa3NvgM0wYHWa8if1Jo6jkWOYYwV9ioGDg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E1BEF6B042 for ; Mon, 23 Sep 2024 16:47:54 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sskLp-0005Z3-4Q; Mon, 23 Sep 2024 10:47:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sskLn-0005Y8-1l for guix-patches@gnu.org; Mon, 23 Sep 2024 10:47:43 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sskLj-00063t-Io for guix-patches@gnu.org; Mon, 23 Sep 2024 10:47:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=Se5sRY5hOt4Sq4kNr0gj47GHaUtS/JrbyjVubxY5WxQ=; b=hREzPzPPbOHdOT3qvdiVHHpFSxd2woY4lb7twKUZNuf1tdyPp9mbslPvcILMhcyAQZU15rgRAk2Gb2xsn81s9dJBdo46/xiTcJuuMVmlXtrjhC+NSNz7la3jQGhs+WOoAnzVS2dnI/oCcTYrSqNgTTnbP05gGgN6SsulGkeUPYAcAp0/lMxYRv4H5p2cLN+bxtnRBNADTuXp3FQZtANRmuoLVqO0pkbXGA3XDl97vmX8Q+nH5Q/+YC6jegHhFdA6HWW4sEKTLwdpRgUaWLDJwK3bGdxFeaM3rWXbAUgaVOGNhqJvO9p0NfUwihQO5TcBtBhGEruJm5dieNnE3UHd9Q==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sskM6-00027P-KE for guix-patches@gnu.org; Mon, 23 Sep 2024 10:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73429] [PATCH v2 2/3] gnu: librewolf: Update to 130.0.1-1. [security fixes] Resent-From: Ian Eure Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 23 Sep 2024 14:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73429 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 73429@debbugs.gnu.org Cc: =?UTF-8?Q?Andr=C3=A9?= Batista , mhw@netris.org, jonathan.brielmaier@web.de, Ian Eure Received: via spool by 73429-submit@debbugs.gnu.org id=B73429.17271028718100 (code B ref 73429); Mon, 23 Sep 2024 14:48:02 +0000 Received: (at 73429) by debbugs.gnu.org; 23 Sep 2024 14:47:51 +0000 Received: from localhost ([127.0.0.1]:44571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sskLu-00026W-2C for submit@debbugs.gnu.org; Mon, 23 Sep 2024 10:47:50 -0400 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]:37899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sskLn-00025i-Iz for 73429@debbugs.gnu.org; Mon, 23 Sep 2024 10:47:44 -0400 Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfhigh.phl.internal (Postfix) with ESMTP id 5AC261140187; Mon, 23 Sep 2024 10:47:15 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Mon, 23 Sep 2024 10:47:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1727102835; x=1727189235; bh=Se5sRY5hOt4Sq4kNr0gj47GHaUtS/JrbyjVubxY5WxQ=; b= NXOn4frVaKKzdhUbmYPZGkfnwaE2wlwYI4N19TUPWVBQqnBjONENrjCmjjM4feBU 1s2OTX+icK4I+VuAdynZEM57GWamO4yQUEuQV4tcOE1kfuIoY21hvwFX1w2YFXzA FY7q5TNP/Z58HDZU9gIyO6A6aTrDNUPrJe9/D+UvOpblwULNzmqepTPrdTkClyUb VXoDS1ATL+aVP+F+tj7m2yqQ0rB1e8bmrl/8brSxbjkMAv7XZ06faFUTkahy3ViP TVoCf0gT/cqMKus03dnq8Q/qSoyM0oj5NED/AoQDL+yaNRMUHiCXeyB01O3jkJXq FBLu5jdJjscY3EJLEdKnPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1727102835; x= 1727189235; bh=Se5sRY5hOt4Sq4kNr0gj47GHaUtS/JrbyjVubxY5WxQ=; b=q UNId8d1tLHjXiGu2VmUNjO/yc2XxqDH33lgdQ9fgB8LgNI7Ud4e4ZX3K6hg1pqF8 HEh7vLMByoURLBNdrCQM7o+DkUTz1dt2JMxip+sZLkx/IuuzCVAN0FVLeniFROTq cNZdgVez4vI3mcZIuHTQRGmV3/2NpW9XO8O1AdUFgngZZUcbb6192GjyOOnTuwlN E+Y62oya+8Y+xmgZJsnp/VUGZ1ZOCyZmVWLBnWKJis7GsH8B3LASuw+PQBHFrss4 8P4kiQYQ6dCwIakWqE36RPHrwKF3bIUZBLbe5tV2Qc//2/nQd+eWygcWQMTtbFy1 KbFNSaX5PRi05PZW34+Pw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudelledgkedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdej necuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdhtvheqne cuggftrfgrthhtvghrnhepvdejlefhhefgudefveetieekudeijeevgfdvtefgledviedt feelfeeuffejueegnecuffhomhgrihhnpegtohguvggsvghrghdrohhrghdpghhithhhuh gsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepihgrnhesrhgvthhrohhsphgvtgdrthhvpdhnsggprhgtphhtthhopeehpdhmohguvg epshhmthhpohhuthdprhgtphhtthhopeejfeegvdelseguvggssghughhsrdhgnhhurdho rhhgpdhrtghpthhtohepnhgrnhgurhgvsehrihhsvghuphdrnhgvthdprhgtphhtthhope hjohhnrghthhgrnhdrsghrihgvlhhmrghivghrseifvggsrdguvgdprhgtphhtthhopehm hhifsehnvghtrhhishdrohhrghdprhgtphhtthhopehirghnsehrvghtrhhoshhpvggtrd htvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 23 Sep 2024 10:47:13 -0400 (EDT) From: Ian Eure Date: Mon, 23 Sep 2024 07:47:05 -0700 Message-ID: <20240923144706.2073-3-ian@retrospec.tv> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240923144706.2073-1-ian@retrospec.tv> References: <20240923144706.2073-1-ian@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: E1BEF6B042 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -9.66 X-Migadu-Spam-Score: -9.66 X-TUID: nq7SEGJ3UqSX This patch: - Updates LibreWolf to the latest version - Removes the code which disabled encoding_rs.patch from upstream. It’s no longer in the repo, so the code did nothing, and the underlying issue (Guix being stuck with an old Rust version) has been fixed. - Integrates changes from #72265 with some slight tweaks. This should allow LibreWolf to use accelerated video decoding on supported hardware. - Neuters the GenAI chat feature, which direcly integrates with non-free services, by excluding it from the build and locking the preferences which would enable it. Fixes: CVE-2024-8385: WASM type confusion involving ArrayTypes CVE-2024-8381: Type confusion when looking up a property name in a "with" block CVE-2024-8388: Fullscreen notice on Android could be hidden under various panels and OS prompts CVE-2024-8382: Internal event interfaces were exposed to web content when browser EventHandler listener callbacks ran CVE-2024-8383: Firefox did not ask before openings news: links in an external application CVE-2024-8384: Garbage collection could mis-color cross-compartment objects in OOM conditions CVE-2024-8386: SelectElements could be shown over another site if popups are allowed CVE-2024-8387: Memory safety bugs fixed in Firefox 130, Firefox ESR 128.2, and Thunderbird 128.2 CVE-2024-8389: Memory safety bugs fixed in Firefox 130 * gnu/packages/librewolf.scm (librewolf): Update to 130.0.1-1. Change-Id: I764e6e66c5bfdc14a87b7ea59c29780a1f16769a --- gnu/packages/librewolf.scm | 55 ++++++++++++++++++++------------------ 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/gnu/packages/librewolf.scm b/gnu/packages/librewolf.scm index 21f73f799d..bade479656 100644 --- a/gnu/packages/librewolf.scm +++ b/gnu/packages/librewolf.scm @@ -117,9 +117,11 @@ (define (librewolf-source-origin version hash) (define computed-origin-method (@@ (guix packages) computed-origin-method)) (define librewolf-source - (let* ((ff-src (firefox-source-origin "129.0.1" "0wy0fn0pavlhlkdybr59hhbn5ng0zn56mxa7gsknf8f2whiyipwx")) - (version "129.0.1-1") - (lw-src (librewolf-source-origin version "0pvv3v23q31hdjvqi1f3cqfyjrb8dbrrbfwxj2wacak1g0mzbxf4"))) + (let* ((ff-src (firefox-source-origin "130.0" + "0w4z3fq5zhm63a0wmhvmqrj263bvy962dir25q3z0x5hx6hjawh2")) + (lw-src (librewolf-source-origin + "130.0.1-1" + "0f80pihn375bdjhjmmg2v1w96wpn76zb60ycy39wafwh1dnzybrd"))) (origin (method computed-origin-method) @@ -164,11 +166,6 @@ (define librewolf-source (("^ff_source_tarball:=.*") (string-append "ff_source_tarball:=" #+ff-src))) - ;; Remove encoding_rs patch, it doesn't build with Rust 1.75. - (substitute* '("assets/patches.txt") - (("patches/encoding_rs.patch\\\n$") - "")) - ;; Stage locales. (begin (format #t "Staging locales...~%") @@ -215,13 +212,17 @@ (define rust-librewolf rust) ; 1.75 is the default in Guix, 1.65 is the minimum. ;; Update this id with every update to its release date. ;; It's used for cache validation and therefore can lead to strange bugs. ;; ex: date '+%Y%m%d%H%M%S' -(define %librewolf-build-id "20240817075827") +(define %librewolf-build-id "20240922110507") (define-public librewolf (package (name "librewolf") - (version "129.0.1-1") - (source librewolf-source) + (version "130.0.1-1") + (source + (origin + (inherit librewolf-source) + (patches + (search-patches "librewolf-add-paths-to-rdd-allowlist.patch")))) (build-system gnu-build-system) (arguments (list @@ -318,6 +319,22 @@ (define (write-setting key value) (substitute* "dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp" (("libavcodec\\.so") libavcodec))))) + (add-after 'unpack 'neuter-genai + (lambda* _ + ;; Don't compile the code in. + (substitute* "browser/components/moz.build" + (("\"genai\",") "")) + ;; Lock the preferences so they can't be enabled. + (substitute* "lw/librewolf.cfg" + (("defaultPref\\(\"browser\\.ml\\.") + "lockPref(\"browser.ml.")) + ;; Correct a preference typo + ;; see https://codeberg.org/librewolf/issues/issues/1919#issuecomment-2325954 + ;; Remove this in the next update. + (substitute* "lw/librewolf.cfg" + (("browser\\.ml\\.enabled") + "browser.ml.enable")) + )) (add-after 'patch-source-shebangs 'patch-cargo-checksums (lambda _ (use-modules (guix build cargo-utils)) @@ -575,26 +592,12 @@ (define (runpaths-of-input label) ;; For U2F and WebAuthn "eudev"))) - ;; VA-API is run in the RDD (Remote Data Decoder) sandbox - ;; and must be explicitly given access to files it needs. - ;; Rather than adding the whole store (as Nix had - ;; upstream do, see - ;; and - ;; linked upstream patches), we can just follow the - ;; runpaths of the needed libraries to add everything to - ;; LD_LIBRARY_PATH. These will then be accessible in the - ;; RDD sandbox. - (rdd-whitelist (map (cut string-append <> "/") - (delete-duplicates (append-map - runpaths-of-input - '("mesa" - "ffmpeg"))))) (gtk-share (string-append (assoc-ref inputs "gtk+") "/share"))) (wrap-program (car (find-files lib "^librewolf$")) `("LD_LIBRARY_PATH" prefix - (,@libs ,@rdd-whitelist)) + ,libs) `("XDG_DATA_DIRS" prefix (,gtk-share)) `("MOZ_LEGACY_PROFILES" = -- 2.46.0