all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "André Batista" <nandre@riseup.net>
To: 73192@debbugs.gnu.org
Cc: "André Batista" <nandre@riseup.net>, bdju <bdju@tilde.team>,
	jonathan.brielmaier@web.de, mhw@netris.org
Subject: bug#73192: [PATCH] gnu: icedove-l10n: Fix build.
Date: Thu, 19 Sep 2024 19:39:05 -0300	[thread overview]
Message-ID: <20240919223905.2840-1-nandre@riseup.net> (raw)
In-Reply-To: <D444D6H1R4IM.N5N6XLSULGW0@tilde.team>

Fixes <https://issues.guix.gnu.org/73192>

* gnu/packages/gnuzilla.scm (make-l10n-package)[arguments]<#:phases>:
On 'build phase unconditionally use 'system*' to invoke 'mach', as
'invoke' does not work for icedove any longer.

Reported-by: bdju <bdju@tilde.team>.
---
 gnu/packages/gnuzilla.scm | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index d7b9aa72e9..d25577111b 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1684,13 +1684,11 @@ (define (find-file dir name)
                                               'thunderbird
                                               '#$project))))
                      (format #t "processing locale `~a'...~%" l)
-                     (if (eq? 'icecat '#$project)
-                         ;; XXX: For some reasons, for IceCat, there are some
-                         ;; parsing errors that cause the build system to
-                         ;; return an unclean exit code; use system* to ignore
-                         ;; errors.
-                         (system* "./mach" "build" (string-append "langpack-" l))
-                         (invoke "./mach" "build" (string-append "langpack-" l)))
+                     ;; XXX: For some reasons, on version 115, there are some
+                     ;; parsing errors that cause the build system to
+                     ;; return an unclean exit code; use system* to ignore
+                     ;; errors.
+                     (system* "./mach" "build" (string-append "langpack-" l))
                      (mkdir-p ext-dir)
                      (let ((xpi (find-file "obj" (string-append
                                                   "\\." l "\\.langpack\\.xpi$"))))

base-commit: d4fbd1ab341de85c1e5c77e0f7adc5aae056be15
-- 
2.45.2





  parent reply	other threads:[~2024-09-19 22:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12  7:15 bug#73192: icedove-l10n-115.14.0 build failure bdju via Bug reports for GNU Guix
2024-09-17 14:28 ` bug#73192: Me too! Daniel Hatton via Bug reports for GNU Guix
2024-09-19 22:39 ` André Batista [this message]
2024-09-19 22:49   ` bug#73192: [PATCH] gnu: icedove-l10n: Fix build André Batista
2024-09-22 21:06   ` Jonathan Brielmaier via Bug reports for GNU Guix
2024-09-22 21:06 ` bug#73192: icedove-l10n-115.14.0 build failure Jonathan Brielmaier via Bug reports for GNU Guix
2024-09-24 13:30 ` bug#73192: FIXED Daniel Hatton via Bug reports for GNU Guix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240919223905.2840-1-nandre@riseup.net \
    --to=nandre@riseup.net \
    --cc=73192@debbugs.gnu.org \
    --cc=bdju@tilde.team \
    --cc=jonathan.brielmaier@web.de \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.