[bug#73160] [PATCH] gnu: emacs-exwm-firefox: Update to 1.3.

[bug#73160] [PATCH] gnu: emacs-exwm-firefox: Update to 1.3.

[Ian Eure]

* gnu/packages/emacs-xyz.scm (emacs-exwm-firefox): Update to 1.3.

Change-Id: I17e2ef89f2fcf6fc717243444ede3b72a6d6f395
---
 gnu/packages/emacs-xyz.scm | 62 +++++++++++++++++++-------------------
 1 file changed, 31 insertions(+), 31 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 92e0275519..1755b736bc 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -32977,39 +32977,39 @@ (define-public emacs-exwm-firefox-core
       (license (list license:gpl3+)))))
 
 (define-public emacs-exwm-firefox
-  (let ((commit "ba4044cf57f99656bbe1974278336b6abcb15497")) ;version bump
-    (package
-      (name "emacs-exwm-firefox")
-      (version "1.2")
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://codeberg.org/emacs-weirdware/exwm-firefox.git")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32 "1x9hc94a5wygyw714q98jbk4kjvys2ra94qdc2cbgkm6iq982rvq"))))
-      (build-system emacs-build-system)
-      (arguments
-       (list
-        #:phases
-        #~(modify-phases %standard-phases
-            (add-after 'unpack 'chdir
-              (lambda _ (chdir "lisp"))))
-        #:tests? #true
-        #:test-command #~(list "emacs" "-Q" "--batch"
-                               "-l" "../test/exwm-firefox--tests.el"
-                               "-l" "exwm-firefox.el"
-                               "-f" "ert-run-tests-batch-and-exit")))
-      (inputs (list emacs-exwm emacs-exwm-firefox-core emacs-s))
-      (home-page "https://codeberg.org/emacs-weirdware/exwm-firefox")
-      (synopsis "Enhanced support for Firefox under EXWM")
-      (description
-       "This package adds enhanced support for Firefox (and forks
+  (package
+    (name "emacs-exwm-firefox")
+    (version "1.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://codeberg.org/emacs-weirdware/exwm-firefox.git")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0jrnsnygi9kwq17dfjpjksmijx39w7ccsk4gzk5l2cg7ncydsja2"))))
+    (build-system emacs-build-system)
+    (arguments
+     (list #:tests? #t
+           #:phases
+           #~(modify-phases %standard-phases
+               (replace 'install
+                 (lambda args
+                   (with-directory-excursion "lisp"
+                     (apply (assoc-ref %standard-phases 'install) args)))))))
+    (propagated-inputs
+     (list
+      upstream/emacs-exwm-firefox-core
+      upstream/emacs-s
+      upstream/emacs-exwm))
+    (home-page "https://codeberg.org/emacs-weirdware/exwm-firefox")
+    (synopsis "Enhanced support for Firefox under EXWM")
+    (description
+     "This package adds enhanced support for Firefox (and forks
 based on Firefox) under EXWM.  Keybindings intentionally mirror other Emacs
 navigation controls.")
-      (license (list license:gpl3+)))))
+    (license (list license:gpl3+))))
 
 (define-public emacs-exwm-ss
   (let ((commit "b11d3df7a50c39b4e1b92ef8a6685cf80b53912c")
-- 
2.45.2

[bug#73160] [PATCH] gnu: emacs-exwm-firefox: Update to 1.3.

[Maxim Cournoyer]

Hello Ian,

Ian Eure <ian@retrospec.tv> writes:

> * gnu/packages/emacs-xyz.scm (emacs-exwm-firefox): Update to 1.3.

The changelog commit message should mention the other changes done here,
such as removal of the #:test-command argument, and substitution of
inputs by propagated inputs, as well as upstream/ (?) input variants.

About the later, I'm a bit confused; I don't see any
upstream/emacs-exwm-firefox-core package variable in our source for
example, and the naming strikes me as odd (we'd typically have something
like 'emacs-exwm-firefox-core-next' if an unreleased or newer than
packaged version was needed by something).

Could you expound the commit message and clarify the above?

-- 
Thanks,
Maxim

[bug#73160] [PATCH v2] gnu: emacs-exwm-firefox: Update to 1.3.

[Ian Eure]

* gnu/packages/emacs-xyz.scm (emacs-exwm-firefox): Update to 1.3.

Change-Id: I7717134ae37eca41201bc285a9a3e3a95e8b4cc1
---
 gnu/packages/emacs-xyz.scm | 61 +++++++++++++++++++-------------------
 1 file changed, 30 insertions(+), 31 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 92e0275519..0bc42a419f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -32977,39 +32977,38 @@ (define-public emacs-exwm-firefox-core
       (license (list license:gpl3+)))))
 
 (define-public emacs-exwm-firefox
-  (let ((commit "ba4044cf57f99656bbe1974278336b6abcb15497")) ;version bump
-    (package
-      (name "emacs-exwm-firefox")
-      (version "1.2")
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://codeberg.org/emacs-weirdware/exwm-firefox.git")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32 "1x9hc94a5wygyw714q98jbk4kjvys2ra94qdc2cbgkm6iq982rvq"))))
-      (build-system emacs-build-system)
-      (arguments
-       (list
-        #:phases
-        #~(modify-phases %standard-phases
-            (add-after 'unpack 'chdir
-              (lambda _ (chdir "lisp"))))
-        #:tests? #true
-        #:test-command #~(list "emacs" "-Q" "--batch"
-                               "-l" "../test/exwm-firefox--tests.el"
-                               "-l" "exwm-firefox.el"
-                               "-f" "ert-run-tests-batch-and-exit")))
-      (inputs (list emacs-exwm emacs-exwm-firefox-core emacs-s))
-      (home-page "https://codeberg.org/emacs-weirdware/exwm-firefox")
-      (synopsis "Enhanced support for Firefox under EXWM")
-      (description
-       "This package adds enhanced support for Firefox (and forks
+  (package
+    (name "emacs-exwm-firefox")
+    (version "1.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://codeberg.org/emacs-weirdware/exwm-firefox.git")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0jrnsnygi9kwq17dfjpjksmijx39w7ccsk4gzk5l2cg7ncydsja2"))))
+    (build-system emacs-build-system)
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'chdir
+            (lambda _ (chdir "lisp"))))
+      #:tests? #true
+      #:test-command #~(list "emacs" "-Q" "--batch"
+                             "-l" "../test/exwm-firefox--tests.el"
+                             "-l" "exwm-firefox.el"
+                             "-f" "ert-run-tests-batch-and-exit")))
+    (inputs (list emacs-exwm emacs-exwm-firefox-core emacs-s))
+    (home-page "https://codeberg.org/emacs-weirdware/exwm-firefox")
+    (synopsis "Enhanced support for Firefox under EXWM")
+    (description
+     "This package adds enhanced support for Firefox (and forks
 based on Firefox) under EXWM.  Keybindings intentionally mirror other Emacs
 navigation controls.")
-      (license (list license:gpl3+)))))
+    (license (list license:gpl3+))))
 
 (define-public emacs-exwm-ss
   (let ((commit "b11d3df7a50c39b4e1b92ef8a6685cf80b53912c")
-- 
2.46.0

bug#73160: [PATCH] gnu: emacs-exwm-firefox: Update to 1.3.

[Nicolas Goaziou via Guix-patches via]

Hello,

> * gnu/packages/emacs-xyz.scm (emacs-exwm-firefox): Update to 1.3.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou