From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id YK2aKqI52mbkdwAAqHPOHw:P1 (envelope-from ) for ; Thu, 05 Sep 2024 23:07:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id YK2aKqI52mbkdwAAqHPOHw (envelope-from ) for ; Fri, 06 Sep 2024 01:07:14 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=bQQyqBk7; dkim=fail ("headers rsa verify failed") header.d=interia.pl header.s=dk header.b=pfDlemIt; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=interia.pl (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725577634; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=98U7LIyXvV93c1K3WYIV+QO4tAxFpNHlaOCbSyD/Av0=; b=rdGNvcC1TSGk55WfgFb2t16x+n5NBz9WRxgo3f70fxTmy98nueNoB3eb4jOXC8Rt+KEZQO mtJSvnBRA59MG2jLWqSafzcCrZGyEy98vr/XrocwbRTDfm+dxP144r/4ScHdxJHH6mH5Rt iNp/XgzbDLCyHhAd/7gQ35Zl+6URiSnU0Xv4rbQOYMUCs/Cd+7ZGn6OwHMlJdktY5BhR4g mOJVTI0zoYrMcuS0yR1aRKz7va51eiPYl/cHE+Byuizk7ATfwjTI1xUq0EDeAjnEWhYETo iDaeiY4RBVCTDJCHeJ0WazoDTyx6mARpNiQnp3Vzdx4JY4VUn4ZRxxqnKa+7Fg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=bQQyqBk7; dkim=fail ("headers rsa verify failed") header.d=interia.pl header.s=dk header.b=pfDlemIt; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=interia.pl (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725577634; a=rsa-sha256; cv=none; b=XbMEM3K4V5Q4/1XJjx58VjuKv3MVUVOYTG47+8FxDFP6fxDh/Q4C1MRAwZBJjyOLgjJelJ 0BKrEC3H7+DdFoAqo8tFwv9EqazkuTN4NbD0b8+Yalc5yL/lUI20tTiEXvByT+KMV/iz4J YE9GECNtrnw3UjKRlM/BvF2zDT9rwAsYkrkKBftJeBF6p+S3Z2hVKm1IEaEUG1hcfIbSsd qU38IFB+LTKvghskq9Ocne7cNxkVf3Bo8NdPuaAk/HwJn3UOGKATi3ahFcgz6fldwUqPuU N368kobBfsxo82M5050nmrJc9EW1a0yfXi/6KXZJMgApq5NxdGC8ZgYwEP4s6w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8612C6BF98 for ; Fri, 6 Sep 2024 01:07:14 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smLZ3-0004XU-WC; Thu, 05 Sep 2024 19:06:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smLZ2-0004XH-Ne for guix-patches@gnu.org; Thu, 05 Sep 2024 19:06:56 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smLZ2-00071k-Ex for guix-patches@gnu.org; Thu, 05 Sep 2024 19:06:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=98U7LIyXvV93c1K3WYIV+QO4tAxFpNHlaOCbSyD/Av0=; b=bQQyqBk7Wad/xyg5LB0JX7ea5azsmnMsu9g+4i8cjpC0m76N2oKdnvrTEYvWQbd5i9dWS9+1u19mInLPJQir90JnrWQl1q9NsI6frEvJlyXb4rXsYa2oNKtqelTFk0fqGe9DLxGf41GZh41WJPlc9GAVJ8bqSRVGoyNlqG3XHnGKZBowgSMdzwyKmFpuyZzO8SdNi55ts5pJm44Vbirx0c9s6Bep7MiJcT/uQYiSeZfnhXuXfPpqY5wlqrlRzvQZyYqzYGfM9hY5PEv7ilga/xvV268Hk/Z3ueF6QRzbR2Cnscp4g273WpHVTJ9vxLsflRPUnaZzfToLMhzIgKwg5w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smLa5-0001vv-N4 for guix-patches@gnu.org; Thu, 05 Sep 2024 19:08:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72912] [PATCH 0/1] Update Minetest to 5.9.0 (again) Resent-From: Jan Wielkiewicz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Sep 2024 23:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72912 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: Adam Faiz , 72912@debbugs.gnu.org, Liliana Marie Prikler , =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Received: via spool by 72912-submit@debbugs.gnu.org id=B72912.17255776377372 (code B ref 72912); Thu, 05 Sep 2024 23:08:01 +0000 Received: (at 72912) by debbugs.gnu.org; 5 Sep 2024 23:07:17 +0000 Received: from localhost ([127.0.0.1]:38486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smLZM-0001uq-Oa for submit@debbugs.gnu.org; Thu, 05 Sep 2024 19:07:17 -0400 Received: from smtpo49.interia.pl ([217.74.67.49]:48916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smLZI-0001uO-7t for 72912@debbugs.gnu.org; Thu, 05 Sep 2024 19:07:15 -0400 Received: from localhost (89-64-60-39.dynamic.chello.pl [89.64.60.39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by poczta.interia.pl (INTERIA.PL) with ESMTPSA; Fri, 6 Sep 2024 01:05:57 +0200 (CEST) Date: Fri, 6 Sep 2024 01:05:48 +0200 From: Jan Wielkiewicz Message-ID: <20240906010548.1eab8fb1@interia.pl> In-Reply-To: References: <438cb9c032652d3ba32ae927121e58adb5c82abd.camel@gmail.com> <20240831142605.29484112@interia.pl> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IPL-Priority-Group: 0-0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl; s=dk; t=1725577558; bh=98U7LIyXvV93c1K3WYIV+QO4tAxFpNHlaOCbSyD/Av0=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=pfDlemItNtnW/99FsucQPndM/sp6Sxla+6/W5BvEzVgoDv2brTaA7bzD59Vhwwb89 EfNlxDF/0+Z8K/Vn/faaCuuZFIfjxCz9m2QkuQRs92xstkmC59OUcPVZfg4FqnKHCG Q+xvQRVooCRHqOJTMW3ZX9sG3NrHd21SxTjq+J+o= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 8612C6BF98 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -8.92 X-Spam-Score: -8.92 X-TUID: ywSxEPoORYS0 Hi, On Thu, 5 Sep 2024 15:17:56 -0400 Leo Famulari wrote: > Hi Jan, > > Thanks so much for performing this complicated upgrade! I confirm it > works fine to play Minetest. > > On Sat, Aug 31, 2024 at 02:26:05PM +0200, Jan Wielkiewicz wrote: > > The minetest-something convention is for packages that are either > > games for minetest or mods for any minetest game. Minetest - the > > engine executes games. Previously "Minetest Game" was the default > > game for Minetest (the engine), but is not anymore. A similar > > example would be a game called "MineClone" for Minetest, the > > package is then called minetest-mineclone. But "Minetest Game" is > > indeed the name of the ex-default game, hence > > minetest-minetest-game. "minetest-game" would suggest it's a game > > for minetest named "game" also could make it possible to confuse it > > with simply "minetest" - the engine. The name of the > > package: https://github.com/minetest/minetest_game > > We have similar conventions for other packages in Guix, such as Python > modules. > > But if a Python program is named by its authors "python-foo", we do > not package it as "python-python-foo". Well, there is one package > like this currently, but that's one mistake, after we avoided the > repetitive names many times. > > I think that if somebody wants to play the basic Minetest game, they > will not have much trouble choosing the package called > "minetest-game". Well, I guess "minetest-game" should be fine then. > I've attached a diff against your patch that makes that change and > some other minor changes. Do I need to apply the patch and resend it or will a maintainer take care of that? > Specifically: > > It tweaks the description of the minetest engine packages to remove > the "marketing" word "easy", as requested in the guidelines on writing > package descriptions: > > https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html Looks good. > It also uses "minetest-game" as an example of a game that could be > installed based on this engine. Or should we use mineclone? We don't > have any other games packaged, right? There are multiple games for Minetest, most of them listed on ContentDB https://content.minetest.net/packages/?type=game The general idea is that after dropping MTG as the default, it's up to the user to pick what they want to play. ContentDB can be also accessed in the game and the game upon the first startup instructs the user to install a game. ContentDB has a relatively strict policy for package inclusion: https://content.minetest.net/policy_and_guidance/ Most games/mods are free software, some packages that aren't are clearly marked as such with red text. Most importantly Minetest by default hides non-free packages from ContentDB in the game. So it should be fine to let users pick a game they like from ContentDB. I think that Mineclone is not the best default game because it does a 1:1 copy of Minecraft. It is free software and assets are free, but a 1:1 copy is legally questionable. That's why I believe we shouldn't ship Minetest with any game preinstalled. On a side note, I plan updating existing Minetest packages and adding more games for it, but this work should be merged first. > It adjusts the version procedure of minetest-game to respect the > guidlines in the manual section Version Numbers: > > https://guix.gnu.org/manual/en/html_node/Version-Numbers.html > > It removes irrlicht-for-minetest entirely. I don't think we need to > deprecate libraries that wouldn't have been installed into someone's > profile. Makes sense. > I'm not as sure about minetest-data. Was that something that people > would install? I never needed to in order to play the minetest game. People still play this, in fact it has hundreds of mods and is still the second most popular game, it's just not official anymore. Also the input was propagated so it makes sense to replace it with the new "minetest-game" package I guess? If people don't want it they can still remove it. But new installs shouldn't get this installed by default. Long story short Minetest devs considered MTG was a bad advertisement for the project also a waste of their resources and decided to focus on the engine instead. > What do you think? Looks good. -- Jan