all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: 71037@debbugs.gnu.org
Cc: ngraves@ngraves.fr
Subject: [bug#71037] [PATCH 1/3] gnu: python-pydevd: Move to pyproject-build-system.
Date: Sat, 18 May 2024 14:43:05 +0200	[thread overview]
Message-ID: <20240518124316.19861-1-ngraves@ngraves.fr> (raw)
In-Reply-To: <20240518123734.9898-1-ngraves@ngraves.fr>

* gnu/packages/python-xyz.scm (python-pydevd):
  [build-system]: Move to pyproject-build-system.
  [arguments]: Replace 'check phase by 'pre-check phase and
  <#:test-flags>.

Change-Id: I8227ac8b1b6031c30c6d09480cacaa3347df21a7
---
 gnu/packages/python-xyz.scm | 46 ++++++++++++++++++-------------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 8151355a418..c2039273429 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -16717,9 +16717,29 @@ (define-public python-pydevd
          (sha256
           (base32
            "1yd017dh6xgxrqcyf8kk8jrr0a3zw895yfjih0z5jghyf0rck38q"))))
-      (build-system python-build-system)
+      (build-system pyproject-build-system)
       (arguments
        (list
+        #:test-flags
+        #~(list "-n" (number->string (parallel-job-count))
+                "-k"
+                (string-append
+                 ;; The two "break_01" tests have been failing on
+                 ;; Python 3.10:
+                 ;; <https://github.com/fabioz/PyDev.Debugger/issues/222>.
+                 "not test_set_pydevd_break_01 "
+                 ;; This one fails for unknown reasons.
+                 "and not test_completion_sockets_and_messages "
+                 ;; the GUI event loop requires an X server.
+                 "and not test_gui_event_loop_custom "
+                 ;; This test validates that 'pydevd' is not in the
+                 ;; exception message, but it is due to being part
+                 ;; of the build file name present in the message.
+                 "and not test_evaluate_exception_trace "
+                 ;; These fail on systems with YAMA LSM’s ptrace
+                 ;; scope > 0. Upstream issue:
+                 ;; https://github.com/fabioz/PyDev.Debugger/issues/218
+                 "and not test_attach_to_pid"))
         #:phases
         #~(modify-phases %standard-phases
             (add-after 'unpack 'fix-tests
@@ -16758,30 +16778,10 @@ (define-public python-pydevd
                 (invoke #+(cxx-for-target) "-shared" "-o" "attach.so"
                         "-fPIC" "-nostartfiles"
                         "pydevd_attach_to_process/linux_and_mac/attach.cpp")))
-            (replace 'check
+            (add-before 'check 'pre-check
               (lambda* (#:key tests? #:allow-other-keys)
                 (when tests?
-                  (setenv "PYDEVD_USE_CYTHON" "YES")
-                  (invoke "pytest" "-vv"
-                          "-n" (number->string (parallel-job-count))
-                          "-k"
-                          (string-append
-                           ;; The two "break_01" tests have been failing on
-                           ;; Python 3.10:
-                           ;; <https://github.com/fabioz/PyDev.Debugger/issues/222>.
-                           "not test_set_pydevd_break_01 "
-                           ;; This one fails for unknown reasons.
-                           "and not test_completion_sockets_and_messages "
-                           ;; the GUI event loop requires an X server.
-                           "and not test_gui_event_loop_custom "
-                           ;; This test validates that 'pydevd' is not in the
-                           ;; exception message, but it is due to being part
-                           ;; of the build file name present in the message.
-                           "and not test_evaluate_exception_trace "
-                           ;; These fail on systems with YAMA LSM’s ptrace
-                           ;; scope > 0. Upstream issue:
-                           ;; https://github.com/fabioz/PyDev.Debugger/issues/218
-                           "and not test_attach_to_pid")))))
+                  (setenv "PYDEVD_USE_CYTHON" "YES"))))
             (add-after 'install 'install-attach-binary
               (lambda _
                 (install-file "attach.so"
-- 
2.41.0





  reply	other threads:[~2024-05-18 12:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-18 12:35 [bug#71037] [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6 Nicolas Graves via Guix-patches via
2024-05-18 12:43 ` Nicolas Graves via Guix-patches via [this message]
2024-05-18 12:43   ` [bug#71037] [PATCH 2/3] " Nicolas Graves via Guix-patches via
2024-05-18 12:43   ` [bug#71037] [PATCH 3/3] gnu: python-pydevd: Improve package style Nicolas Graves via Guix-patches via
2024-05-21  2:40 ` [bug#71037] [PATCH 0/3] gnu: python-pydevd: Update to 2.9.6 Maxim Cournoyer
2024-05-21  7:51   ` Nicolas Graves via Guix-patches via
2024-05-22  0:07     ` Maxim Cournoyer
2024-06-24  3:12       ` Maxim Cournoyer
2024-06-24  7:50         ` Nicolas Graves via Guix-patches via
2024-06-24 13:18           ` Maxim Cournoyer
2024-06-29  7:00             ` jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240518124316.19861-1-ngraves@ngraves.fr \
    --to=guix-patches@gnu.org \
    --cc=71037@debbugs.gnu.org \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.