From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:5f26::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id QBB0NuREfmU1pgAAkFu2QA (envelope-from ) for ; Sun, 17 Dec 2023 01:46:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id mLBzL+REfmXcGgAAqHPOHw (envelope-from ) for ; Sun, 17 Dec 2023 01:46:28 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=SMb1s057; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1702773988; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=s5Mg/c4eypqbbjxhRJjH4V2CQgASghFd8RY2vK7nqvc=; b=Ekc7Kkh89CwRGn/4WJXr9FjgNk3JIDJHj5Ghw8iGtTlUC9INqtAKJevnJ+7BicPdbuXmQ/ mKcgHHu9vNKPMbLjtOYTditF4ie5Dn0SHGidJjAkRiUW80Qr8QiJBmrQoK1l+aOsMyBWw9 PXFNxU2EHZPgAJ8bR8Sjp90TCTOxssHewok3iwNuErdEpo0g0iMcWw5J76gqReuASy1EiV 55dZkjAzZIJtB8fOekTIfPx8Zby7BBR8Ytq5cPMmnfNDZWnV5QZ+McvHg5bPUQweSuZN2O 78U51XdbojihEMAIV4Z2WVRN3kREvgY3biuExytM2Qy1Z00QdlrDWLtAqW9uHw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=SMb1s057; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1702773988; a=rsa-sha256; cv=none; b=L1nfbfxoNm1VvT9hqQLJOKsplQ5/MAxXmOu66G3qZgOcG38U86dybanDhiL01f/T+yOsiX h2Md+mLNRgHYkxMM9yKZ+mmuWxYfopScLYZzC03MEzvVdpPgfxQQ3XCAXi+pV7CPT1d4FU ztk4CLM7s+3+dr72lWLiYzk5MgFDFBDfH3zw2DavEagOpmBDi/g62GWR3o5vWAyc0wcDw0 v5BlHYLt7GqgJmTgDbReW63tIXrTcHaRp/wYk7+BMoR618nkzUF9NRkJMDTmuAP89BKUU6 k3RQ3MjDAWpb/j7pggTlyVuJ+4o0dC+TImO3uc4YYszQw2skLhwE88jtSD5GXg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9084C38335 for ; Sun, 17 Dec 2023 01:46:28 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEfID-0002sE-1l; Sat, 16 Dec 2023 19:46:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEfI9-0002rd-Sy for bug-guix@gnu.org; Sat, 16 Dec 2023 19:46:01 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEfI9-0003b7-KH for bug-guix@gnu.org; Sat, 16 Dec 2023 19:46:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEfIA-0000KC-Fb for bug-guix@gnu.org; Sat, 16 Dec 2023 19:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#67839: [PATCH v2 2/2] service: Add asserts that used to make tests/replacement.sh fail. Resent-From: Attila Lendvai Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 17 Dec 2023 00:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67839 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 67839@debbugs.gnu.org Cc: Attila Lendvai Received: via spool by 67839-submit@debbugs.gnu.org id=B67839.170277390425424 (code B ref 67839); Sun, 17 Dec 2023 00:46:02 +0000 Received: (at 67839) by debbugs.gnu.org; 17 Dec 2023 00:45:04 +0000 Received: from localhost ([127.0.0.1]:56381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEfHD-0006b4-TB for submit@debbugs.gnu.org; Sat, 16 Dec 2023 19:45:04 -0500 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]:54684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEfH8-0006Sj-6G for 67839@debbugs.gnu.org; Sat, 16 Dec 2023 19:44:59 -0500 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-552e5d0bee4so1459043a12.1 for <67839@debbugs.gnu.org>; Sat, 16 Dec 2023 16:44:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702773891; x=1703378691; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s5Mg/c4eypqbbjxhRJjH4V2CQgASghFd8RY2vK7nqvc=; b=SMb1s057xwPdxhaulCVC6y1GGnqzH86V9Z2XZoil7ShNiy3rZt5AodR1FwOgJIQl7I J407hYBWLxWcazDwF6d3dBfB6wZrFCaeeqSq5yPy7xpksRxbbz4uIr3vaQa6XCb2jKVL G9W8RE6M8p0ZDQgErBtVahHViLwpTJ9bYG5ZuAuV/yg2pfw+Wg2cRy9jyDu5ptaNKQVg HqmIGaeanAcZvxd0+OlJA+K7CnOJHfFVh2zhu4CSzmhBnRTSrZmFeE7qDWLp1y5L2Ee4 MLb6T2WVAdpZABK3P3Dh4cly2Tye84lrQ4K7SCxR1mMOZE+d4jQycwkSsfPvOd6sOLQt y+Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702773891; x=1703378691; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s5Mg/c4eypqbbjxhRJjH4V2CQgASghFd8RY2vK7nqvc=; b=rrqR6Y06MygLQjGkH5mnnCjnQf9IpHJ+1A+8zl9fNYE7hcT/L0R27MsC6Gc9NqsSIg pTfdv+6BcwPM3WIUxS11upMqgau4JWf0XXE4JhP1mx/ZxSDI4SkHoAveUurbFKqJiFwh SnkMQj64vtepS0K18gpJZetaW4vRqwbkmwlfDT42k7/hJ1912agSxkxe0YYgDSetzg1X IWdFIX5jFi6jjYItUucJup5OSWbpJdU7oGGRY0Qkl0/b+Px8cHKFBEV8Rmcs6Fbppt7J TJ6SDi8ftQ+HxI7AaEA5z2lr1nTEQCF/6QjyUi9WQEu2YODJis9qDwgs4tBete0gEPwc noJA== X-Gm-Message-State: AOJu0Yy1JHyooTTkYCndiPlQX3VRDtRAXFPoZDT4NaFzq7wXDFrCFJYi k16X4dQan1FkQ9X8LVrCTKF8gxRbAIbJeA== X-Google-Smtp-Source: AGHT+IHIE+wm1uvfAUHRGr3awQ7MWtagZYJmcxTqtE2E2Lo+dTFY8rFog04jOzmqbQ5F75aWD8IImA== X-Received: by 2002:a50:85ca:0:b0:551:14c0:7325 with SMTP id q10-20020a5085ca000000b0055114c07325mr5864079edh.40.1702773891376; Sat, 16 Dec 2023 16:44:51 -0800 (PST) Received: from lelap.lan (2a00-1f40-b161-900-9180-9bd5-ff71-193b.pool6.panelnet.hu. [2a00:1f40:b161:900:9180:9bd5:ff71:193b]) by smtp.gmail.com with ESMTPSA id t16-20020a056402241000b00552743342c8sm2960258eda.59.2023.12.16.16.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Dec 2023 16:44:51 -0800 (PST) From: Attila Lendvai X-Google-Original-From: Attila Lendvai Date: Sun, 17 Dec 2023 01:44:25 +0100 Message-ID: <20231217004424.28303-3-attila@lendvai.name> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231217004424.28303-2-attila@lendvai.name> References: <20231217004424.28303-2-attila@lendvai.name> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -4.57 X-Spam-Score: -4.57 X-Migadu-Queue-Id: 9084C38335 X-TUID: q+L61gEf+c1D * modules/shepherd/service.scm (spawn-service-controller): Add two asserts. This is the bug that causes `guix system reconfigure ...` to sometimes hang, and subsequently all shepherd commands, because a match-error flies out from the service-controller of a replaced service, and thus its fiber dies. These asserts get triggered without the previous commit that fixes the issue. --- modules/shepherd/service.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/modules/shepherd/service.scm b/modules/shepherd/service.scm index c3bdf44..0ee6929 100644 --- a/modules/shepherd/service.scm +++ b/modules/shepherd/service.scm @@ -382,9 +382,11 @@ denoting what the service provides." (define (spawn-service-controller service) "Return a channel over which @var{service} may be controlled." + (assert (current-process-monitor)) (let ((channel (make-channel))) (spawn-fiber (lambda () + (assert (current-process-monitor)) ;; The controller writes to its current output port via 'local-output'. ;; Make sure that goes to the right port. If the controller got a ;; wrong output port, it could crash and stop responding just because a -- 2.41.0