From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 2FziODHO3WRshwAASxT56A (envelope-from ) for ; Thu, 17 Aug 2023 09:37:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id uP+rNzHO3WRAFAAAG6o9tA (envelope-from ) for ; Thu, 17 Aug 2023 09:37:21 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6595633F51 for ; Thu, 17 Aug 2023 09:37:21 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=laesvuori.fi header.s=mail header.b=HHlVhWkB; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1692257841; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=stsb6xsh8GhY0GfikHaLaDP/nHQMvAkbL4ixJ3l1PvU=; b=L57l1QNpIsmnsxkQriZT67d8vYEn8roROxk+PUFEUvkq+FwpPcNZLrNiDbJU+wXGcHAAq9 2MKOz/eP7Mup+UH6XFL4nosjpZjnFmJbKyYS6DcBs9Z/1o1GV180Rwx2FBdG7HKPJ3DHlM pBDtGWOIZZrDh17WO/H4BQyElLM3xra++qAovcu1aN9JGzWAmywa2biYC503J+qG9GJato uDQP63Rt+guS9l1ArvkTFG7KdqWhGvTNj3XJRToLJyL2EdJVSm5/jvmGck4wGGH3kkyNwD wgEjRx3aOkFZF/zE5TkgQHWC/zAW9ijr7e+5o39NpQrW+mykIINQZzEl5pGzng== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=laesvuori.fi header.s=mail header.b=HHlVhWkB; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1692257841; a=rsa-sha256; cv=none; b=YPTaB50MH12jSECZZhkHO8AJW5FZPPwQ1dXwEKnztCeIhLUrVZDiXdsu2vVo+wr6xlj0r6 7dIdEDN5x3I/6fLVdH9AdgVPdHsMZrV58kDADgXYe71e2FxCtccz1U8AUgCEMgTJ9zTyww +2X/RmB9q95Y/C/2MJ1mSjUKRkOKas4FqYPSjpKTtrjU4qV9BaQ/DpoBm/x+w846SDnCzI xWd/1icOpnIljaMDgYmS01f1s0k+kVCu6H/LFT+21hoiVoHPes7ieNs63mM0j7hWvaoS5w /OZGvpkv3oQ5RZrzgFX0jdPzsa11wSSDXNQii89263GxzOP6VKcMiI5I7REAlQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWXZ2-0002da-4o; Thu, 17 Aug 2023 03:37:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWXZ0-0002dR-E3 for guix-patches@gnu.org; Thu, 17 Aug 2023 03:37:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWXZ0-00071m-5r for guix-patches@gnu.org; Thu, 17 Aug 2023 03:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qWXYz-0005Yf-Qn for guix-patches@gnu.org; Thu, 17 Aug 2023 03:37:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64765] [PATCH] gnu: home: zsh: Also load enviroment in non-login shells Resent-From: Saku Laesvuori Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 17 Aug 2023 07:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64765 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 64765@debbugs.gnu.org, =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Received: via spool by 64765-submit@debbugs.gnu.org id=B64765.169225780621341 (code B ref 64765); Thu, 17 Aug 2023 07:37:01 +0000 Received: (at 64765) by debbugs.gnu.org; 17 Aug 2023 07:36:46 +0000 Received: from localhost ([127.0.0.1]:42698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWXYk-0005Y9-60 for submit@debbugs.gnu.org; Thu, 17 Aug 2023 03:36:46 -0400 Received: from vmi571514.contaboserver.net ([75.119.130.101]:44984 helo=mail.laesvuori.fi) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWXYh-0005Y0-W7 for 64765@debbugs.gnu.org; Thu, 17 Aug 2023 03:36:44 -0400 Received: from X-kone (88-113-24-127.elisa-laajakaista.fi [88.113.24.127]) by mail.laesvuori.fi (Postfix) with ESMTPSA id 92ADB342466; Thu, 17 Aug 2023 09:36:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laesvuori.fi; s=mail; t=1692257816; bh=1U0Ol0vHj2JbpGvEn0WFgtkybLdHosqNcyaGQZobG+g=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=HHlVhWkBG3VPtkxW3ajr10BEa9jkYOW5dTNlVW9p8rQ47ceWZW3otaLoSHt5yY2Wr 9KU+WR/CU2/DMu0ZZ2EKjXM+8PMTJaMPVn3NAcweuAFOll5SWQmbEA2M1Kcjd7LL2q IKJOWuMTSfJUr9DXL0Ik8qqvL5UvMPmGyNBMJOd4= Date: Thu, 17 Aug 2023 10:36:40 +0300 Message-ID: <20230817073640.kowdgkn7fz3tatho@X-kone> References: <20230721105801.10840-1-saku@laesvuori.fi> <87bkg5h1vp.fsf@envs.net> <20230721144458.w3we4ve6oqw4m7pn@X-kone> <87sf8i3e8j.fsf_-_@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="47yxhyf2kujte4es" Content-Disposition: inline In-Reply-To: <87sf8i3e8j.fsf_-_@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Saku Laesvuori X-ACL-Warn: , Saku Laesvuori via Guix-patches From: Saku Laesvuori via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -8.22 X-Spam-Score: -8.22 X-Migadu-Queue-Id: 6595633F51 X-Migadu-Scanner: mx2.migadu.com X-TUID: SKdmNcGwArdy --47yxhyf2kujte4es Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > >> Hello, this looks reasonable to me, only one question: > >> Will ~/.guix-home/profile/etc/profile be sourced multiple times with > >> duplicated search-path entries? (eg: check 'env' in 'zsh' in 'zsh'). > > > > Yes, but I don't think it causes any problems aside from adding useless > > data to the environment. This could be prevented by exporting > > GUIX_PROFILE_SOURCED=3D1 or something similar and only sourcing profiles > > if it isn't set. >=20 > I doesn=E2=80=99t sound great though, and I=E2=80=99m sure it could break= obscure > things, like #include_next in C. >=20 > Is there a way this could be avoided? (I=E2=80=99m not familiar with Zsh= so I=E2=80=99m > not offering to help; just looking for pending patches to apply. :-)) It could be avoided properly by making guix-generated profiles ensure that they can't be sourced multiple times (e.g. [ -z "$GUIX_PROFILE_SOURCED" ] || return ; GUIX_PROFILE_SOURCED=3D1). The specific problem I was facing was with running commands with ssh, which the bash service seems to fix by sourcing /etc/profile from bashrc when used via ssh. I'll send a patch for this ssh-specific solution but I'm not sure if it's the best way to fix this. --47yxhyf2kujte4es Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoMkZR3NPB29fCOn/JX0oSiodOjIFAmTdzggACgkQJX0oSiod OjJsYxAAwhWQBEi+GwLPJNpEOnHhiO6HD6ZVNtfFNAYWTR09pzAGd9ZFTynlhJ33 weC2TxldDtQ4b0DjBfi6j1/zLUtzJOUSMBv3vlSvq4EsbOiRBJcnktkfLJPTvKEV 1snMVAftfaNuAD4CsX+M61AiOQIEiNKUiVzudxUgh+keJ1sLkfHX2DAdl8J2WkzM sLYzKvVOT8mtdOT2es4fNjdDHrbMSTM5QrDNae/CLAaA9Le8uoRhUImeN1NvDP8O 2RixZHHqLag1cGI20QnUSvaGxQx8k6rpqvsi1QCy570Ykxj1fHlFZdL/nPnEN0FB 8EriLLJn+lOb3wcRLM1UvPYXzyuornCiTRoTVv8xrVnKjFp2kXFN4e7rCZpZWMPN /o3+XuCKHLlpTDcKkwbV+pZWTUhZ5ws4/vK2UxUt6BaXe5gUPswIsTln1kPw9WqI TLs8thKBIUcMF3XJYgmyIHFmhsB+oXCsjma8+o+C4TTBGlVME2MBqKSTSYx7CKLZ VDHiVILOUEKidX2lhPvi0Ul2smcOAe34jMKE2jQq34D7slCD16oI+9jZjcEzDBt9 bXtKGB5nHiZ93cY9yqq05oqIm9+trKLVU8WDhFaASUzJynDDdwhIRYDqNCKqgEMG dtdXa8pZ+tpXgs+H+7G0BffXlFXbkblEr2SkRAtZunpC5IzdBag= =Akzn -----END PGP SIGNATURE----- --47yxhyf2kujte4es--