From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id GfJfCXAyumTsrwAASxT56A (envelope-from ) for ; Fri, 21 Jul 2023 09:23:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id cJChCHAyumQh5wAA9RJhRA (envelope-from ) for ; Fri, 21 Jul 2023 09:23:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA6444696E for ; Fri, 21 Jul 2023 09:23:27 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=laesvuori.fi header.s=mail header.b=NZaa6doc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689924208; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=GcpyiHJDUZy1/hYdAiq96cjjp1e8LmxwdGY7HGRC+zs=; b=PLu7neYrvCJH6YT3IIX3Nmrk6IDxMAZryLS7zT0icnNeo2aOsdSDdzyQrUli6KWQl/peDl VkSucEKpGyIwqV5pflzw5QU6fauzPDRI977SLC+ZgSZ+b/hTY9pSh4z6exexKScP6LDVRL 8FbMcFiEZyfi64iRxVHmcL06nQ9nEEdzWYzQhfjc3c4yqPmG/pB6AKGvC9xzXCAxUdi63Q twlA11y0+oAvnZXkab1QRo1yVzvqFN//X6a1gszlYoqob3tGeNllAoJVEjiR2jzngPyCSg n3wlg6TYbdikJhu4qghaGp4Xjz94FL0LvtrEYucnijYZjIHy+kYmnWRksUrnew== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689924208; a=rsa-sha256; cv=none; b=swRtxXxsZFYXD2XE7XtByxzNDc1BQDJwkXdR1yWOGRzrWNvhTl4IQqYB1dBdmONT67FlJu q4JbbF52YOrbdDctO9Dg/Jiv2Lj6cNdwN8bmf2RLTD8gQb2VVqRK2D2iQpSJ4VuIQMKDXi 6hrHa2dSjWI4Wg7+XmeMlTNpmw6a5CixLe1PvMBgqDcWUv8LBEbMtlPqotKdGfpLTX3XsI lYjvtlh9zKnEnDkwDbrZUweo9KoM3vb7AUCeO0eKdTc1M5ajRvumqcL+ktsWnco1aW9qyd srACAf2E1a/kBEMnuFpWwHsUcGMGHvrjV9gWLYaDrKVOEDssiL+aDCCwhktitg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=laesvuori.fi header.s=mail header.b=NZaa6doc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMkTk-0003TK-9V; Fri, 21 Jul 2023 03:23:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMkTh-0003Qi-7Q for guix-patches@gnu.org; Fri, 21 Jul 2023 03:23:05 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMkTe-0000ra-DD for guix-patches@gnu.org; Fri, 21 Jul 2023 03:23:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMkTe-0004zF-0l for guix-patches@gnu.org; Fri, 21 Jul 2023 03:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8 Resent-From: Saku Laesvuori Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 21 Jul 2023 07:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64748 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Distopico Cc: rg@raghavgururajan.name, 64748@debbugs.gnu.org, hako@ultrarare.space Received: via spool by 64748-submit@debbugs.gnu.org id=B64748.168992417519156 (code B ref 64748); Fri, 21 Jul 2023 07:23:01 +0000 Received: (at 64748) by debbugs.gnu.org; 21 Jul 2023 07:22:55 +0000 Received: from localhost ([127.0.0.1]:60432 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMkTW-0004yt-O9 for submit@debbugs.gnu.org; Fri, 21 Jul 2023 03:22:54 -0400 Received: from vmi571514.contaboserver.net ([75.119.130.101]:45674 helo=mail.laesvuori.fi) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMkTR-0004yc-6P for 64748@debbugs.gnu.org; Fri, 21 Jul 2023 03:22:53 -0400 Received: from X-kone (88-113-24-127.elisa-laajakaista.fi [88.113.24.127]) by mail.laesvuori.fi (Postfix) with ESMTPSA id 310B934013B; Fri, 21 Jul 2023 09:22:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laesvuori.fi; s=mail; t=1689924167; bh=GcpyiHJDUZy1/hYdAiq96cjjp1e8LmxwdGY7HGRC+zs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=NZaa6docDIJ5tBJr26sCZVCca9daixllUgxfU1BZ6m1TK0mwaLfH+iizUxh6ysgUc rfRdXngHIA6XdJVhGQtOIz+RO1If5txFoP9HE3YGnL+1ToxDA5nEU2qYnxtIudWMfA Cz6NUMVsUHNVARDhwnlRbzMlCQzjGx1e6qGdmpDg= Date: Fri, 21 Jul 2023 10:22:42 +0300 Message-ID: <20230721072242.eso6juxdbhpdkgex@X-kone> References: <20230720171841.31901-1-distopico@riseup.net> <20230720193353.gb75xe2ywl6nfvnr@X-kone> <87a5vq9vr7.fsf@riseup.net> <20230720210600.2zwjtcdnoa63rmo4@X-kone> <87zg3q897e.fsf@riseup.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nmk3rybonqm3bbd6" Content-Disposition: inline In-Reply-To: <87zg3q897e.fsf@riseup.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Saku Laesvuori X-ACL-Warn: , Saku Laesvuori via Guix-patches From: Saku Laesvuori via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -8.24 X-Spam-Score: -8.24 X-Migadu-Queue-Id: DA6444696E X-TUID: H/og1QCkued4 --nmk3rybonqm3bbd6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > You would probably have to patch the `CMakeLists.txt` so it doesn't try > > to build libsrtp from source, see what I did with crc32c in the > > mentioned commit for reference. It is quite possible that telegram > > doesn't actually need the source code and they are simply using a git > > submodule to simplify their own dependency versioning and development. > > > > You might also have to add a new libsrtp version because the one > > packaged in Guix is not configured to use openssl unlike telegram > > expects. I'd still try the packaged version first if compiling telegram > > a few more times isn't a big problem for you. > > I tried but didn't work, this change is similar to **libyuv**, that have > reference to the source code of that external library: example > https://github.com/desktop-app/tg_owt/blob/83-sdk/src/api/video/i010_buff= er.cc#L17 >=20 > So the case of **libsrtp** is similar, check for example: > - https://github.com/desktop-app/tg_owt/blob/master/src/pc/srtp_session_u= nittest.cc#L25 > - https://github.com/desktop-app/tg_owt/blob/master/src/pc/external_hmac.= cc#L18 > - https://github.com/desktop-app/tg_owt/blob/master/src/pc/BUILD.gn#L174 >=20 > So change that will require patch several files, not just > `CMakeLists.txt`, patch all those file will be make this package hard to > maintain. I see. I think libsrtp is small enough that unbundling it is not worth the effort of patching all those files. --nmk3rybonqm3bbd6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoMkZR3NPB29fCOn/JX0oSiodOjIFAmS6MkIACgkQJX0oSiod OjIGjQ/+KjHeivW0+qMqq9ETAM+lD0KreJhD3Yo/x3v4iGlnIeHX7v5KZtNz8PpP T4rr9BfOpaK3LeUCfK/PFg8cfT5uUC4BZW0JiIe0pLXSpRjAUJkF/oIdJ513qVnw 8oENZi6HdjgcqAjmtuzw3JCGpHrk5gn0DL44b3fQ8ET3XzhBBle+Ofa0rUColC+V 8cKV9n4ur+zdDLGtwFwp2zKj3MnOiSOhE9fkIY89xLz4uB4lvOQp9e5Vdi/vIMPL gxvZlIy1k82uwdwQQYlSjC6M+0tDDMqubEKuF/3Bltu52yll2d8dpwIe/jTOYbs1 gLrWMhoogw1Q+ErfxnKKSUppzK5NdyV+Bah1mG8n9Grb3ESUiM0kJXzGoFac7puM shmV/VLiPDtbHQJZliGogQJpSkoWdrHdG6Ay3kFK0zlUBrndJ+sNr+LVY4RkbfWe lmb5O/0FU3C8lv6P9kJgVjXIG2/w4tz2tK0XPoDy7aTxz02aBXM0xrLZceCDkvFc uUj0gTvDWmqah90Qrj5j3vRHZsHbxiyV3NSCZ1yaS6ax3/yhB3vcHJmBxw+sjGT3 pKTZ09eDdCZvywa058gyyXETWbGthijhquFEJ6RZkyQ54gsnmCO1rbR1Kn/ik4O3 cGCa+ffThBVZVAc8MiqzAFEKmUL9TMOP/3EmgMQzrEpNDPvvb+A= =nkoj -----END PGP SIGNATURE----- --nmk3rybonqm3bbd6--