From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CFsMHQWiuWQeeAEASxT56A (envelope-from ) for ; Thu, 20 Jul 2023 23:07:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aKoRHQWiuWSfWQAAauVa8A (envelope-from ) for ; Thu, 20 Jul 2023 23:07:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 24F6C3D0CE for ; Thu, 20 Jul 2023 23:07:17 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=laesvuori.fi header.s=mail header.b=tbg2ToT4; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1689887237; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=0IKiyodVwGz9z5Z6VBAC9QeTPDxVSq9fQwpW7auRoiA=; b=sZelGQ29La99vMm+LpDqq8F+wOq0rslEAaTQXEAZmebyjX3cAkZ2b/CXC02YGmTNnNJESd haSXDHr4ZkbJHsk/fcdC/N6IUn94QPc/pkOrq872k3sDb5R9JOOGCGf36xY8PPOdLqUFRR xn+KoEHM5t41Lw5ma7MJJ2BKpDoqqtsduRFJoc/UZDrRQv7vSDxkMqm3PjKHOftSYe0I1T m2bMWkpDbgd8mCk7+k2GRFhMH9zsF15180pQauJ4SYTsQ2svTJFWTEvDwyXqpiO4iPMjlb wOBsIIkxcWyvEqAu4I9rB65j8ynCxZlCZ69csL39Hwcy7grxrbPTGPqGnkYEgw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689887237; a=rsa-sha256; cv=none; b=ufoh4BCEi0HYvmM1KlzBFa4Rpx2ZdYp0R8ZCNEG37i0VuezcYbIjWX0rlens5ns/MMb3Zi Q1SEAoEybNtvNddFv9nl+NL5LmA+ajiQqVaSZaCwExa8y/Uh1xPNhPB7Z+l81aA45zD+yu Rcbtp7irb9WREJw5hjlHYdIxrNV1UP5KCJMCBkRIqMWg1oJE/Nv2/jeZObebaDEqDYBFdI vTKEqbvJrgXjHF6cwInox9qk+YMnfrD4w2766sIXLxGybYxJ70DdBnDcWqCBHzV6p8zyPb 5B0CGgC6AnNr7ba8fFrE+wOtslgnxaYJ7OIVyvD2lzv1Kttq/AY0lSEJ4RYXjw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=laesvuori.fi header.s=mail header.b=tbg2ToT4; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMarZ-0005H0-6R; Thu, 20 Jul 2023 17:07:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMarW-0005Gr-RS for guix-patches@gnu.org; Thu, 20 Jul 2023 17:07:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMarW-0006HV-Ih for guix-patches@gnu.org; Thu, 20 Jul 2023 17:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMarW-0001HI-E5 for guix-patches@gnu.org; Thu, 20 Jul 2023 17:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64748] [PATCH] gnu: webrtc-for-telegram-desktop: Update to a45d8b8 Resent-From: Saku Laesvuori Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 20 Jul 2023 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64748 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Distopico Cc: rg@raghavgururajan.name, 64748@debbugs.gnu.org, hako@ultrarare.space Received: via spool by 64748-submit@debbugs.gnu.org id=B64748.16898871704847 (code B ref 64748); Thu, 20 Jul 2023 21:07:02 +0000 Received: (at 64748) by debbugs.gnu.org; 20 Jul 2023 21:06:10 +0000 Received: from localhost ([127.0.0.1]:60095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMaqf-0001G7-V5 for submit@debbugs.gnu.org; Thu, 20 Jul 2023 17:06:10 -0400 Received: from vmi571514.contaboserver.net ([75.119.130.101]:34180 helo=mail.laesvuori.fi) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMaqa-0001Fs-Rr for 64748@debbugs.gnu.org; Thu, 20 Jul 2023 17:06:08 -0400 Received: from X-kone (88-113-24-127.elisa-laajakaista.fi [88.113.24.127]) by mail.laesvuori.fi (Postfix) with ESMTPSA id 9001434012E; Thu, 20 Jul 2023 23:06:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laesvuori.fi; s=mail; t=1689887163; bh=0IKiyodVwGz9z5Z6VBAC9QeTPDxVSq9fQwpW7auRoiA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=tbg2ToT4BzsdzsZZJYLoCuOuoIitdQdUtlwJL7jEMR83/kHCHkqFJmG/4bExeNcPB YamPmMrt2nKG1Kx7PZCRpmw4d5nbF/FBB70DetVGp6rqNzs+PSO2LhYBfRPuJIT1D5 l3cTaR+y9sXoYz2jraHyaD1lbywNV4b7fqWsgTQE= Date: Fri, 21 Jul 2023 00:06:00 +0300 Message-ID: <20230720210600.2zwjtcdnoa63rmo4@X-kone> References: <20230720171841.31901-1-distopico@riseup.net> <20230720193353.gb75xe2ywl6nfvnr@X-kone> <87a5vq9vr7.fsf@riseup.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4wbsuxwec63fmkpp" Content-Disposition: inline In-Reply-To: <87a5vq9vr7.fsf@riseup.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Saku Laesvuori X-ACL-Warn: , Saku Laesvuori via Guix-patches From: Saku Laesvuori via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -8.26 X-Spam-Score: -8.26 X-Migadu-Queue-Id: 24F6C3D0CE X-Migadu-Scanner: mx1.migadu.com X-TUID: TzVVX5cJ45cN --4wbsuxwec63fmkpp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > You should probably mention adding `libsrtp-for-telegram-desktop` in the > > ChangeLog. >=20 > Looks like it's not longer necessary, Changelog is auto-generated, that > said in the main Changelog I mean the commit message. Now your commit message's ChangeLog only mentions updating webrtc-for-telegram-desktop. See my last telegram commit 6192acf8b77 for an example of what I'm talking about. I would assume the ChangeLog file is autogenerated based on the commit messages. > > Have you tried using the libsrtp version packaged in Guix as an input to > > `webrtc-for-telegram-desktop` instead of bundling it? If that doesn't > > work, have you tried packaging libsrtp 2.5.0 and using it as an input? > > It would probably be relatively easy with record inheriting. > > > > I'm quite new to Guix (and couldn't push changes even if they were > > perfect) so someone else might have more comments on this. >=20 > I tried but it require source code inside libsrtp folder, for example > '/crypto/cipher/cipher.c', also libsrtp package is the compiled version > and webrtc-.. require source code from libsrtp. You would probably have to patch the `CMakeLists.txt` so it doesn't try to build libsrtp from source, see what I did with crc32c in the mentioned commit for reference. It is quite possible that telegram doesn't actually need the source code and they are simply using a git submodule to simplify their own dependency versioning and development. You might also have to add a new libsrtp version because the one packaged in Guix is not configured to use openssl unlike telegram expects. I'd still try the packaged version first if compiling telegram a few more times isn't a big problem for you. --4wbsuxwec63fmkpp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoMkZR3NPB29fCOn/JX0oSiodOjIFAmS5obgACgkQJX0oSiod OjLtYhAAkwEa3lmWT7nOp+QuXf6nbvZ4m2FRmv5/9zIjcsPDyidA2LC3H1dLsz1l ICdPDx/ZwhP0HBwiorCl31om8gMXLlD7nSgp4I+5swsoRuOGnYZ9FabTNrnxZkHT CAR02LI+QtjOr1Cwu1nmfhcEQJt31voLFVkJMXXDobaDMs35tFccCAunbh5ExVgI JUjuufX1JzKytDLxMpT5szLwKf5OGDz7oqbCimZALyb7aX/UYkyNQqoGvOJwA5wP QUx275hrYNKmpGmxV9tcTf9jM6gcPoVi2v7yLKUTgp2RRu/b9wqQ8pjW5Xc1ECd8 L/juoJf30RDvpHWd/ff+gacfvu723AV6tJBSTLbtAdTXLDnTBGCXoMBx0nFiZwGE MuVBssEhJnWZSXtcJz/hyQK75FjQD8Nr5BpZ4/F3Slj72i+5L4qgFQL62c4w9It1 saJJEXxkHAX6bK/gG1A+nLup4wTeVOfojLCZn5LL+AEdXvbTFNL1UF3ocqNNrHNr q91N8z8hyDgE6DpVCqJ1ZHJjJtU1dPdJz+odBi8eMZQL46tZ6RqMm3XFCG2IMdWe OoJ/59Lp5Dj8oWsVRjdsHDYkxihva+rbttnnLvONj8kODm8f+ZXSmBQmXIeai0g1 9uT7CmL7y6EIKzm6XM2A7zrJqM/VTzmXvhKP8pJLgDKIW0FZyJM= =Kg9Y -----END PGP SIGNATURE----- --4wbsuxwec63fmkpp--