all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Sergei Trofimovich <slyich@gmail.com>
To: "jgart" <jgart@dismail.de>
Cc: 63893@debbugs.gnu.org
Subject: [bug#63893] gnu: nix: Update to 2.16.1
Date: Tue, 27 Jun 2023 08:05:42 +0100	[thread overview]
Message-ID: <20230627080542.6e7ed518@nz> (raw)
In-Reply-To: <6616df3cc64662087b859521664f3387@dismail.de>

On Tue, 27 Jun 2023 06:03:03 +0000
"jgart" <jgart@dismail.de> wrote:

> > Those look good to me. I did not runtime-test it though.  
> 
> Hi Sergei,
> 
> Thanks for the message.
> 
> Are you running the tests successfully for rapidcheck in your ebuild version? 

I do not enable `rapidcheck` tests. At least in theory enabling tests
via `-DRC_ENABLE_TESTS=ON` should be enough. In practice
`ext/CMakeLists.txt` implies a certain layout of `check2`, `gtest` and
`boost` dependencies checked out locally:

  git submodule:

    if (RC_ENABLE_TESTS OR RC_ENABLE_CATCH)
      add_subdirectory(catch)
    endif()

  another git submodule:

    if ((RC_ENABLE_GMOCK OR RC_ENABLE_GTEST) AND RC_ENABLE_TESTS)
      # On Windows, gmock/gtest defaults to static CRT which is not compatible
      # with the way RapidCheck is currently built
      set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
      add_subdirectory(googletest)
    endif()

  ad-hoc checkout with a stand alone script:

    if (RC_ENABLE_BOOST AND RC_ENABLE_TESTS)
      if (NOT EXISTS "${CMAKE_CURRENT_LIST_DIR}/boost")
        execute_process(
          COMMAND "sh" "get_boost.sh"
          WORKING_DIRECTORY "${CMAKE_CURRENT_LIST_DIR}")
      endif()
      add_library(boost INTERFACE)
      target_include_directories(boost INTERFACE boost)
    endif()

I did not try to satisfy these requirements. Ideally upstream should be
fixed to use already installed libraries. But I'm not very well versed
in `cmake` to propose such a change just yet.

> I don't know portage, unfortunately.
> 
> We'd like to get the tests running and passing for rapidcheck but they are currently disabled because we are not sure how to run the test suite for rapidcheck.
> 
> Have you had any success running the tests for rapidcheck?
> 
> all best,
> 
> jgart (Jorge)

-- 

  Sergei




  reply	other threads:[~2023-06-27  7:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-04 16:29 [bug#63893] [PATCH]: gnu: nix: Update to 2.16.0 Zhu Zihao
     [not found] ` <handler.63893.B.168589626726853.ack@debbugs.gnu.org>
2023-06-04 16:37   ` [bug#63893] Acknowledgement ([PATCH]: gnu: nix: Update to 2.16.0.) Zhu Zihao
2023-06-04 16:41 ` [bug#63893] [PATCH 1/3] gnu: Add rapidcheck Zhu Zihao
2023-06-04 16:34   ` [bug#63893] [PATCH 3/3] gnu: nix: Use HTTPS for package source Zhu Zihao
2023-06-04 16:43   ` [bug#63893] [PATCH 2/3] gnu: nix: Update to 2.16.0 Zhu Zihao
2023-06-11 14:11 ` [bug#63893] [PATCH v2 1/2] gnu: Add rapidcheck jgart via Guix-patches via
2023-06-11 14:11   ` [bug#63893] [PATCH v2 2/2] gnu: nix: Update to 2.16.1 jgart via Guix-patches via
2023-06-13  9:17     ` Zhu Zihao
2023-06-11 14:29 ` [bug#63893] [PATCH v3 1/2] gnu: Add rapidcheck jgart via Guix-patches via
2023-06-11 14:29   ` [bug#63893] [PATCH v3 2/2] gnu: nix: Update to 2.16.1 jgart via Guix-patches via
2023-06-19 15:47     ` Zhu Zihao
2023-06-24 17:12     ` jgart via Guix-patches via
2023-06-24 17:20     ` jgart via Guix-patches via
2023-06-24 19:34       ` Sergey Trofimov
2023-06-25  3:01       ` jgart via Guix-patches via
2023-06-26 21:41 ` [bug#63893] " jgart via Guix-patches via
2023-06-26 22:16   ` Sergei Trofimovich
2023-06-27  6:03   ` jgart via Guix-patches via
2023-06-27  7:05     ` Sergei Trofimovich [this message]
2023-07-12  4:00 ` bug#63893: [PATCH v3 2/2] " jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230627080542.6e7ed518@nz \
    --to=slyich@gmail.com \
    --cc=63893@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.