From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id MORgISvpdWRvWgEASxT56A (envelope-from ) for ; Tue, 30 May 2023 14:16:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id EORTISvpdWQoMQEA9RJhRA (envelope-from ) for ; Tue, 30 May 2023 14:16:43 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 50DAD116AA for ; Tue, 30 May 2023 14:16:43 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q3yGs-0005nH-3F; Tue, 30 May 2023 08:16:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q3yGg-0005eg-Kj for guix-patches@gnu.org; Tue, 30 May 2023 08:16:08 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q3yGg-0006Fs-CL for guix-patches@gnu.org; Tue, 30 May 2023 08:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q3yGf-0004zg-Rt for guix-patches@gnu.org; Tue, 30 May 2023 08:16:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63802] [mumi PATCH 1/3] client: Do not pass --add-header to git send-email. References: <20230530121132.26057-1-arunisaac@systemreboot.net> In-Reply-To: <20230530121132.26057-1-arunisaac@systemreboot.net> Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 30 May 2023 12:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63802 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63802@debbugs.gnu.org Cc: Arun Isaac , Maxim Cournoyer Received: via spool by 63802-submit@debbugs.gnu.org id=B63802.168544892019114 (code B ref 63802); Tue, 30 May 2023 12:16:01 +0000 Received: (at 63802) by debbugs.gnu.org; 30 May 2023 12:15:20 +0000 Received: from localhost ([127.0.0.1]:60365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3yFz-0004yD-Lr for submit@debbugs.gnu.org; Tue, 30 May 2023 08:15:20 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:37734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q3yFx-0004y1-3I for 63802@debbugs.gnu.org; Tue, 30 May 2023 08:15:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yUlYpvfQWxzu+iyIo3RJYtjbgXmZFCK8ueJflisrn/Y=; b=Jy36cEjs5oXwUbUuJC2dXwyphn rM0ew37HoTMPlszbQmNp4Rur7TtuGTZl/GO1Yjh9fsKuAoi+DvgPEE5PCakfsnonkzt8/5Ao5ouWY AU04BbFmFiHyuWEBtxmAScL3MnaMyMlazzvSS6nIQmVcyh/ORm+sxEs/JRWRgcSX8bkgUdSOC/t0E Wh19Vb9Qt4Vp7ymhSKDGGEJNIeujfntAXlJx4p/FO8nXBelHfF7Q0FdJ4PAaxT/uy0O5w5uR2QE2L owFZSnrhX4RpAX9t5L5y2kPOUWU7XIxK9PX8iKGkuubC7gP5l2sy3OBOKHRZeAlT5KEDIei5SodyW poR0V28Q==; Received: from [192.168.2.1] (port=38898 helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1q3yFq-001s3y-1K; Tue, 30 May 2023 13:15:11 +0100 From: Arun Isaac Date: Tue, 30 May 2023 13:14:45 +0100 Message-Id: <20230530121447.26236-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1685449003; a=rsa-sha256; cv=none; b=PYJebxp95DwIdo5ITfZ2Fhj8VJzVws2t9MV8tfFEdRphJaRr9bosY52+RzjtdhGeDdl0gR eJ2M4G7pVXgONfeoXTVlWZSmmfZKkyJs1UxSg9lpvXyE3/l2EzIRnovkX1uV6wyiRsXoKK yK9i/dymLPC/oty/f0LiZSc9Bo3PzKZOGeuKOxJJsd2uq+r1ac7Unl6dt1yhDSUcJq4WzA /WyhK9/FjGUgSR+2spVzuEUb7E5oMkeAYz2yUWsA80DPwvAox+YBN7BXh9+BoLpOHdIkCv 5Zr4c60i6Azneccb9XkkphlI18jcXZP8pVO28dokcQHRy9vpn/1x8qdFxK4fig== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=Jy36cEjs; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1685449003; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yUlYpvfQWxzu+iyIo3RJYtjbgXmZFCK8ueJflisrn/Y=; b=fHzfrZL5jhXwuMMUpRenfeXYCtObZHOEBdIt9KaATTjjOQl5hnTeAoj5JlmwXZGd/TQ4kC AZAG79toFPcFZtSKPVevAqsDtSTauwhJUqAjVV8HIV5CEkxFhfKbgIAO4L8bkkKe+Payer eI48guJHQa4bz60u02A/nLebb3hodc0MzcdgeGqRsGuN1ICdXqHop1vQyR8AWM29boih74 KMv2ecnlpbS0KpNtSPdKMoEcSw0pO+/Cj/nKe8vdAif/K0UsofjEmEk95u9gMjJc2Suqtq evDWZLCEN5SsXxQ9EipQEUnKzvdpk3B84aeykK7LvzeOPtkOwkkwfaiHWYBGFg== X-Migadu-Spam-Score: 1.89 X-Spam-Score: 1.89 X-Migadu-Queue-Id: 50DAD116AA X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=Jy36cEjs; dmarc=fail reason="SPF not aligned (relaxed)" header.from=systemreboot.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: sWis+tuM6D5I git send-email accepts --add-header only when passed a git format-patch style revision list. * mumi/client.scm (send-email): Do not pass --add-header to git-send-email. * tests/client.scm ("send patch to existing issue and Cc other participants"): Do not expect --add-header. --- mumi/client.scm | 5 +---- tests/client.scm | 6 +----- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/mumi/client.scm b/mumi/client.scm index b575daa..5befd42 100644 --- a/mumi/client.scm +++ b/mumi/client.scm @@ -287,10 +287,7 @@ ISSUE-NUMBER." (git-send-email (string-append (number->string issue-number) "@" (client-config 'debbugs-host)) - patches - (map (cut string-append "--add-header=X-Debbugs-Cc: " <>) - (assq-ref (reply-email-headers issue-number) - 'cc)))) + patches)) (match patches ;; If it's a single patch, send it to the patch email address ;; and be done with it diff --git a/tests/client.scm b/tests/client.scm index 5729521..5352b08 100644 --- a/tests/client.scm +++ b/tests/client.scm @@ -126,11 +126,7 @@ called with." (list "foo.patch"))))))) (test-equal "send patch to existing issue and Cc other participants" - '(("git" "send-email" - "--to=12345@example.com" - "--add-header=X-Debbugs-Cc: John Doe " - "--add-header=X-Debbugs-Cc: Mary Smith " - "foo.patch")) + '(("git" "send-email" "--to=12345@example.com" "foo.patch")) (map (match-lambda ((command _) command)) (trace-calls (var@@ (mumi client) call-with-input-pipe*) -- 2.39.2