From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id sHk3MJsjMGTfWQEASxT56A (envelope-from ) for ; Fri, 07 Apr 2023 16:07:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id yAUmL5sjMGSyIwAAG6o9tA (envelope-from ) for ; Fri, 07 Apr 2023 16:07:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 71F2B39A0B for ; Fri, 7 Apr 2023 16:07:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkmk8-0004Cr-P9; Fri, 07 Apr 2023 10:07:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkmk2-0004CJ-CG for guix-patches@gnu.org; Fri, 07 Apr 2023 10:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkmk2-00033k-4L for guix-patches@gnu.org; Fri, 07 Apr 2023 10:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkmk1-0003Uk-OT; Fri, 07 Apr 2023 10:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62712] [PATCH 0/2] Disable keyword expansion for Subversion downloads Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: samplet@ngyro.com, zimon.toutoune@gmail.com, guix-patches@gnu.org Resent-Date: Fri, 07 Apr 2023 14:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62712 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62712@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Timothy Sample , zimoun X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Timothy Sample , zimoun Received: via spool by submit@debbugs.gnu.org id=B.168087636813239 (code B ref -1); Fri, 07 Apr 2023 14:07:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Apr 2023 14:06:08 +0000 Received: from localhost ([127.0.0.1]:56943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkmj9-0003RR-W4 for submit@debbugs.gnu.org; Fri, 07 Apr 2023 10:06:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:38796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkmj7-0003R9-R6 for submit@debbugs.gnu.org; Fri, 07 Apr 2023 10:06:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkmj7-00044n-FL for guix-patches@gnu.org; Fri, 07 Apr 2023 10:06:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkmj6-0002v2-M1; Fri, 07 Apr 2023 10:06:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=cWlmENraqsPJYREFIMSOaWM8IxkCu/5zojV3MyRYjII=; b=Il06KWFkH9nK4+ JRMgSBfmqlTM0Z3fIhhZoWwhGNDPn3c14AT/P2Jy+dFA4kON4hlKPV83NA8wNhQHIGnHdLyL4nBCQ VvgWDBxvGrulHi8L5CKSw1bcKSMLrkC3D1qh1vR8q8Gnq0A/V4t/9H87lX1gjhaZSaCQJuqwwomul 2r2Ixn9DzNVcXmDBjQB31fm0yXDvwhhfFZXxjwQsmwgcxBpfYHiRqPlRZgZbcT1H+/PUdmSkOW1aP urhSdpKXUDcv4r1XyZ2jm/GUs+2sMgMQQVzlqjKz8dZwGZHonnqePv/pVlvkw5r0fHTATg7aY5167 P0HPMPm+r/aU1gE62qkA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkmj1-0006P9-I5; Fri, 07 Apr 2023 10:06:03 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Fri, 7 Apr 2023 16:05:51 +0200 Message-Id: <20230407140551.8776-1-ludo@gnu.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680876443; a=rsa-sha256; cv=none; b=nLVpRygYcLXi6ChwSCfNhKKWAWEOTOR37hxkgGjSjmWM1WwQMRiUQcAGt/jpt1zAWDUDX+ a5iPyR+dlb7YhmWYLmHPOEyCA0I6hb7XA8wHr5GOJVndg4odpaJPxraozOiEScvF11o35j Y6Wl+1XELSePqpcLJ1SvICgXzjmMzR/izXah9QnmZG8EwBnKX+v4hNYz+uVienZNW4a6EO H0M1wvWnQcNKOUHUft7HMwsXZeNUW8+v2r/m6y988yzKNExN2SWo37J2GINqEwp8wFwOkL W2QsNkLJzyhU0bMJZ6sKlMYw1QXwfqY+wqiY7MSKCjiY4u5bM1uHXxgl60Fp8A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Il06KWFk; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680876443; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=cWlmENraqsPJYREFIMSOaWM8IxkCu/5zojV3MyRYjII=; b=JwFPvBdTWsQbyRVbSjqlB+sqfr8GROY5WFKypAKeSCJHgU1U0xjFnF2nHSMsvmEuTw/nWT SVzYOVPFGT90ZTVe0avr+5hcxjmqO9mK47eUMuGDwBkSEYrAkFG98oINDsTIbnLLy7txTK 2n2/wf0WzjUNUdxuFlf7vQO7RW1gImxiYdZlIkcig2VZiREBWZcgYxXI6fNNK+9s2JQU18 LH4KspJKUCM/0QHZhfyb3BXM9KSOzIjDVKbi3L6RD7ysf1yulTCa+WLyuYn8BTZE3cVmEC 2zhMNVApQSDGsWCTFJusT9Cwdhtid5ARX6zHmbzlYcYrPdNXOPSsddoVnzYV8w== X-Migadu-Spam-Score: -0.12 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Il06KWFk; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Spam-Score: -0.12 X-Migadu-Queue-Id: 71F2B39A0B X-TUID: RlkYeNfuiK4/ Hello Guix! As discussed in , SVN keyword expansion during checkout is problematic because it depends on local timezone. This in itself isn't really a problem in Guix because the timezone in the environment of fixed-output derivations is always UTC. However, SWH disables keyword expansion (for this reason), and thus it makes sense to follow suit. Disabling keyword expansion entails many rebuilds. However, these are "safe", so I'd like to have them on a branch (or simply handled by qa.guix) that we'd merge as soon as it's built. The second patch makes ‘recursive?’ default to #f, which AFAICS is what all the SVN-using packages that were not explicit expected (no changes required). Thoughts? Ludo’. Ludovic Courtès (2): svn-download: Disable keyword expansion. svn-download: Default to non-recursive checkouts. gnu/packages/java.scm | 2 +- gnu/packages/machine-learning.scm | 2 +- gnu/packages/tex.scm | 16 ++++++++-------- gnu/packages/video.scm | 4 ++-- guix/build/svn.scm | 9 ++++++++- guix/svn-download.scm | 6 +++--- 6 files changed, 23 insertions(+), 16 deletions(-) base-commit: 47fe66586e0fbc177288ec91cc88ea0b081505b0 -- 2.39.2