all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: 62712@debbugs.gnu.org
Cc: "Ludovic Courtès" <ludo@gnu.org>,
	"Timothy Sample" <samplet@ngyro.com>,
	zimoun <zimon.toutoune@gmail.com>
Subject: [bug#62712] [PATCH 0/2] Disable keyword expansion for Subversion downloads
Date: Fri,  7 Apr 2023 16:05:51 +0200	[thread overview]
Message-ID: <20230407140551.8776-1-ludo@gnu.org> (raw)

Hello Guix!

As discussed in <https://issues.guix.gnu.org/43442>, SVN keyword
expansion during checkout is problematic because it depends on local
timezone.  This in itself isn't really a problem in Guix because
the timezone in the environment of fixed-output derivations is
always UTC.  However, SWH disables keyword expansion (for this
reason), and thus it makes sense to follow suit.

Disabling keyword expansion entails many rebuilds.  However, these
are "safe", so I'd like to have them on a branch (or simply handled
by qa.guix) that we'd merge as soon as it's built.

The second patch makes ‘recursive?’ default to #f, which AFAICS
is what all the SVN-using packages that were not explicit expected
(no changes required).

Thoughts?

Ludo’.

Ludovic Courtès (2):
  svn-download: Disable keyword expansion.
  svn-download: Default to non-recursive checkouts.

 gnu/packages/java.scm             |  2 +-
 gnu/packages/machine-learning.scm |  2 +-
 gnu/packages/tex.scm              | 16 ++++++++--------
 gnu/packages/video.scm            |  4 ++--
 guix/build/svn.scm                |  9 ++++++++-
 guix/svn-download.scm             |  6 +++---
 6 files changed, 23 insertions(+), 16 deletions(-)


base-commit: 47fe66586e0fbc177288ec91cc88ea0b081505b0
-- 
2.39.2





             reply	other threads:[~2023-04-07 14:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-07 14:05 Ludovic Courtès [this message]
2023-04-07 14:07 ` [bug#62712] [PATCH 1/2] svn-download: Disable keyword expansion Ludovic Courtès
2023-04-07 14:07   ` [bug#62712] [PATCH 2/2] svn-download: Default to non-recursive checkouts Ludovic Courtès
2023-04-07 16:54   ` [bug#62712] [PATCH 0/2] Disable keyword expansion for Subversion downloads Timothy Sample
2023-04-08 21:23     ` Ludovic Courtès
2023-04-09 21:31       ` Christopher Baines
2023-04-12 13:49         ` Christopher Baines
2023-04-20  9:57           ` Ludovic Courtès
2023-04-25 12:41             ` Simon Tournier
2023-05-05 14:09             ` Simon Tournier
2023-05-06  0:22               ` Nicolas Goaziou
2023-05-09 12:22                 ` Simon Tournier
2023-05-10 16:22                   ` Ludovic Courtès
2023-05-11 21:40                     ` Nicolas Goaziou
2023-05-12 11:45                       ` Christopher Baines
2023-05-15 15:50                         ` Nicolas Goaziou
2023-05-16  9:54                           ` Christopher Baines
2023-06-18 21:21                             ` bug#62712: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230407140551.8776-1-ludo@gnu.org \
    --to=ludo@gnu.org \
    --cc=62712@debbugs.gnu.org \
    --cc=samplet@ngyro.com \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.