From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +NtmMxoWK2SJVAAASxT56A (envelope-from ) for ; Mon, 03 Apr 2023 20:08:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 4KpgMhoWK2Sa1AAAG6o9tA (envelope-from ) for ; Mon, 03 Apr 2023 20:08:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5FE7B13A3D for ; Mon, 3 Apr 2023 20:08:26 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjOb8-00030t-8F; Mon, 03 Apr 2023 14:08:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjOb5-0002yb-CJ for guix-patches@gnu.org; Mon, 03 Apr 2023 14:08:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjOb5-0002ku-3T for guix-patches@gnu.org; Mon, 03 Apr 2023 14:08:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pjOb4-0005Wc-Sp for guix-patches@gnu.org; Mon, 03 Apr 2023 14:08:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62642] [PATCH] services: certbot: Fix nginx crash when certbot is used without domains Resent-From: Saku Laesvuori Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 03 Apr 2023 18:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62642 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Bruno Victal Cc: 62642@debbugs.gnu.org Received: via spool by 62642-submit@debbugs.gnu.org id=B62642.168054522821153 (code B ref 62642); Mon, 03 Apr 2023 18:08:02 +0000 Received: (at 62642) by debbugs.gnu.org; 3 Apr 2023 18:07:08 +0000 Received: from localhost ([127.0.0.1]:45208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjOaB-0005V7-N8 for submit@debbugs.gnu.org; Mon, 03 Apr 2023 14:07:07 -0400 Received: from vmi571514.contaboserver.net ([75.119.130.101]:42598 helo=mail.laesvuori.fi) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjOa9-0005Uy-LM for 62642@debbugs.gnu.org; Mon, 03 Apr 2023 14:07:06 -0400 Received: from X-kone (88-113-24-127.elisa-laajakaista.fi [88.113.24.127]) by mail.laesvuori.fi (Postfix) with ESMTPSA id A950B340121; Mon, 3 Apr 2023 20:07:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laesvuori.fi; s=mail; t=1680545251; bh=cXaFYCSjaVO9ycKYI9ZVzu5lcaPPsTGU4Vb+UUd8dTY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=G/x4pO6imx10f3EstPjAMyiDSiKfPD7mqifJOsUX9+Lqv32b/8Glcxxmp5ug91YhU s9P2orQ5szFlROp/Z2SMP7eDoyj7cMsrs28r5fBCQw7I5KREWAL1cFTrsLhiQr/EJK gtl/pi2BhPSLXm9A+oL0S1uGTvzKBIY7JfrNEN5A= Date: Mon, 3 Apr 2023 21:06:59 +0300 Message-ID: <20230403180659.zhbtbfnn2uhgplgc@X-kone> References: <20230403133241.14760-1-saku@laesvuori.fi> <66755b58-1cb1-eae6-a4ac-69c174ed58aa@makinata.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dpysbmjgn352fvvp" Content-Disposition: inline In-Reply-To: <66755b58-1cb1-eae6-a4ac-69c174ed58aa@makinata.eu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Saku Laesvuori X-ACL-Warn: , Saku Laesvuori via Guix-patches From: Saku Laesvuori via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680545306; a=rsa-sha256; cv=none; b=DbqdbUQwv3og6rN/qdi0/8zpBI+GA2dauyw7eJ/4inCypsowcTM12NB0Ui9MeqLgmPXbb8 74oEoltAqb1to8uCyqUvV9c3kbKw55OjAYW8tYH8VIoW5Po09k8j9xvNeIwGJYMrMgVgbd NEoMt+73AwYolMrrWsnen2ftemGJsansZ5qVqBbYqpkJX1PWGKa0EVtxbFMHJFpQ+6WQYa ebhMLKuEwMRIiHGIgWOEM2HHIGaXoAhY4MbWRCbiQNDl04rc/f5QJUjRreDGMgnZgYaUCb RsSrYaJRVOniFfe5gR1HEIA3vLaOzbkARq3rcB+K9XRcYU+hMEWchmlvUd9kfw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=laesvuori.fi header.s=mail header.b="G/x4pO6i"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680545306; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=cXaFYCSjaVO9ycKYI9ZVzu5lcaPPsTGU4Vb+UUd8dTY=; b=shH7MEZFsfmHrhu7o+B3sIxF+SD5HT2iZMGAlgoEEYUnW5Iwbd8tazyF6mezLiKVC3P7vm StLlqgAxMjw5VWWYDdKxmEPgO+Ml0nty5+JeuOfEacfbJCcx2QpcXAt4R63E6/O50OYueh MuST1b33JrK5Xhvnc3Vcx7ijJGitl9Hg4dD/iBBOFEOBOlsSTM/OGO5gApvcobymkhs0GS 3AGIyDzEsncp6vo+fz1plLThVjWwf+YGmDbeg87rkGFveRDyK6bbXGYhRrn0CjL6t3UyPh KjFiEh16t7t8IL9IejzvAygxUw2eFK16xwxHpNDbjfouY7kzBCa3OdU1gIKNUw== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=laesvuori.fi header.s=mail header.b="G/x4pO6i"; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -5.82 X-Spam-Score: -5.82 X-Migadu-Queue-Id: 5FE7B13A3D X-TUID: 8p5lemwKs6Eb --dpysbmjgn352fvvp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > Is there a use-case for certbot without any certificate configurations provided? I was writing a service that extends certbot if a configuration option for it is set to #t. To me it seems that it is currently impossible to view the configuration in the service type definition, so I worked around it by extending certbot-service-type with an empty list if the option is set to #f. > IMO it looks to me that the 'certificates' field shouldn't have a default value > configured instead? Wouldn't that mean that users who use certbot only via services that extend it would have to configure 'certificates' to () manually and have their nginx configuration crash if they remove the extending services and forget to remove the certbot service? - Saku --dpysbmjgn352fvvp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoMkZR3NPB29fCOn/JX0oSiodOjIFAmQrFcMACgkQJX0oSiod OjL03hAAtugxfqNZwU6+ZtvqYoQzGongSA4sAzbNDUPImDWFxsKw7qD4t9i74O+z tcf/9m24APdFZ2lKK6op706J6364BN5w2H5MY10bRJyyvJpM6OD4zy0+tvxTCcGZ kJ6nhL19RtfLRF/Ov2/L3zNkITeMin5meYl9Grsvf1eRmohevwU+ogKediT4Zd81 oEKgsSBT0wxWVz+myzyo2jNb8PTMNL54Wj+UatyENBGNepLgRhKenvNeP+RQbzcX Ft9gLHjsdxmXePCLic1GegwYELRX8CEXcng+chot7ZG5xsEmQkpk263Vw4k7rqM/ 3LNTigulxoPLRVnbqEilS2e9/+SoXWRUes5e75XtOJu+Q2CSa74a50PG5JJwmPnJ bXd4VRDXk1E+uRicXpw2ZFV0advqOz24HfozeA3m1XNr+fs7cCFDgI18oGFlreIz Hm3LoTSU+B7K6GvFcpjR/IwxoBu1bDXg05lGT/ou1F5Ko/Hpgghc0hBVYaWLkzL0 eDSU3ZDleQ+Y0dMZQdBtS6OLfWNy4BCdMVgqMLXNbZ0qkFaOPcMa1vFb53HyYgNM IywM7H8mszjSHmndr8Zezue0G48m80l2IWb5Dg+RRnZa/84XGZaHiN7sEEIJ2NpE eD1w/+4G08zzJ45hFHdbb7sWxrV7VZQz+FnbPuoI6QzQ9VBghmo= =1Qqd -----END PGP SIGNATURE----- --dpysbmjgn352fvvp--