all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Julien Lepiller <julien@lepiller.eu>
Cc: 62171-done@debbugs.gnu.org
Subject: bug#62171: [PATCH 0/2] Fix source build of OpenJDK 9 and 10
Date: Thu, 16 Mar 2023 10:10:42 +0100	[thread overview]
Message-ID: <20230316101042.48c0bc55@tangletp> (raw)
In-Reply-To: <AFB5B803-FAB8-479D-A559-82A59BCB99A5@lepiller.eu>

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]



On Tue, 14 Mar 2023 08:02:26 +0100
Julien Lepiller <julien@lepiller.eu> wrote:

> Both LGTM. The snippet doesn't need to end with #t anymore. Also not
> sure if it's my mail client or the patch, but there's a newline
> missing at the end of the snippets, before sha256.

Good hint: That newline was left out only in the email. I need to
re-check my client's configuration next time.

Thanks for the review,

with your changes pushed as

7636c49b45adb9870cf416c64bde032ec858a820

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

      reply	other threads:[~2023-03-16  9:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13 22:49 [bug#62171] [PATCH 0/2] Fix source build of OpenJDK 9 and 10 Björn Höfling
2023-03-13 22:52 ` [bug#62171] [PATCH 1/2] gnu: openjdk9: Build from hg Björn Höfling
2023-03-14  7:02 ` [bug#62171] [PATCH 0/2] Fix source build of OpenJDK 9 and 10 Julien Lepiller
2023-03-16  9:10   ` Björn Höfling [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230316101042.48c0bc55@tangletp \
    --to=bjoern.hoefling@bjoernhoefling.de \
    --cc=62171-done@debbugs.gnu.org \
    --cc=julien@lepiller.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.