From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 4MY0AaY8/mMCPwEAbAwnHQ (envelope-from ) for ; Tue, 28 Feb 2023 18:40:54 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kHlQAKY8/mMWUgEAG6o9tA (envelope-from ) for ; Tue, 28 Feb 2023 18:40:54 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 965E62486E for ; Tue, 28 Feb 2023 18:40:53 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="Sxqe/g+H"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677606053; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=DskgGtcoREawGdAGvzf78UwwbIEJY8S1blnB7JugkXk=; b=Loblj4nP8OyjEAb4mO+CHbwPaPn1IthRkSnUyLbLDOifjwpd8R8Y7kIXeqNR+lToJG74A3 VZZe9kA2KdwFbcMYFf+sFvWNqjINxCIIZ3CIbVSwSFQJoWaIJxh2Wl1vk34oq4l2HvHrWP 0fLYXHSqa+7crDt/QMS1VH3p8fVfQA/XeEhIgO1wSp0/0MBBA94cKfs27RtmTDcxhT3W7x QYy85zUyzLpi1+fbYY5QT0HIxcfA2vh71cgGj1ey2NJwXe9uSIDHWYomuDnaQ6rfY8Nvj1 eYyvAUEnj7/In7fMT0AnNezbBuHfJVzb2Vx+KuDoEvUg5rXCZLu3qVVQDsImrg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b="Sxqe/g+H"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677606053; a=rsa-sha256; cv=none; b=rNLZSK8401dQXL66qYv+xZ6AxBDP2gPyIEg2CAg6fCsHb7x0hvPtbj3f8sWn70xWVDFzNR zdy4zOclrfqfawzQP2ADMipYQeSj4GNnNOnY3pPKl2puyWrLxgjRhdhWkqk6LJEstdk1hY RyKUMpcF3oYvA1/imzlA829T50k1G/8Nre1yOWNL+hV7NMfRFKHsBglpMGHeZOCBJrTYZ9 Vfjx4jN6GOgIORADSFfjYiHWMYupT0xq/M2j3u4mITqQfiA6vAJNWSpS5rg09Ps6upVH/T gHjzpyDlpfWCayECHhC0xjWL6kdQPTH743O+FM/26PML+le9PDRLlYb/tMKwyg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pX3xp-0001IZ-HW; Tue, 28 Feb 2023 12:40:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX3xf-0001DF-Kk for guix-patches@gnu.org; Tue, 28 Feb 2023 12:40:24 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pX3xV-0001dr-1L; Tue, 28 Feb 2023 12:40:15 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pX3xK-0006vH-J7; Tue, 28 Feb 2023 12:40:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61873] [PATCH core-updates] gnu: libgc: Update to 8.2.2 and remove '--disable-munmap'. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: whatson@tailcall.au, andreas@enge.fr, mail@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, rekado@elephly.net, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Tue, 28 Feb 2023 17:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61873 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61873@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Andrew Whatson , Andreas Enge , Christopher Baines , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Andrew Whatson , Andreas Enge , Christopher Baines , Josselin Poiret , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by submit@debbugs.gnu.org id=B.167760596026551 (code B ref -1); Tue, 28 Feb 2023 17:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Feb 2023 17:39:20 +0000 Received: from localhost ([127.0.0.1]:51938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX3wb-0006u8-5F for submit@debbugs.gnu.org; Tue, 28 Feb 2023 12:39:20 -0500 Received: from lists.gnu.org ([209.51.188.17]:36860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pX3wW-0006tt-AU for submit@debbugs.gnu.org; Tue, 28 Feb 2023 12:39:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX3wV-00007u-4V for guix-patches@gnu.org; Tue, 28 Feb 2023 12:39:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pX3wN-0001Ji-AT; Tue, 28 Feb 2023 12:39:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=DskgGtcoREawGdAGvzf78UwwbIEJY8S1blnB7JugkXk=; b=Sxqe/g+H3zWYbL XmIAURUvzX0b70iFZUnx6w4W2SW6rHzDHN9lwsM2cXBE1CEjRz6CaTqHQn8nVy2IPfszHlLuBGy84 Y00cxBDRwCNBKXY4GZfHcvPbcPywn97d9VGelbqMJPOyocx22VV2BlUBv7v8Zl8SRwfXXLhyXbIE9 YPIvjlkeFq/rmxppHhEpTkC7qsgDg6foHOsI/ksoEzYfx+6keiYxm2TrEoAfww00CDM46YB5ZNbwq YdiRU/Az9jkqv+xaZlKOtPzsdjP39rCKXnz4hXd7IHZdQgFSgsL4U4v8XC2/ZG3wG0hZT2Ju9dR8r CixVRAADAc/ZT2cFUxgw==; Received: from [193.50.110.164] (helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pX3wM-00029T-G3; Tue, 28 Feb 2023 12:39:02 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Tue, 28 Feb 2023 18:38:54 +0100 Message-Id: <20230228173854.25132-1-ludo@gnu.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Spam-Score: -2.49 X-Spam-Score: -2.49 X-Migadu-Scanner: scn0.migadu.com X-Migadu-Queue-Id: 965E62486E List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: l+LtfrkSo7LP * gnu/packages/bdw-gc.scm (libgc): Update to 8.2.2. [arguments]: Remove "--disable-munmap" from #:configure-flags. * gnu/packages/guile.scm (guile-3.0)[source]: Leave 'test-out-of-memory' test untouched. (guile-next)[arguments]: Likewise, in 'skip-failing-tests' phase. (guile-for-guile-emacs)[arguments]: Likewise, in 'bootstrap' phase. --- gnu/packages/bdw-gc.scm | 9 +++------ gnu/packages/guile.scm | 16 +++------------- 2 files changed, 6 insertions(+), 19 deletions(-) Hello Guix! This is another proposal for a world-rebuild change, hopefully the latest (I swear!). It’s quite important because it fixes a libgc bug that led us to build libgc with ‘--disable-munmap’, meaning it would not return memory to the OS: https://github.com/ivmai/bdwgc/issues/353 Thanks to Andrew Whatson for tackling this and for letting me know! I tested on x86_64-linux on top of 4895846197bd445dd68c832364c667dea4337f8c like so: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix build guix guile@2.2 guile@2.0 -nguix build: warning: ambiguous package specification `guile@2.2' guix build: warning: choosing guile@2.2.7 from gnu/packages/guile.scm:253:2 /gnu/store/4nhq6kmqcfk2qnzhi4xifbb0zjav0f01-guile-2.0.14-debug /gnu/store/4p1l5bdxxbyyqc3wh0d07jv9rp1pdcy7-guile-2.0.14 /gnu/store/k47958rhcrk176i9sabxda2rgmnlig4c-guile-2.2.7-debug /gnu/store/ka0v3fk21lqrnwj4fzbf8z154mpbnjvx-guile-2.2.7 /gnu/store/agrv086cfa0a5f9cmj94k9zgwi1a08q6-guix-1.4.0-3.d5fece6 --8<---------------cut here---------------end--------------->8--- Given that the test suite of Guix passed and that everything in between went fine, I’m rather confident. Thoughts? Ludo’. diff --git a/gnu/packages/bdw-gc.scm b/gnu/packages/bdw-gc.scm index cfa037dec0..86caa62d7e 100644 --- a/gnu/packages/bdw-gc.scm +++ b/gnu/packages/bdw-gc.scm @@ -1,5 +1,5 @@ ;;; GNU Guix --- Functional package management for GNU -;;; Copyright © 2012, 2013, 2014, 2016, 2017, 2020, 2021 Ludovic Courtès +;;; Copyright © 2012, 2013, 2014, 2016, 2017, 2020, 2021, 2023 Ludovic Courtès ;;; Copyright © 2014 Mark H Weaver ;;; Copyright © 2016, 2018 Leo Famulari ;;; Copyright © 2017 Rene Saavedra @@ -34,14 +34,14 @@ (define-module (gnu packages bdw-gc) (define-public libgc (package (name "libgc") - (version "8.0.6") + (version "8.2.2") (source (origin (method url-fetch) (uri (string-append "https://github.com/ivmai/bdwgc/releases" "/download/v" version "/gc-" version ".tar.gz")) (sha256 (base32 - "04ga3c95w5az5sznzm73j19lvvfpf6k4sgkpjqsmjxpsr6mi8j9v")))) + "181ni2rn9qjbl4ilqdjrd1a4h8siv5bgmzqgg4595q32n2y0f0gk")))) (build-system gnu-build-system) (arguments (list @@ -50,9 +50,6 @@ (define-public libgc ;; Install gc_cpp.h et al. "--enable-cplusplus" - ;; Work around . - "--disable-munmap" - ;; In GNU/Hurd systems during the 'check' phase, ;; there is a deadlock caused by the 'gctest' test. ;; To disable the error set "--disable-gcj-support" diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm index c2ffbefeec..64a815dbd4 100644 --- a/gnu/packages/guile.scm +++ b/gnu/packages/guile.scm @@ -325,11 +325,8 @@ (define-public guile-3.0 (patches '()) ;; Replace the snippet because the oom-test still ;; fails on some 32-bit architectures. - (snippet '(begin - (substitute* "test-suite/standalone/Makefile.in" - (("test-out-of-memory") "")) - (for-each delete-file - (find-files "prebuilt" "\\.go$")))))) + (snippet '(for-each delete-file + (find-files "prebuilt" "\\.go$"))))) ;; Build with the bundled mini-GMP to avoid interference with GnuTLS' own ;; use of GMP via Nettle: . @@ -444,10 +441,7 @@ (define-public guile-next (display ,version port))))) (add-before 'check 'skip-failing-tests (lambda _ - (substitute* "test-suite/standalone/test-out-of-memory" - (("!#") "!#\n\n(exit 77)\n")) - (delete-file "test-suite/tests/version.test") - #t)))))) + (delete-file "test-suite/tests/version.test"))))))) (native-inputs (modify-inputs (package-native-inputs guile-3.0) (prepend autoconf @@ -571,10 +565,6 @@ (define-public guile-for-guile-emacs (substitute* "test-suite/tests/version.test" (("\\(pass-if \"version reporting works\"" m) (string-append "#;" m))) - ;; Warning: Unwind-only `out-of-memory' exception; skipping pre-unwind handler. - ;; FAIL: test-out-of-memory - (substitute* "test-suite/standalone/Makefile.am" - (("(check_SCRIPTS|TESTS) \\+= test-out-of-memory") "")) (patch-shebang "build-aux/git-version-gen") (invoke "sh" "autogen.sh") base-commit: 4895846197bd445dd68c832364c667dea4337f8c -- 2.39.1