From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QNX/CFOz7WMqtAAAbAwnHQ (envelope-from ) for ; Thu, 16 Feb 2023 05:38:43 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id YKk9CVOz7WNmJQEA9RJhRA (envelope-from ) for ; Thu, 16 Feb 2023 05:38:43 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7459939BFB for ; Thu, 16 Feb 2023 05:38:42 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSW28-00062G-CI; Wed, 15 Feb 2023 23:38:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSW25-00060g-7U for bug-guix@gnu.org; Wed, 15 Feb 2023 23:38:09 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSW24-0007sn-V0 for bug-guix@gnu.org; Wed, 15 Feb 2023 23:38:08 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSW24-0003P1-Qa for bug-guix@gnu.org; Wed, 15 Feb 2023 23:38:08 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#32026: [PATCH 10/10] gnu: icecat: Unbundle nss and nspr. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 16 Feb 2023 04:38:08 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32026 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 32026@debbugs.gnu.org Cc: mhw@netris.org, ludo@gnu.org, Jonathan Brielmaier , Maxim Cournoyer Received: via spool by 32026-submit@debbugs.gnu.org id=B32026.167652225912975 (code B ref 32026); Thu, 16 Feb 2023 04:38:08 +0000 Received: (at 32026) by debbugs.gnu.org; 16 Feb 2023 04:37:39 +0000 Received: from localhost ([127.0.0.1]:34601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSW1a-0003NC-0n for submit@debbugs.gnu.org; Wed, 15 Feb 2023 23:37:38 -0500 Received: from mail-qv1-f53.google.com ([209.85.219.53]:39748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSW1F-0003LI-18 for 32026@debbugs.gnu.org; Wed, 15 Feb 2023 23:37:17 -0500 Received: by mail-qv1-f53.google.com with SMTP id i5so580952qvp.6 for <32026@debbugs.gnu.org>; Wed, 15 Feb 2023 20:37:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Opqu4FKBLv2hB4HOdC3H4JIevFK9DoiT/uNzAQALBzw=; b=YY6czhZRif+bZZLRPz0ej2/W/ErVlGyNP9DUn/q9jrIV8BiDbZxO6wqa9vBoTdMuwr vGnZCwJT12s8+NMSrte14ZSHYcIGW/hOowGIDtuk/g7E1aE28T0vIs97Fr+SNk2lH79s Xl+Ji1LlsjpEfvve/tgaZBf9UGyzgntORvDAqdQgGT0fhkSKPaEmUt2BwHZL/WCo8TAx dsKyQ+NOG8cbASJ4b8LVCys8RK0U/EgEgymGYo1/HbZiT1H1xIGyxHe9q14Fi7IKpM+a vcL71Y3oUfzLl7gNxM4cLBaTiF+4xkxQwADaidSrGFUDot2I/h19heQX6F0FrwyOVRiz xHBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Opqu4FKBLv2hB4HOdC3H4JIevFK9DoiT/uNzAQALBzw=; b=gYiLDH78uSA2XxfYndmqWs3rsZNyAnRGrQI79Vju8kWmUTZbWzEoqzOUceAbXCw3Bn MRDMMMEpPQdH77riJYRFxTlAFkVJqRaDOEYy/pTiAqbHSWCarKEQPiAcDQdJAPJPXAKy TW8raewFE/LSGJRocqbXD8mEJ8jVL5CmbdJz5Rp+hbICDLi982lz/kQRhd25tjl1zcHd 2B0RX0j9xSve86OgrZJ3HKacSTF/I/sSscDHUAThJvYvoS3Hr4AaByEzUN8DcyDlt6BG qDZH1JRNDMQdI/FAgW2RGOUY1Dkrwwih9BbEEHryROYvXmrMwQ0Pmqz9jnoKYS3XPTYX ecsA== X-Gm-Message-State: AO0yUKW3XRZjYKbl6/DB2Qx0jZ240G34K+228UtLRV64Bo7TNNOjBoQc Qxr+KRdcRRoQdzvt35m7GidbSiHLPyUHmP5s X-Google-Smtp-Source: AK7set8Kur6nIKDr9xbfnjDpof25ftA0b1GGBXE0kjCq69f5VHu3yJLFTtZqOTVwdCD9HkvzW8Iwrg== X-Received: by 2002:a05:6214:27ce:b0:56e:bbd9:1c0e with SMTP id ge14-20020a05621427ce00b0056ebbd91c0emr8274300qvb.5.1676522231380; Wed, 15 Feb 2023 20:37:11 -0800 (PST) Received: from localhost.localdomain (dsl-155-109.b2b2c.ca. [66.158.155.109]) by smtp.gmail.com with ESMTPSA id t85-20020a374658000000b007186c9e167esm452992qka.52.2023.02.15.20.37.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Feb 2023 20:37:11 -0800 (PST) From: Maxim Cournoyer Date: Wed, 15 Feb 2023 23:36:48 -0500 Message-Id: <20230216043649.32119-10-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230216043649.32119-1-maxim.cournoyer@gmail.com> References: <20230216043649.32119-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676522322; a=rsa-sha256; cv=none; b=iB/dqzCk3GJ/M7EX58Y/U6Ml2pSL4Rh/993sIGZtPSV+M9vsg7eFniR7GIcnTkM6lB6RuS tTUUcrpHhoBjtiIejcElKKIfejulUDq/+tJ2C7blF2mhkxQ6FVb3b4TP1IZH8xVd5w/+7X D/JYiJZluFA3FNMit43wJEWKI0IWfzOYqg0qlg8fvKRTac+L8XcaEyk6ILesD+W/klSOii Sw0y9/CmCzntK7b/pWvwZAA/sdfrg+Xr+FjNbKARRj0QoDzhab0j7ssCdNOei4hp/Iic8C AGxCjLielGbR9+mOTGXM2kksKfpaqmyxKqpf0VnU9ao7nMw1fdl+QyAI5i2ZNw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=YY6czhZR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676522322; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Opqu4FKBLv2hB4HOdC3H4JIevFK9DoiT/uNzAQALBzw=; b=HE/4dStPLcRqyH9p6EtNNMy+TY1QhO1suTiparTo+FTsj+R3lqQUKB2rNtxbXumhjdZ0B6 T0G8tTT4giXyD/qrISaiankF82svGSUQMjBZuh9+XEPzsgrbz7XclFB6r1kaIeoSrwYJ6A KL9r8bIpGL7iGgfR9QPd7qJ0Lmw5xEWjvoQGePBqMfhNGwzi6oN2Sda73oypGm15s7KXvf ooa3hbPvu+2t+ZYxhIwTm3S2QqUK4haeDszftVbp4HbDjalQaYW813aNFpkOEFLCOnpOMV 3xHT/cg6m34QAF8pNXNMUeVlDQSuQ1UafUN+Y7S3PwLNOBZQBWwVgcuUWqpcoQ== X-Migadu-Scanner: scn1.migadu.com X-Spam-Score: 1.48 X-Migadu-Queue-Id: 7459939BFB X-Migadu-Spam-Score: 1.48 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=YY6czhZR; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: qz7aw06tbMbu * gnu/packages/gnuzilla.scm (icecat-minimal) [inputs]: Add nspr-next and nss-next. [configure-flags]: Re-instate the "--with-system-nspr" and "--with-system-nss" configure flags. [phases] {remove-bundled-libraries}: Update comment. --- Changes in v2: - New commit gnu/packages/gnuzilla.scm | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index 8e90327ea4..ced3f75ecf 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -723,10 +723,8 @@ (define-public icecat-minimal mit-krb5 hunspell libnotify - ;; See - ;; and related comments in the 'remove-bundled-libraries' phase. - ;; UNBUNDLE-ME! nspr - ;; UNBUNDLE-ME! nss + nspr-next + nss-next shared-mime-info sqlite eudev @@ -821,12 +819,8 @@ (define-public icecat-minimal ;; UNBUNDLE-ME! "--with-system-theora" ; wants theora-1.2, not yet released ;; UNBUNDLE-ME! "--with-system-libvpx" "--with-system-icu" - - ;; See - ;; and related comments in the - ;; 'remove-bundled-libraries' phase below. - ;; UNBUNDLE-ME! "--with-system-nspr" - ;; UNBUNDLE-ME! "--with-system-nss" + "--with-system-nspr" + "--with-system-nss" ;; UNBUNDLE-ME! "--with-system-harfbuzz" ;; UNBUNDLE-ME! "--with-system-graphite2" @@ -875,12 +869,9 @@ (define-public icecat-minimal ;; FIXME: A script from the bundled nspr is used. ;;"nsprpub" ;; - ;; FIXME: With the update to IceCat 60, using system NSS - ;; broke certificate validation. See - ;; . For now, we use - ;; the bundled NSPR and NSS. TODO: Investigate, - ;; and try to unbundle these libraries again. - ;; UNBUNDLE-ME! "security/nss" + ;; FIXME: Some of the bundled NSS sources are used + ;; to build third_party/prio. + ;;"security/nss" ;; ;; TODO: Use more system media libraries. See: ;; -- 2.39.1