From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mJXhE81iq2N51wAAbAwnHQ (envelope-from ) for ; Tue, 27 Dec 2022 22:25:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 6OHmEs1iq2NfZQEAG6o9tA (envelope-from ) for ; Tue, 27 Dec 2022 22:25:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 145333F707 for ; Tue, 27 Dec 2022 22:25:33 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAHRk-0000of-6o; Tue, 27 Dec 2022 16:25:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAHRi-0000oR-OL for guix-patches@gnu.org; Tue, 27 Dec 2022 16:25:14 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAHRX-0003LH-4v for guix-patches@gnu.org; Tue, 27 Dec 2022 16:25:14 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pAHRW-0007p5-P0 for guix-patches@gnu.org; Tue, 27 Dec 2022 16:25:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60365] [PATCH 0/4] Rationalize 'PS1' handling in home, system, and shell Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 27 Dec 2022 21:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60365 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60365@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167217624329981 (code B ref -1); Tue, 27 Dec 2022 21:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Dec 2022 21:24:03 +0000 Received: from localhost ([127.0.0.1]:56586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAHQZ-0007nU-Bo for submit@debbugs.gnu.org; Tue, 27 Dec 2022 16:24:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:46492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAHQY-0007nA-1D for submit@debbugs.gnu.org; Tue, 27 Dec 2022 16:24:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAHQX-0000kQ-Qe for guix-patches@gnu.org; Tue, 27 Dec 2022 16:24:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAHQX-0003D1-AM; Tue, 27 Dec 2022 16:24:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=sZwX1fJ+dcPpPRPn6A81TuwIlDXxI8I6IXofP1f55ZI=; b=iay6vTRpEsYy/8 nWIgVfiHh0MY/REwFRIr0qnom1iyDVol3j+LEEfJrIolE2N+B2h4Lx1cKfB5oDs9OohNZyIy/3hva 7adGfEuj6oGSEBm8jEjmt7JRnsAPjLwu8D+1YzjFgONk1hCMD96t5gJArKa6NipxcZUNfUcyXrk6i CyqCrnmngzBAh2QC9Vatyy+3K2MkP91AmYf2T0PXSBsZakqiQjSCImxkU8XiFcEYguojpJ0BKA4HK C5FeMeaK+fLzG3y4aPDf6JPTJZp1Lu9kNuJ6ZGqUxWRD+mnCuveQqscXNlZM3puor6hx7LDyJgbt8 zpBx/XSY8IGnwX7JiBxA==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAHQW-0006gW-U0; Tue, 27 Dec 2022 16:24:01 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Date: Tue, 27 Dec 2022 22:23:42 +0100 Message-Id: <20221227212342.17939-1-ludo@gnu.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672176333; a=rsa-sha256; cv=none; b=NlEiKTxRnUeOsKxy6p1kKxkW83dPItV+zfZ7QM79MB/oPvvSTH+F8SOujF1AShw6dAoD2t g7pspcyYX44TLtz/J3o9RrxzPSAgRbsEQgkWYLF706eL1OvvOcpQUDVLzKNYWyezFtCW4R QLAwI64VpZxeXk7CIvSQHK6UJIEu35ehGUqS0mjoHZlzwfHDpik+HynUzcmgpgB+au2ngC ki4dFzQ4FROM9r4XB0la5WpL7AMel9lmUxpd26rtoLunvM9fRz4CKLl5oId2f5nk+AgMR/ bbd1CAoN6vW38fRvOxDLUjT8rDRYQ1oZJ8JqWX7V2IvPOQBi25Vu1zOm4W0zCQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=iay6vTRp; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672176333; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=sZwX1fJ+dcPpPRPn6A81TuwIlDXxI8I6IXofP1f55ZI=; b=bPQ2bTJ0lVWo4bkcva7AM/FgySEAiI7JOpOvF1yPDVTvZU7grEZ2sJ74xz6FW3RpiHPM7J MAuwthECO6O7ikd7EC6p/YuIBsl43TYfqV0Tbwknz7B5j6WRqGoLL7JAwF8oYcvne3jV+S u2osPwwi+m0iTfQ6ZHEwFAIt3rNs20q5d0RslnWQYRucagOV65TH1z72murtU4qDfZ5UOR BMbbgFwfaSc+jdDl14d6AVmJTOfv/vAqyNOC+d9OIRiWcFsBpPpUIcItBFZQO8iI2aL+4A ke6Z4q/YjxeFtyjn6qffc4QEVspGAXZZ2GK/UnrfJ6KgXB0ONmdcD+E2vMN+Gg== X-Spam-Score: -1.73 X-Migadu-Queue-Id: 145333F707 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=iay6vTRp; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -1.73 X-TUID: mJ46/pikX4Ie Hello! I found some things could be improved in how we deal with ‘PS1’ in Guix Home, Guix System, and ‘guix shell’ (my initial motivation was making it easy to change ‘PS1’ from a Home configuration). These patches fiddle with ‘PS1’. The most visible effect is that Guix Home’s ~/.bashrc will no longer provide a default ‘PS1’. Thoughts? Ludo’. Ludovic Courtès (4): system, home: Factorize default '.bashrc'. system: Define default 'PS1' in /etc/bashrc rather than ~/.bashrc. environment: Simplify 'PS1' suggestion on '--check'. environment: Avoid false positive on 'PS1' check. gnu/home/services/shells.scm | 41 +++--------------------------------- gnu/system.scm | 3 +++ gnu/system/shadow.scm | 33 +++++++++++++---------------- guix/scripts/environment.scm | 12 ++++++----- 4 files changed, 28 insertions(+), 61 deletions(-) base-commit: 9369c1ccf47d9bf6f2e28a9454c1c329a2044f19 prerequisite-patch-id: aae3af39aa7753dd7ed6d0584587a06d51402386 -- 2.38.1