From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KJRBNPh2o2Om0gAAbAwnHQ (envelope-from ) for ; Wed, 21 Dec 2022 22:13:28 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id AJeUM/h2o2OAtQAAG6o9tA (envelope-from ) for ; Wed, 21 Dec 2022 22:13:28 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 254812F4F0 for ; Wed, 21 Dec 2022 22:13:28 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p86Oo-0005Le-FV; Wed, 21 Dec 2022 16:13:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p86Of-0005GK-9L for guix-patches@gnu.org; Wed, 21 Dec 2022 16:13:07 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p86Oc-0002fA-LO for guix-patches@gnu.org; Wed, 21 Dec 2022 16:13:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p86Oc-000550-72 for guix-patches@gnu.org; Wed, 21 Dec 2022 16:13:02 -0500 Subject: bug#60120: [PATCH 01/28] gnu: Add ocaml-5.0. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 21 Dec 2022 21:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60120 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: pukkamustard Cc: 60120-done@debbugs.gnu.org Mail-Followup-To: 60120@debbugs.gnu.org, julien@lepiller.eu, pukkamustard@posteo.net Received: via spool by 60120-done@debbugs.gnu.org id=D60120.167165715519508 (code D ref 60120); Wed, 21 Dec 2022 21:13:02 +0000 Received: (at 60120-done) by debbugs.gnu.org; 21 Dec 2022 21:12:35 +0000 Received: from localhost ([127.0.0.1]:53963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p86OA-00054a-Qf for submit@debbugs.gnu.org; Wed, 21 Dec 2022 16:12:35 -0500 Received: from lepiller.eu ([89.234.186.109]:46918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p86O7-00054U-72 for 60120-done@debbugs.gnu.org; Wed, 21 Dec 2022 16:12:33 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 98985d8e; Wed, 21 Dec 2022 21:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=fQmO9tJoQoa7 U85S3weqRDouvU+7afwFS8DaUwHXnj4=; b=CnY0s8Vcn5zZ6HV/fPZNSc2fHPKb mcZ6+FIwcqy7J7Hp7Hfd6wBPKrz1YAzn5dLifacH9rrU3WELxIkWK0zcsi5uLOpE /+ww3PuQGogQjfbntt5EzBEP+ymnFNG+6kJEJfhhVtP8MIXUiW+MIR76jjkQ91F5 OgNRNtT8yn6B6RO9eeWs+31gGa9hfNgRQvOq7Us5itx0Bkl+LTBeo/G43m54e9I9 edV3cCx5R2Or1YLHpO8zHOtGEWlGTbA3ljj7Iyao8RCpVWBO7Joe7eNlcQsnYNws 0yhoSx/+ugezeMT12/CwFv0QKHmYGlYvSIYg5z9uQRtMT2WgebK3kARrXA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 5eab4aa3 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 21 Dec 2022 21:12:12 +0000 (UTC) Date: Wed, 21 Dec 2022 22:11:53 +0100 From: Julien Lepiller Message-ID: <20221221221153.7915a496@sybil.lepiller.eu> In-Reply-To: <20221216132527.2539-1-pukkamustard@posteo.net> References: <20221216132224.2229-1-pukkamustard@posteo.net> <20221216132527.2539-1-pukkamustard@posteo.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1671657208; a=rsa-sha256; cv=none; b=P2jX29IeML/QxSZ5tvrm7yPzhz+kdrDa+o+5jGWPIiVnqauHGUMDMVzL2KL11fSjFs4KbH efgmn7pyh6aMWL3kzjE+H0BJ2ej4gpPqI1PQ+MYpHxJ0s7M7CAY6tnMIRaiNAvcuzzk6BE Qx6XuCT+GVolISGcYFepfD6kRx0vJ+WDz/EE8IwRMBZiJ8WTvjH0bTPoNj+hishX1qt20q 3LZa/hdxB2msBiqJ1xsvjkUDYqqewoDlsFlr5v+gUQm+mxyXBy0dbRIkzVxSSaAQRw9JbF fGe3BQCzm3hxNZZhmZNcd4OuFfxrOTB+2MKT5HTvDmCIHA7RJ1OIC97HOFVj/Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=CnY0s8Vc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1671657208; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7Qw7C8PZdgLqtBjjGzRnJ8pqscfEU4JBmF2C3A/T+UI=; b=L2t0nzyT/6APCh2aRUwHAgvcntc3U4MJNWYNj/0H6pw5ZAqiEmovkPOJad8TMoN/+EDn3C SXGqDlHBJfcGbilAWINtYjwl5gCdi7WMjTi3yDBbh/rIkIRZ9wstCQzLsrKnVy3Ww+fXr0 oh3ZcDrWEJbMdc87gb3aUkJaJn3ceBF6OCpGQ8bOOW2Oyf/02Xzg7BjRuNFwb+DB65AtnE xNPVsbfEVWclQMKVUq1ecXBvRvj7kVxj4NxyiTbSZ9kmcntlL6CE/CELgLrsw6C+Gg6ic+ 3Up+xjOf0QEEkquVGoZGwIQ1Ww6HAW1FCviPNW1bPi4T4iB61LIFWa+OIbkKYQ== X-Spam-Score: -2.40 X-Migadu-Queue-Id: 254812F4F0 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=CnY0s8Vc; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none) X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -2.40 X-TUID: V0kKrCL0Unch Hi! Thanks for the patch series. Pushed to master with the following fixes: [01/28] > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/ocaml/ocaml") > + (commit version))) is missing a file-name field (guix lint complains about it), like this: (file-name (git-file-name name version)) [04/28] > +(define-public ocaml5.0-result but this was not added to the properties of ocaml-result. [06/28] 0.2.1 is the latest version. [07/28] > "https://gitlab.inria.fr/fpottier/monolith/-/archive/20210525/archive.tar.gz" I think this might not be a stable archive, and guix lint complains about the name, so I used git-fetch instead. [08/28] 0.3.0 is the latest version. [09/28] There was a space at the end of description, and it contained typos. You should use https instead of http when available. There was a tab in the patch. [20/28] Description does not match our usual style. It seems you didn't define ocaml-eio as public, because it fails to build. Would be great to fix, wdyt? [21/28] Missing synopsis and description. [22/28] Description does not match our usual style. [23/28] Missing synopsis and description. [24/28] Missing synopsis and description.