[bug#58610] [PATCH] gnu: rust-generic-array-0.14: Fix build.

[bug#58610] [PATCH] gnu: rust-generic-array-0.14: Fix build.

[Michael Rohleder]

* gnu/packages/crates-io.scm (rust-generic-array-0.14)[arguments]: Add #:tests? #false.
---
 gnu/packages/crates-io.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 502972ffc5..afd1305018 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -24886,7 +24886,8 @@ (define-public rust-generic-array-0.14
           "05qqwm9v5asbil9z28wjkmpfvs1c5c99n8n9gwxis3d3r3n6c52h"))))
     (build-system cargo-build-system)
     (arguments
-     `(#:cargo-inputs
+     `(#:tests? #false                  ;doc test fails
+       #:cargo-inputs
        (("rust-serde" ,rust-serde-1)
         ("rust-typenum" ,rust-typenum-1)
         ("rust-version-check" ,rust-version-check-0.9))
-- 
2.38.0

[bug#58610] [PATCH] gnu: rust-generic-array-0.14: Fix build.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]


Michael Rohleder <mike@rohleder.de> writes:

> * gnu/packages/crates-io.scm (rust-generic-array-0.14)[arguments]: Add #:tests? #false.
> ---
>  gnu/packages/crates-io.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

This may fix the build, but instead we'd just be shipping software where
the test suite fails.

If we do want to go that way of disabling the test suite, I think it
would be good to make sure the issue is reported upstream, and link to
that bug report in the package definition, does that make sense?

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

[bug#58610] [PATCH] gnu: rust-generic-array-0.14: Fix build.

[Maxim Cournoyer]

Hello Michael,

Christopher Baines <mail@cbaines.net> writes:

> Michael Rohleder <mike@rohleder.de> writes:
>
>> * gnu/packages/crates-io.scm (rust-generic-array-0.14)[arguments]: Add #:tests? #false.
>> ---
>>  gnu/packages/crates-io.scm | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> This may fix the build, but instead we'd just be shipping software where
> the test suite fails.
>
> If we do want to go that way of disabling the test suite, I think it
> would be good to make sure the issue is reported upstream, and link to
> that bug report in the package definition, does that make sense?

Friendly ping.

-- 
Thanks,
Maxim

bug#58610: [PATCH] gnu: rust-generic-array-0.14: Fix build.

[Michael Rohleder]

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]

Hello Christopher!

Thank you for reviewing and sorry for the delay!

Christopher Baines <mail@cbaines.net> writes:
> This may fix the build, but instead we'd just be shipping software where
> the test suite fails.
>
> If we do want to go that way of disabling the test suite, I think it
> would be good to make sure the issue is reported upstream, and link to
> that bug report in the package definition, does that make sense?

I guess this make a lot of sense, but I can't do this, because I don't
have any rust/cargo knowledge, no gh account etc.

This patch was just a quick hack to get synapse working.  I should have
thought about fixing it better than just disabling a test.

Sorry for the waste of time and the noise -> closing.

-- 
There are two types of hard drives: those that have failed, and those that will.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]